[continued from previous message]
<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div style="font-family:menlo, consolas, monospace;">Alex,<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><
div style="font-family:menlo, consolas, monospace;">I see there's a new upload this morning with updated upstream - does it address this bug?<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas,
monospace;">Chris,<br></div><div style="font-family:menlo, consolas, monospace;">Development is happening on the master branch, not main [1] - you could try an MR against that when it's updated with this morning's upload.<br></div><div style="font-family:
menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">[1] <a href="
https://salsa.debian.org/debian/meshtastic/-/tree/master/debian?ref_type=heads">https://salsa.debian.org/debian/meshtastic/-/tree/master/debian?ref_
type=heads</a><br></div><div style="font-family:menlo, consolas, monospace;"><b></b><br></div><div style="font-family:menlo, consolas, monospace;">Cheers,<br></div><div style="font-family:menlo, consolas, monospace;">DH<br></div><div style="font-family:
menlo, consolas, monospace;"><br></div><div id="sig145015272"><div class="signature">-- </div><div class="signature"> Dave Hibberd</div><div class="signature"> Debian Developer</div><div class="signature"> Packet Radioist</div><div
class="signature"> MM0RFN</div></div><div style="font-family:menlo, consolas, monospace;"><br></div><div>On Sat, 19 Oct 2024, at 5:44 PM, Hibby wrote:<br></div><blockquote type="cite" id="qt" style=""><div style="font-family:menlo, consolas,
monospace;">Hi All!<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Chris - thanks for the recommendation.<br></div><div style="font-family:menlo, consolas, monospace;"><br></
<div style="font-family:menlo, consolas, monospace;">Alex - I've prepared an update to 2.5.0-2 and with that created the attached debdiff - am I ok to upload this as a hamradio team upload? I'll set a reminder to do it next weekend if I don't hear
back.<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Can I also upload that version to salsa or do you have a local repo that you're maintaining you'd like to upload?<br></div><
div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Cheers,<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Hibby<
</div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">-- <br></div><div style="font-family:menlo, consolas, monospace;"> Hibby<br></div><div style="font-family:menlo,
consolas, monospace;"> MM0RFN<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">On Thu, 3 Oct 2024, at 3:20 AM, Chris Talbot wrote:<br></div><div style="font-family:menlo,
consolas, monospace;">> Hello,<br></div><div style="font-family:menlo, consolas, monospace;">><br></div><div style="font-family:menlo, consolas, monospace;">> It looks like print_color is used in only one place, and the following<br></div><div
style="font-family:menlo, consolas, monospace;">> diff should get rid of the dependency:<br></div><div style="font-family:menlo, consolas, monospace;">> ```<br></div><div style="font-family:menlo, consolas, monospace;">> diff --git a/meshtastic/
mesh_interface.py<br></div><div style="font-family:menlo, consolas, monospace;">> b/meshtastic/mesh_interface.py<br></div><div style="font-family:menlo, consolas, monospace;">> index db057a3..e8950a7 100644<br></div><div style="font-family:menlo,
consolas, monospace;">> --- a/meshtastic/mesh_interface.py<br></div><div style="font-family:menlo, consolas, monospace;">> +++ b/meshtastic/mesh_interface.py<br></div><div style="font-family:menlo, consolas, monospace;">> @@ -14,7 +14,6 @@ from
decimal import Decimal<br></div><div style="font-family:menlo, consolas, monospace;">> from typing import Any, Callable, Dict, List, Optional, Union<br></div><div style="font-family:menlo, consolas, monospace;">> <br></div><div style="
font-family:menlo, consolas, monospace;">> import google.protobuf.json_format<br></div><div style="font-family:menlo, consolas, monospace;">> -import print_color # type: ignore[import-untyped]<br></div><div style="font-family:menlo,
consolas, monospace;">> from pubsub import pub # type: ignore[import-untyped]<br></div><div style="font-family:menlo, consolas, monospace;">> from tabulate import tabulate<br></div><div style="font-family:menlo, consolas,
monospace;">> <br></div><div style="font-family:menlo, consolas, monospace;">> @@ -153,17 +152,7 @@ class MeshInterface: # pylint: disable=R0902<br></div><div style="font-family:menlo, consolas, monospace;">> &
nbsp; def _printLogLine(line, interface):<br></div><div style="font-family:menlo, consolas, monospace;">> """Print a line of log output."""<br></div><div style="font-family:menlo, consolas,
monospace;">> if interface.debugOut == sys.stdout:<br></div><div style="font-family:menlo, consolas, monospace;">> - # this isn'
t quite correct (could cause false positives),<br></div><div style="font-family:menlo, consolas, monospace;">> but currently our formatting differs between different log<br></div><div style="font-family:menlo, consolas, monospace;">>
representations<br></div><div style="font-family:menlo, consolas, monospace;">> - if "DEBUG" in line:<br></div><div style="font-family:menlo, consolas, monospace;">> - &
nbsp; print_color.print(line, color="cyan", end=None)<br></div><div style="font-family:menlo, consolas, monospace;">> - &
nbsp; elif "INFO" in line:<br></div><div style="font-family:menlo, consolas, monospace;">> - print_color.print(line, color="white", end=None)<br></div><div style=
"font-family:menlo, consolas, monospace;">> - elif "WARN" in line:<br></div><div style="font-family:menlo, consolas, monospace;">> - &
nbsp; print_color.print(line, color="yellow", end=None)<br></div><div style="font-family:menlo, consolas, monospace;">> - elif "ERR" in line:<br></
<div style="font-family:menlo, consolas, monospace;">> - print_color.print(line, color="red", end=None)<br></div><div style="font-family:menlo, consolas,
monospace;">> - else:<br></div><div style="font-family:menlo, consolas, monospace;">> -
print_color.print(line, end=None)<br></div><div style="font-family:menlo, consolas, monospace;">> + interface.debugOut.write(line + "\n")<br></div><div style="font-family:menlo,
consolas, monospace;">> else:<br></div><div style="font-family:menlo, consolas, monospace;">> interface.debugOut.
write(line + "\n")<br></div><div style="font-family:menlo, consolas, monospace;">> ```<br></div><div style="font-family:menlo, consolas, monospace;">><br></div><div style="font-family:menlo, consolas, monospace;">> Salsa <a href="
https://
salsa.debian.org/debian/meshtastic">
https://salsa.debian.org/debian/meshtastic</a> appears to be empty,<br></div><div style="font-family:menlo, consolas, monospace;">> else I would make this an MR myself.<br></div><div style="font-family:menlo,
consolas, monospace;">><br></div><div style="font-family:menlo, consolas, monospace;">> print-color <a href="
https://pypi.org/project/print-color/#files">https://pypi.org/project/print-color/#files</a> looks to be a<br></div><div style="font-
family:menlo, consolas, monospace;">> simple library too, maybe statically compiling it or including it in<br></div><div style="font-family:menlo, consolas, monospace;">> Debian would be easier too?<br></div><div style="font-family:menlo, consolas,
monospace;">><br></div><div style="font-family:menlo, consolas, monospace;">> -- <br></div><div style="font-family:menlo, consolas, monospace;">> Respectfully,<br></div><div style="font-family:menlo, consolas, monospace;">> Chris Talbot<
</div><div><br></div><div><b>Attachments:</b><br></div><ul><li>meshtastic_2.5.0.debdiff<br></li></ul></blockquote><div style="font-family:menlo, consolas, monospace;"><br></div></body></html>
[continued in next message]
--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)