1. Forum
  2. Usenet
  3. LINUX.KERNEL

  • [PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descript

    From Andy Shevchenko@21:1/5 to [email protected] on Mon Oct 2 15:20:01 2017
    On Thu, Sep 28, 2017 at 7:02 AM, Mario Limonciello
    <[email protected]> wrote:
    Some cases the wrong type was used for errors and checks can be
    done more cleanly.

    Oops, I forgot about this patch, so, please, disregard my comment WRT
    to strncmp() use to the other patch.


    Signed-off-by: Mario Limonciello <[email protected]>
    Reviewed-by: Edward O'Callaghan <[email protected]>

    Btw, missed Suggested-by?


    - if (desc_buffer[0] != 0x4C4C4544 && desc_buffer[1] != 0x494D5720)
    - dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%*ph)\n",
    - 8, desc_buffer);
    + if (strncmp(obj->string.pointer, "DELL WMI", 8) != 0)
    + dev_warn(&wdev->dev, "Dell descriptor buffer has invalid signature (%8ph)\n",
    + desc_buffer);

    And as Darren pointed out, this fixes the logic bug as well.

    --
    With Best Regards,
    Andy Shevchenko

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From [email protected]@21:1/5 to All on Mon Oct 2 15:30:02 2017
    PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmR5IFNoZXZjaGVua28gW21h aWx0bzphbmR5LnNoZXZjaGVua29AZ21haWwuY29tXQ0KPiBTZW50OiBNb25kYXksIE9jdG9iZXIg MiwgMjAxNyA4OjE2IEFNDQo+IFRvOiBMaW1vbmNpZWxsbywgTWFyaW8gPE1hcmlvX0xpbW9uY2ll bGxvQERlbGwuY29tPg0KPiBDYzogZHZoYXJ0QGluZnJhZGVhZC5vcmc7IExLTUwgPGxpbnV4LWtl cm5lbEB2Z2VyLmtlcm5lbC5vcmc+OyBQbGF0Zm9ybSBEcml2ZXINCj4gPHBsYXRmb3JtLWRyaXZl ci14ODZAdmdlci5rZXJuZWwub3JnPjsgQW5keSBMdXRvbWlyc2tpIDxsdXRvQGtlcm5lbC5vcmc+ Ow0KPiBxdWFzaXNlY0Bnb29nbGUuY29tOyBQYWxpIFJvaMOhciA8cGFsaS5yb2hhckBnbWFpbC5j b20+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjMgOC84XSBwbGF0Zm9ybS94ODY6IGRlbGwtd21p LXNtYmlvczogY2xlYW4gdXAgd21pDQo+IGRlc2NyaXB0b3IgY2hlY2sNCj4gDQo+IE9uIFRodSwg U2VwIDI4LCAyMDE3IGF0IDc6MDIgQU0sIE1hcmlvIExpbW9uY2llbGxvDQo+IDxtYXJpby5saW1v bmNpZWxsb0BkZWxsLmNvbT4gd3JvdGU6DQo+ID4gU29tZSBjYXNlcyB0aGUgd3JvbmcgdHlwZSB3 YXMgdXNlZCBmb3IgZXJyb3JzIGFuZCBjaGVja3MgY2FuIGJlDQo+ID4gZG9uZSBtb3JlIGNsZWFu bHkuDQo+IA0KPiBPb3BzLCBJIGZvcmdvdCBhYm91dCB0aGlzIHBhdGNoLCBzbywgcGxlYXNlLCBk aXNyZWdhcmQgbXkgY29tbWVudCBXUlQNCj4gdG8gc3RybmNtcCgpIHVzZSB0byB0aGUgb3RoZXIg cGF0Y2guDQo+IA0KPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBNYXJpbyBMaW1vbmNpZWxsbyA8bWFy aW8ubGltb25jaWVsbG9AZGVsbC5jb20+DQo+ID4gUmV2aWV3ZWQtYnk6IEVkd2FyZCBPJ0NhbGxh Z2hhbiA8cXVhc2lzZWNAZ29vZ2xlLmNvbT4NCj4gDQo+IEJ0dywgbWlzc2VkIFN1Z2dlc3RlZC1i eT8NCg0KWWVzIHNvcnJ5IGFib3V0IHRoYXQuICBJJ2xsIGFkZCB0aGF0IGZvciB3aGVuIEkgZ2V0 IHY0IG91dC4NCg0KPiANCj4gDQo+ID4gLSAgICAgICBpZiAoZGVzY19idWZmZXJbMF0gIT0gMHg0 QzRDNDU0NCAmJiBkZXNjX2J1ZmZlclsxXSAhPSAweDQ5NEQ1NzIwKQ0KPiA+IC0gICAgICAgICAg ICAgICBkZXZfd2Fybigmd2Rldi0+ZGV2LCAiRGVsbCBkZXNjcmlwdG9yIGJ1ZmZlciBoYXMgaW52 YWxpZCBzaWduYXR1cmUNCj4gKCUqcGgpXG4iLA0KPiA+IC0gICAgICAgICAgICAgICAgICAgICAg IDgsIGRlc2NfYnVmZmVyKTsNCj4gPiArICAgICAgIGlmIChzdHJuY21wKG9iai0+c3RyaW5nLnBv aW50ZXIsICJERUxMIFdNSSIsIDgpICE9IDApDQo+ID4gKyAgICAgICAgICAgICAgIGRldl93YXJu KCZ3ZGV2LT5kZXYsICJEZWxsIGRlc2NyaXB0b3IgYnVmZmVyIGhhcyBpbnZhbGlkIHNpZ25hdHVy ZQ0KPiAoJThwaClcbiIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgZGVzY19idWZmZXIp Ow0KPiANCj4gQW5kIGFzIERhcnJlbiBwb2ludGVkIG91dCwgdGhpcyBmaXhlcyB0aGUgbG9naWMg YnVnIGFzIHdlbGwuDQo+IA0KPiAtLQ0KPiBXaXRoIEJlc3QgUmVnYXJkcywNCj4gQW5keSBTaGV2 Y2hlbmtvDQo=

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)