1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] profiles/default/linux: set gl_cv_type_time_t_bits

    From Mike Gilbert@21:1/5 to All on Fri Dec 17 15:50:01 2021
    This is intended to prevent packages from automatically switching to
    64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
    manner will lead to inconsistent library ABIs that fail at runtime.

    At a later time, we will introduce new profiles to enable 64-bit time_t distro-wide.

    https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration

    Bug: https://bugs.gentoo.org/828001
    Signed-off-by: Mike Gilbert <[email protected]>
    ---
    profiles/default/linux/make.defaults | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
    index 6ae7cf297cf..53ace7e229c 100644
    --- a/profiles/default/linux/make.defaults
    +++ b/profiles/default/linux/make.defaults
    @@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
    # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks dev-util/boost-build
    # because of whitespace.
    LDFLAGS="-Wl,-O1 -Wl,--as-needed"
    +
    +# Mike Gilbert <[email protected]> (2021-12-17)
    +# Prevent automagic use of 64-bit time_t.
    +gl_cv_type_time_t_bits_macro="no"
    --
    2.34.1

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Alec Warner@21:1/5 to [email protected] on Fri Dec 17 20:40:01 2021
    Can you put the bug # in the comment in the file?

    On Fri, Dec 17, 2021, 09:42 Mike Gilbert <[email protected]> wrote:

    This is intended to prevent packages from automatically switching to
    64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
    manner will lead to inconsistent library ABIs that fail at runtime.

    At a later time, we will introduce new profiles to enable 64-bit time_t distro-wide.

    https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration

    Bug: https://bugs.gentoo.org/828001
    Signed-off-by: Mike Gilbert <[email protected]>
    ---
    profiles/default/linux/make.defaults | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
    index 6ae7cf297cf..53ace7e229c 100644
    --- a/profiles/default/linux/make.defaults
    +++ b/profiles/default/linux/make.defaults
    @@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
    # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks
    dev-util/boost-build
    # because of whitespace.
    LDFLAGS="-Wl,-O1 -Wl,--as-needed"
    +
    +# Mike Gilbert <[email protected]> (2021-12-17)
    +# Prevent automagic use of 64-bit time_t.
    +gl_cv_type_time_t_bits_macro="no"
    --
    2.34.1




    <div dir="auto"><div>Can you put the bug # in the comment in the file?<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Dec 17, 2021, 09:42 Mike Gilbert &lt;<a href="mailto:[email protected]">[email protected]</a>&gt; wrote:<br>
    </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is intended to prevent packages from automatically switching to<br>
    64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled<br>
    manner will lead to inconsistent library ABIs that fail at runtime.<br>

    At a later time, we will introduce new profiles to enable 64-bit time_t<br> distro-wide.<br>

    <a href="https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration" rel="noreferrer noreferrer" target="_blank">https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration</a><br>

    Bug: <a href="https://bugs.gentoo.org/828001" rel="noreferrer noreferrer" target="_blank">https://bugs.gentoo.org/828001</a><br>
    Signed-off-by: Mike Gilbert &lt;<a href="mailto:[email protected]" target="_blank" rel="noreferrer">[email protected]</a>&gt;<br>
    ---<br>
     profiles/default/linux/make.defaults | 4 ++++<br>
     1 file changed, 4 insertions(+)<br>

    diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults<br>
    index 6ae7cf297cf..53ace7e229c 100644<br>
    --- a/profiles/default/linux/make.defaults<br>
    +++ b/profiles/default/linux/make.defaults<br>
    @@ -53,3 +53,7 @@ VIDEO_CARDS=&quot;dummy fbdev v4l&quot;<br>
     # Note that adding LDFLAGS=&quot;-Wl,-O1 ${LDFLAGS}&quot; breaks dev-util/boost-build<br>
     # because of whitespace.<br>
     LDFLAGS=&quot;-Wl,-O1 -Wl,--as-needed&quot;<br>
    +<br>
    +# Mike Gilbert &lt;<a href="mailto:[email protected]" target="_blank" rel="noreferrer">[email protected]</a>&gt; (2021-12-17)<br>
    +# Prevent automagic use of 64-bit time_t.<br> +gl_cv_type_time_t_bits_macro=&quot;no&quot;<br>
    -- <br>
    2.34.1<br>


    </blockquote></div></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mike Gilbert@21:1/5 to [email protected] on Sat Dec 18 17:00:02 2021
    On Sat, Dec 18, 2021 at 10:35 AM James Le Cuirot <[email protected]> wrote:
    What will we do about other build systems? I worry they won't have a consistent approach for all projects.

    We will have to deal with them as we discover them. I don't see a
    magic solution for everything.

    I suppose we could add a new profile var (eg. TIME_BITS) that ebuild maintainers could reference to control this for non-autoconf/gnulib
    build systems.

    Also, if some common build system like meson adds automagic support,
    we could override that in meson.eclass.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From James Le Cuirot@21:1/5 to Mike Gilbert on Sat Dec 18 16:40:01 2021
    On Fri, 2021-12-17 at 09:41 -0500, Mike Gilbert wrote:
    This is intended to prevent packages from automatically switching to
    64-bit time_t on 32-bit ABIs. Making this switch in an uncontrolled
    manner will lead to inconsistent library ABIs that fail at runtime.

    At a later time, we will introduce new profiles to enable 64-bit time_t distro-wide.

    https://wiki.gentoo.org/wiki/Project:Toolchain/time64_migration

    Bug: https://bugs.gentoo.org/828001
    Signed-off-by: Mike Gilbert <[email protected]>
    ---
    profiles/default/linux/make.defaults | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/profiles/default/linux/make.defaults b/profiles/default/linux/make.defaults
    index 6ae7cf297cf..53ace7e229c 100644
    --- a/profiles/default/linux/make.defaults
    +++ b/profiles/default/linux/make.defaults
    @@ -53,3 +53,7 @@ VIDEO_CARDS="dummy fbdev v4l"
    # Note that adding LDFLAGS="-Wl,-O1 ${LDFLAGS}" breaks dev-util/boost-build
    # because of whitespace.
    LDFLAGS="-Wl,-O1 -Wl,--as-needed"
    +
    +# Mike Gilbert <[email protected]> (2021-12-17)
    +# Prevent automagic use of 64-bit time_t.
    +gl_cv_type_time_t_bits_macro="no"

    What will we do about other build systems? I worry they won't have a
    consistent approach for all projects.

    -----BEGIN PGP SIGNATURE-----

    iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmG9/8ERHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTeNoBAAqJrxHZ4L5gQ8d1rHiyMgBMoXbYWcdGbu bubyRny17R00MEJRVQeguI87Ms2EmCbWhrJTo0WpyeLuzDG+qAy5fwb3yR9vIIHe x1qEJfsLuH3WOuZNYmRIlNe6Sz58QymTDkquZSdpirZ9Tt4kRpvc3lXkOu3iIUby v5YVnf02AHKkv4V6Al8FQbB6RRqKu8XmOVsFKZTiuwa4ly013j6c4HzUXESHQrxH yHJe0oEhND0J1bmgOZMEjfI3ejEAkFyUNQ0C9/sesMBGOyguUv6a/ntw/fmu3BAO GQqr5wmbHvxiudfL7JytGHLqkI/i0MVWjJiuW/S0wWQ+0ki1jSBQcqNbwd9ZgvCc uGTzNWy3rI7ifHaO7gSnqvf1PcHP66Q3uYiO2/ieypvugQUXrAy6yiBcVeJbhHuk vQ/4lju/852oYvMmNm5fRBGeA1IqMvjRXl0ydLChZ9TSo+Cw2/t5cuGPgYMzvnhG 2s1stCxGiSjbHK4bl3x8H6rJccJCJAEhs3u/AXcKwIpBxxYUtQjNPvtx4fQorQcO X6ky8k7nkUS+h4rYfYJWTNUBlSSoS/cgZt/VvkXF6O6zzyXDDWqVRxeKZ44o6jxM Z9uIB4Dn/SJNXlkNJHHYqn3bt00vk+AcFVS+gelLlIHDRmJjM6AXxaz8unQ+X1ur
    Lly8J7GeSj4=
    =DhM5
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)