1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] Commit tags for resolutions OBSOLETE, PKGREMOVED

    From Lucio Sauer@21:1/5 to All on Mon Jun 17 12:00:02 2024
    Hi,

    I wrote patches for infra's git hooks[1] and pkgdev[2] that add two new
    commit tags to support the automatic closure of bugs with resolutions
    other than FIXED.
    However, I am not entirely convinced that the meaning of the chosen tags
    is self-evident enough for a third party to understand them at a glance.

    Feel free to comment on my propsals or suggest alternatives! You'll
    hopefully be using them frequently :)

    Orphans: https://bugs.gentoo.org/####

    This commit removes the (last remaining) package that has been affected by
    this bug. The bug will be closed with resolution PKGREMOVED.
    Unknowing users might think that the bug's assignee will be removed
    instead.

    Sam also suggested "Removed:" and "Last-rited:"[3].
    In my opinion, they don't convey that it's the underlying package that
    is being remvoed and not the bug itself.

    Antiquates: https://bugs.gentoo.org/####

    This commit removes ebuilds and newer versions of the program are no
    longer affected or it drops support for the problematic feature. This
    bug will be closed with resolution OBSOLETE.
    The tag may more commonly be understood as 'makes old-fashioned', which
    doesn't really make sense in this context. Pkgdev would only provide the
    long option `--antiq`, which would be a bit shorter than `--obsoletes`.

    [1]: https://git.sr.ht/~antecrescent/gentoo-githooks/commit/248ba38802abd9e115a2f602a0cd82b32d16c914
    [2]: https://github.com/antecrescent/pkgdev/commit/8e1d84971f0f6c3f638381477de9d99f0c1b2ef3
    [3]: https://marc.info/?l=gentoo-dev&m=170737555732280&w=2

    Best
    --
    Lucio Sauer

    -----BEGIN PGP SIGNATURE-----

    iQGTBAABCgB9FiEElFlueg0TS/aEyc5qVWii3aYMopcFAmZwBuJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk0 NTk2RTdBMEQxMzRCRjY4NEM5Q0U2QTU1NjhBMkREQTYwQ0EyOTcACgkQVWii3aYM opcdDgf9Gjt7Y3brpHt3itFccnGm5qFJOcTX3p3Wq08EhASa/77uhv603XfELTWM 5HWSvBtjB6qqxvDqAZ3x3kP5AMrEWAMrosgXUXsHUgppGyMWrXREl0iz4vfwatqw +/SH6kjXfvv5QNGjYBUDSJ4oghBfamN8Mcv8ghsgsYI58glzPxFB2pH1ZUVaMP4R g2uA1O/MVJEFs9Ssm1lhzBj92LBwegAdbdDo1CoUNsFMbDU1cJsHryzqqXmRmBbG 4cA1IaPNH9eLsOEdfc88w96LWzM6iUvM+OwkIKJtcPLaLjZfyvzMQK5AoTUixIH0 kF80ZHysgV0TzyykPE3vBSlyy20BVQ==
    =Ktq8
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?=@21:1/5 to Lucio Sauer on Mon Jun 17 14:00:02 2024
    On Mon, 2024-06-17 at 09:50 +0000, Lucio Sauer wrote:
    Hi,

    I wrote patches for infra's git hooks[1] and pkgdev[2] that add two new commit tags to support the automatic closure of bugs with resolutions
    other than FIXED.
    However, I am not entirely convinced that the meaning of the chosen tags
    is self-evident enough for a third party to understand them at a glance.

    Feel free to comment on my propsals or suggest alternatives! You'll
    hopefully be using them frequently :)


    I think it would be less confusing to have an optional arg to Closes,
    something like:

    Closes[PKGREMOVED]: ...

    --
    Best regards,
    Michał Górny


    -----BEGIN PGP SIGNATURE-----

    iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmZwIxISHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOBwEIAJFvCWaX/bc7ons3uvWJL6d01MtwiUfx 6he2nXcciaw+arPP1JcUcw2w80G1agr8QXNGk75q7RBrNKvpmcaoTK7WOHnBGcHC +lWUGWWDBaMGlt3uCBAxbOEMvWUhoSaso3wmneEjZ/CR7q3TfKcSQ2RsG6P2ICkW /Lw9cPr20KVzieAwtZ72aw+tZlgfNUnFrdv8rX75EHRY7EKBAQXv/ARhJnw1uwYF 4b5VCwP35Wc4B7ziuKcDMD25qPWNI7/uxFtXjEGEe5Wg15HqOBeYmgqMbgQHtjgZ Z/MTF01FRYmApPcF+wW1Xx1jPQILC9RIvE/qDqxAg9w5zwo/iUB65FA=
    =JjS1
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Mon Jun 17 17:20:01 2024
    On Mon, 17 Jun 2024, Michał Górny wrote:

    I think it would be less confusing to have an optional arg to Closes, something like:

    Closes[PKGREMOVED]: ...

    Yay, bikeshedding. :) But seriously, since we already have:

    Signed-off-by: ... (DCO-1.1)

    I'd suggest using similar syntax, i.e.

    Closes: https://bugs.gentoo.org/123456 (pkgremoved)

    The string in parentheses would be matched in a case-insensitive way.

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmZwUgcPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4u0wMH/1UUfxWqJTBtB84axaJPpyLU8jBVIaE8rtv3 c/yPCBxM5fkvEfUBW7XFaoYjhPsHVzP3IXjz8RCsHJ7ojlXv08tlC+jnllmSoJXm gUS0IeJ8Uyt3gD4ydfjdTuEULn3ovyoa+wucxOF6LxBrP8Z/4CgZexADii2knjNn rhNicmmuRA83YdzDpD7+HM+1n91n8+brgqSELWGykOOIUNQgLhk/17xqPe904rIQ 9Q++PFKXh3PgvtgkOiryLtvjDXhpmu1dENXvQgSRrSvJMVrfkp8KlQo8jWlA3tUZ cyrl/QjynLxLTc/CGB0gWmBiQRWgeNBKxBFiyK656Utkuqz+GNg=iQDl
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ionen Wolkens@21:1/5 to Ulrich Mueller on Mon Jun 17 23:00:01 2024
    On Mon, Jun 17, 2024 at 05:11:03PM +0200, Ulrich Mueller wrote:
    On Mon, 17 Jun 2024, Michał Górny wrote:

    I think it would be less confusing to have an optional arg to Closes, something like:

    Closes[PKGREMOVED]: ...

    Yay, bikeshedding. :) But seriously, since we already have:

    Signed-off-by: ... (DCO-1.1)

    I'd suggest using similar syntax, i.e.

    Closes: https://bugs.gentoo.org/123456 (pkgremoved)

    The string in parentheses would be matched in a case-insensitive way.

    Think I like this version, and let's keep it with no caps please (but
    no harm in being case-insensitive & just style indeed).
    --
    ionen

    -----BEGIN PGP SIGNATURE-----

    iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmZwoyMACgkQskQGsLCs QzQeAAf9HGMdSecOgb48ubd2e8CloY2ow2XQtGp7CBpL4nD3up30jnrjkiVZ6W8z Bfak1EPuXOFan3dK8sIYqNQzyM0R9Z4VdsB/dehoPdIl+yCkd8Rr3iNs08ZyvDKC 1mF2eollwI54Zp9dg9NkUock0YrRRrlZVtc31ZTLSgP5P4P9Mxhh9QnEzvTVXcrr rt8xArZc81QOlyGwuGTQjc32c1NDkebnuCUX2YTxLj/QSDQJ2TlWA/+XN8mh0uKr NrAeHIYsYWbLSOTN9CPAWBYuyw1vDsn5pUPcFC1VTXpeagtlW1SM63wOoXMFieOO MJoRzSodpxQN1+y0DHlqsHvGmL56EQ==
    =vNtK
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Lucio Sauer@21:1/5 to Ionen Wolkens on Tue Jun 18 02:50:02 2024
    On Mon, Jun 17, 2024 at 04:57:07PM -0400, Ionen Wolkens wrote:
    On Mon, Jun 17, 2024 at 05:11:03PM +0200, Ulrich Mueller wrote:
    On Mon, 17 Jun 2024, Michał Górny wrote:

    I think it would be less confusing to have an optional arg to Closes,
    An optional arg for Closes: is indeed less confusing :^) Thank you!

    something like:

    Closes[PKGREMOVED]: ...

    Yay, bikeshedding. :) But seriously, since we already have:

    Signed-off-by: ... (DCO-1.1)

    I'd suggest using similar syntax, i.e.

    Closes: https://bugs.gentoo.org/123456 (pkgremoved)

    The string in parentheses would be matched in a case-insensitive way.

    Think I like this version, and let's keep it with no caps please (but
    no harm in being case-insensitive & just style indeed).
    I ended up going with your combined approaches. Thanks to you too!

    --
    Lucio Sauer

    -----BEGIN PGP SIGNATURE-----

    iQGTBAABCgB9FiEElFlueg0TS/aEyc5qVWii3aYMopcFAmZw2TFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk0 NTk2RTdBMEQxMzRCRjY4NEM5Q0U2QTU1NjhBMkREQTYwQ0EyOTcACgkQVWii3aYM opcYmwf/ZMxLI9RP8rg0tWLFuGCxgkJJROCpOIcSh6r+8qxLY+ZyV+/y+Fh7InCb o+D3Ocas+sKLjrZ5nvf2TdrbOSuC3hKNCsb4ZfZrex+ZdMKgQXNqODWNWLYyigCB sMx836qmo7jVabTxGa/QusgMKRsFuQeO39Uwm03zSwX/BTRAIMANbYGlME3YCq0k 5Jf/pdcprJvuqdL5KvjOl1tzMOw+bPARQ8wWuT9eYbSv2ZHbL8F53RvYurhXlu9k P0tpkkrQyohUSz5oOK28MYlb9HPaG5NK8upokSb8DOLoW13CFhx2JTXvdLXn+IDW 7QX1WJ4Nisf34ffmQiXA/nNVoHRJIw==
    =P2A7
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)