1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH 1/2] common-lisp-3.eclass: Support EAPI 8

    From =?UTF-8?q?Ulrich=20M=C3=BCller?=@21:1/5 to All on Sat Jun 8 21:50:01 2024
    Minor stylistic changes.

    Signed-off-by: Ulrich Müller <[email protected]>
    ---
    eclass/common-lisp-3.eclass | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/eclass/common-lisp-3.eclass b/eclass/common-lisp-3.eclass
    index 26d31268a598..12c7221e41ce 100644
    --- a/eclass/common-lisp-3.eclass
    +++ b/eclass/common-lisp-3.eclass
    @@ -1,17 +1,17 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: common-lisp-3.eclass
    # @MAINTAINER:
    # Common Lisp project <[email protected]>
    -# @SUPPORTED_EAPIS: 6 7
    +# @SUPPORTED_EAPIS: 6 7 8
    # @BLURB: functions to support the installation of Common Lisp libraries
    # @DESCRIPTION:
    # Since Common Lisp libraries share similar structure, this eclass aims
    # to provide a simple way to write ebuilds with these characteristics.

    case ${EAPI} in
    - 6|7) ;;
    + 6|7|8) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    @@ -121,7 +121,7 @@ common-lisp-install-sources() {

    local fp
  • From Arthur Zamarin@21:1/5 to All on Sat Jun 8 21:50:02 2024
    To: [email protected] (=?UTF-8?Q?Ulrich_M=C3=BCller?=)
    Copy: [email protected]

    This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rCsbcAllZazfBTB0jdXXh8QE
    Content-Type: text/plain; charset=UTF-8
    Content-Transfer-Encoding: quoted-printable

    On 08/06/2024 22.40, Ulrich Müller wrote:
    Minor stylistic changes.

    Signed-off-by: Ulrich Müller <[email protected]>
    ---
    eclass/common-lisp-3.eclass | 12 ++++++------
    1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/eclass/common-lisp-3.eclass b/eclass/common-lisp-3.eclass
    index 26d31268a598..12c7221e41ce 100644
    --- a/eclass/common-lisp-3.eclass
    +++ b/eclass/common-lisp-3.eclass
    @@ -1,17 +1,17 @@
    -# Copyright 1999-2023 Gentoo Authors
    +# Copyright 1999-2024 Gentoo Authors
    # Distributed under the terms of the GNU General Public License v2

    # @ECLASS: common-lisp-3.eclass
    # @MAINTAINER:
    # Common Lisp project <[email protected]>
    -# @SUPPORTED_EAPIS: 6 7
    +# @SUPPORTED_EAPIS: 6 7 8
    # @BLURB: functions to support the installation of Common Lisp libraries
    # @DESCRIPTION:
    # Since Common Lisp libraries share similar structure, this eclass aims
    # to provide a simple way to write ebuilds with these characteristics.

    case ${EAPI} in
    - 6|7) ;;
    + 6|7|8) ;;
    *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
    esac

    @@ -121,7 +121,7 @@ common-lisp-install-sources() {

    local fpredicate=$(common-lisp-get-fpredicate "${ftype}")

    - for path in "${@}" ; do
    + for path ; do
    if [[ -f ${path} ]] ; then
    common-lisp-install-one-source ${fpredicate} "${path}" "$(dirname "${path}")"
    elif [[ -d ${path} ]] ; then
    @@ -148,7 +148,7 @@ common-lisp-install-sources() {
    # Installs ${1} asdf file in CLSOURCEROOT/CLPACKAGE and symlinks it in
    # CLSYSTEMROOT.
    common-lisp-install-one-asdf() {
    - [[ $# != 1 ]] && die "${FUNCNAME[0]} must receive exactly one argument" + [[ $# = 1 ]] || die "${FUNCNAME[0]} must receive exactly one argument"

    # the suffix «.asd» is optional
    local source=${1%.asd}.asd
    @@ -168,7 +168,7 @@ common-lisp-install-asdf() {

    [[ $# = 0 ]] && set - ${CLSYSTEMS}
    [[ $# = 0 ]] && set - $(find . -type f -name \*.asd)
    - for sys in "${@}" ; do
    + for sys ; do
    common-lisp-install-one-asdf ${sys}
    done
    }

    LGTM, thanks!

    --
    Arthur Zamarin
    [email protected]
    Gentoo Linux developer (Python, pkgcore stack, QA, Arch Teams, GURU)


    --------------rCsbcAllZazfBTB0jdXXh8QE--

    -----BEGIN PGP SIGNATURE-----

    iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmZktH4ACgkQAqCvUD0S BQQ+WQgAwJ2wXGpNYaD9/IQ+hRFMonAfCgPF9J7pkwOGyD23pTUd1HSOCvG5Bwtu rWLGjQMA+awc8x0wLZOthYB6UXYHpeYMFw4NkkB88t4CPiuOrKF7mbjjxtbEaqGf UEApCc2gjB0vQiAThrGD6+GaedNl0ofZS/WFCGealb/tf2DtUlXcyhL3dhiWCCbl hawv5MfpwDc0s9zm0mL5dYcyZMSiUNAn3wIPXyyOUU+GPQFGJVBc4uY1vfsKW/8D N8Cm4HKvTCh5lVzQh9Ib+BdulvAZlCFDVsA0svdmMWGaJX8b2ng1+lfl3w6R09xc HcYPgxdA3bmF7DOPSk7hbWOsrqbxPA==
    =zxKm
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ulrich Mueller@21:1/5 to All on Sat Jun 8 21:50:02 2024
    On Sat, 08 Jun 2024, Ulrich Müller wrote:

    - [[ $# != 1 ]] && die "${FUNCNAME[0]} must receive exactly one argument" + [[ $# = 1 ]] || die "${FUNCNAME[0]} must receive exactly one argument"

    Ten seconds after hitting send I notice that these should use -eq,
    not =. Also elsewhere in the eclass.

    I've updated it locally.

    Ulrich

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQFDBAEBCAAtFiEEtDnZ1O9xIP68rzDbUYgzUIhBXi4FAmZktPEPHHVsbUBnZW50 b28ub3JnAAoJEFGIM1CIQV4uRRAIAMWz96omThdAv1WbXrSmvVUPXtwB22p0X5rx 67J/usMC3FGcYK6ciG8hQZlrECS8DbzzHgm5meP2ILGH3egjHm3C44N5YgbBvC6C NNno1zjMwEIB5JA+3UriIe+/Hc9MZ/MqWl6QA51wsl4WFAGTimHAskoC6n4/GMC9 JWbH2Qv96ecpfupj4JSjd/MCEM8byF1nIPFJAE54dpAVov911Uub/FNylNCYDxQr ZsjCov9+G/EhBlJ3WB0sLgOLs2LfofFCvjrkfi5vHAL2R/FBsIzs4dgFRhGKHiQO KOYEVC1Jt2rnNK4A8l6vuaEnp/jEp7WyPDLHhf0NBnW+8HDYdDg=iNkt
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)