On Thu, 2024-02-29 at 15:21 +0100, Florian Schmaus wrote:
On 29/02/2024 15.08, Michael Orlitzky wrote:
On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote:
+if [[ -z ${TL_PV} ]] \
+ && [[ ${EAPI} -ge 8 ]] \
I am skeptical of this construct, as in the past we had non-numeric EAPIs. So I may have to go with EAPI == 8 for now. Input appreciated.
The eclass only supports EAPIs {7,8,...} so it should suffice to
blacklist EAPI=7.
Fair point, but that would mean to remember to adjust this line once the eclass gets support for EAPI 9.
It appears that bash does the right thing:
$ if [[ "eapi-future" -gt 8 ]]; then echo "is greater than 8"; else echo
"is NOT greater than 8"; fi
is NOT greater than 8
even considering
$ if [[ "9-eapi-future" -gt 8 ]]; then echo "is greater than 8"; else
echo "is NOT greater than 8"; fi
is greater than 8
which would be fine.
Although I prefer the current approach, it is not a hill to die on for me.
It is invalid to treat EAPI as an integer.
The standard practice is to explicitly list old EAPIs, so that no
changes need to preserve the new behavior for new EAPIs.
--
Best regards,
Michał Górny
-----BEGIN PGP SIGNATURE-----
iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmXglpoSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOk1IH/10zhZx3EU+c7iMpumLeh2q1kmF0ycf9 GvLEzGE5e1UfQ9qycfsU4leaW9ZhE1R3Mz6V5N8zz/OOufyd5ouyWs7RIjXlMFOj R0TYrQO9FsD5u6BqhbmeK/lEXxZUzomx7l+99KGZLMm75kQWLZhZoO8jP/G/AGFp xK74qCRCs/N3E4NBSS9rPpPBNoCxI45ffxErzU/JTsK/UeDEIs5MMN37PK5LuWNx /P3EkNIsVqlJ4iGYT4y1uRpwhZUz4FTvvuuVPLX/BWY1krPP/HSYWrJMou3iowpY FspFQC2smj5y1irUd6qdeJop15THeON9qB5I99IhPEZ6izLujoAGK2k=
=LnCE
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)