1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • Re: [gentoo-dev] [PATCH] meson.eclass: allow disabling verbose compilat

    From Adrian Schollmeyer@21:1/5 to All on Mon Jul 17 17:00:01 2023
    Hi,

    Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner:
    This works similar to cmake.eclass's ${CMAKE_VERBOSE}.

    Why not use MESON_VERBOSE as well? Avoids double negation in the code
    (not unset -> verbose vs. MESON_VERBOSE == true -> verbose) and keeps
    the variable naming similar to cmake.eclass.

    nex

    -----BEGIN PGP SIGNATURE-----

    iHUEABYIAB0WIQQcg0lBH7AUcc2KLs8BUfPlCnnJ+QUCZLVWmAAKCRABUfPlCnnJ +arpAQCaW1h7GQqIGV0/dYT+S+/rget2aG44KMXKpVjj9VVlvgD/TZxnnkw9NsVd aTxu6WyuHDIsqWGRHHH6WN0L8tg38gI=
    =77US
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Matt Turner@21:1/5 to [email protected] on Mon Jul 17 17:30:02 2023
    On Mon, Jul 17, 2023 at 10:56 AM Adrian Schollmeyer <[email protected]> wrote:
    Am Montag, dem 17.07.2023 um 10:51 -0400 schrieb Matt Turner:
    This works similar to cmake.eclass's ${CMAKE_VERBOSE}.

    Why not use MESON_VERBOSE as well? Avoids double negation in the code
    (not unset -> verbose vs. MESON_VERBOSE == true -> verbose) and keeps
    the variable naming similar to cmake.eclass.

    nex

    I personally agree -- I was just sending the patch as-is from GitHub.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)