1. Forum
  2. Usenet
  3. LINUX.GENTOO.DEV

  • [gentoo-dev] [PATCH] go-module.eclass: undeprecate EGO_SUM

    From Florian Schmaus@21:1/5 to All on Mon Jun 13 09:50:01 2022
    Following the gentoo-dev@ mailing list discussion [1], this
    un-deprecates EGO_SUM.

    1: https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa

    Signed-off-by: Florian Schmaus <[email protected]>
    ---
    eclass/go-module.eclass | 30 +++++++++++-------------------
    1 file changed, 11 insertions(+), 19 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index a5dafb45cab8..2e0b7dc1726d 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -25,7 +25,9 @@
    #
    # If the software has a directory named vendor in its
    # top level directory, the only thing you need to do is inherit the
    -# eclass. If it doesn't, you need to also create a dependency tarball and
    +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the ebuild and +# call go-module_set_globals as discussed below or 2) you need to create a
    +# dependency tarball and
    # host it somewhere, for example in your dev space.
    #
    # Here is an example of how to create a dependency tarball.
    @@ -52,9 +54,14 @@
    #
    # inherit go-module
    #
    +# EGO_SUM=(
    +# "github.com/aybabtme/rgbterm v0.0.0-20170906152045-cc83f3b3ce59/go.mod"
    +# "github.com/aybabtme/rgbterm v0.0.0-20170906152045-cc83f3b3
  • From Andrew Ammerlaan@21:1/5 to Florian Schmaus on Mon Jun 13 11:50:01 2022
    On 13/06/2022 09:44, Florian Schmaus wrote:
    Following the gentoo-dev@ mailing list discussion [1], this
    un-deprecates EGO_SUM.

    1: https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa

    Signed-off-by: Florian Schmaus <[email protected]>
    ---
    eclass/go-module.eclass | 30 +++++++++++-------------------
    1 file changed, 11 insertions(+), 19 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index a5dafb45cab8..2e0b7dc1726d 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -25,7 +25,9 @@
    #
    # If the software has a directory named vendor in its
    # top level directory, the only thing you need to do is inherit the
    -# eclass. If it doesn't, you need to also create a dependency tarball and
    +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the ebuild and
    +# call go-module_set_globals as discussed below or 2) you need to create a +# dependency tarball and
    # host it somewhere, for example in your dev space.
    #
    # Here is an example of how to create a dependency tarball.

    I agree that EGO_SUM shouldn't have been completely deprecated following
    the previous discussion. It is not always possible or practical to host
    a dependency tarball, especially for people who aren't Gentoo
    developers. However, from what I remember from the previous discussion
    there actually were some good arguments against using EGO_SUM, mainly
    relating to the size of the ebuilds and manifests. So perhaps we can
    find some middle ground here and keep EGO_SUM for e.g. third-party repositories, while recommending dependency tarballs for use in
    ::gentoo. Could we add something among those lines to the text here?

    Best regards,
    Andrew

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Florian Schmaus@21:1/5 to Andrew Ammerlaan on Mon Jun 13 12:30:01 2022
    On 13/06/2022 11.49, Andrew Ammerlaan wrote:
    On 13/06/2022 09:44, Florian Schmaus wrote:
    Following the gentoo-dev@ mailing list discussion [1], this
    un-deprecates EGO_SUM.

    1:
    https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa


    Signed-off-by: Florian Schmaus <[email protected]>
    ---
      eclass/go-module.eclass | 30 +++++++++++-------------------
      1 file changed, 11 insertions(+), 19 deletions(-)

    diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
    index a5dafb45cab8..2e0b7dc1726d 100644
    --- a/eclass/go-module.eclass
    +++ b/eclass/go-module.eclass
    @@ -25,7 +25,9 @@
      #
      # If the software has a directory named vendor in its
      # top level directory, the only thing you need to do is inherit the
    -# eclass. If it doesn't, you need to also create a dependency tarball
    and
    +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the
    ebuild and
    +# call go-module_set_globals as discussed below or 2) you need to
    create a
    +# dependency tarball and
      # host it somewhere, for example in your dev space.
      #
      # Here is an example of how to create a dependency tarball.

    I agree that EGO_SUM shouldn't have been completely deprecated following
    the previous discussion. It is not always possible or practical to host
    a dependency tarball, especially for people who aren't Gentoo
    developers. However, from what I remember from the previous discussion
    there actually were some good arguments against using EGO_SUM, mainly relating to the size of the ebuilds and manifests.

    What's wrong with an ebuild using an EGO_SUM with a few entries in ::gentoo?

    - Florian

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From William Hubbs@21:1/5 to Florian Schmaus on Fri Jun 17 18:00:01 2022
    On Mon, Jun 13, 2022 at 09:44:11AM +0200, Florian Schmaus wrote:
    Following the gentoo-dev@ mailing list discussion [1], this
    un-deprecates EGO_SUM.

    Sorry I haven't been on this list in a a while (I've been pretty busy
    with work).

    Did you talk to the pms team about https://bugs.gentoo.org/833567?

    I knew about Robin's proposal, but there isn't a working version of that
    yet, and I've seen packages break portage using EGO_SUM.

    William

    -----BEGIN PGP SIGNATURE-----

    iF0EABECAB0WIQTVeuxEZo4uUHOkQAluVBb0MMRlOAUCYqyjjQAKCRBuVBb0MMRl OKqiAJ9dEOHXWgalFFNMjjZUJVMQi3oFMQCfQ7SVvzzr8ffe0IzpLANkvLKMAfI=
    =57UO
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)