On 22/05/2022 20:20, Arthur Zamarin wrote:

I have just released a new version [0] for pkgdev. Outside of multiple
new features meant for easier developer workflows (like prepare to send
a last-rite email), there is an important changes in the release which
affect current users of pkgdev.

** Important Notice **

pkgdev now doesn't add the signoff by itself, unless configured. You can easily configure it by following the instructions [1], which in short corresponds to adding to `~/.config/pkgdev/pkgdev.conf` the lines:

[gentoo]
push.signoff = true

Shouldn't this be commit.signoff instead?

pkgdev push: failed loading config: unknown arguments: --signoff=true

(The same mistake is in the documentation at [1])

In case you forgot to perform this, the usual workflow of working with
pkgdev (meaning committing and then pushing) would seem to work, but
because of missing Signed-off-by line, the push would fail.

I also recommend to read the full configuration docs at [1], as now it
is possible to configure the "new default" args for pkgdev.

Finally I want to call for features requests for the pkgcheck and
pkgdev. Myself and other developers are trying to actively maintain the stack, and add new features, QA checks, etc. I want to make those tools
nice for Gentoo developers, so I need your requests to improve it.

[0] https://github.com/pkgcore/pkgdev/releases/tag/v0.2.1
[1] https://pkgcore.github.io/pkgdev/man/pkgdev.html#config-file-support

Best regards,
Andrew

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

To: [email protected] (Andrew Ammerlaan)

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------06Q01VCVpnEnX4IkicCP1KDF
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 23/05/2022 20.57, Andrew Ammerlaan wrote:

On 22/05/2022 20:20, Arthur Zamarin wrote:

I have just released a new version [0] for pkgdev. Outside of multiple
new features meant for easier developer workflows (like prepare to send
a last-rite email), there is an important changes in the release which
affect current users of pkgdev.

** Important Notice **

pkgdev now doesn't add the signoff by itself, unless configured. You can
easily configure it by following the instructions [1], which in short
corresponds to adding to `~/.config/pkgdev/pkgdev.conf` the lines:

   [gentoo]
   push.signoff = true

Shouldn't this be commit.signoff instead?

pkgdev push: failed loading config: unknown arguments: --signoff=true

(The same mistake is in the documentation at [1])

...

Best regards,
Andrew

Thank you Andrew, You are absolutely right - this was my mistake in
lines. It should be:

[gentoo]
commit.signoff = true

Actually I also got reports of it failing to identify that this is the
gentoo repo, so for now, so we are absolutely sure it works, please use:

[DEFAULT]
commit.signoff = true

Once again, I'm sorry for this mistake, and I will fix the docs ASAP.

--
Arthur Zamarin
[email protected]
Gentoo Linux developer (Python, Arch Teams, pkgcore stack, GURU)

--------------06Q01VCVpnEnX4IkicCP1KDF--

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmKL2qAACgkQAqCvUD0S BQTKOAgAhR1CFDAHaRNihTGgq9Qu5E4Doh2ZiRDgkJP61k0tzUF+em5beMQfCb8X yxzW5MGMTCKEt/2Oi3d+eWK38h5PoGMuI+1kmCGWHwdeGZ4XWWrZYRs/gW+ddO2c h6wsM5cOsRakosz59qSLPTSdCJ75WVxDV38turZrqwN51w8Jxv50ENCyEYsOA9AI EcNoManKvOeFxggnvGSxKqT2HXKyy2/aksdt55OzATdkeBprZBoDBrYmSlXFaYBD sq7Y2RBssqXWHOKTtmEWz36s2KtxYrBqSGFmbDZrwifFcUU20KdFhPriBYi9286H gUpMWdtWuOU8ZPijvYSVptD7w23lew==
=HwFY
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)