Dear mentors,

I am looking for a sponsor for my package "archlinux-keyring":

I can sponsor this.

A few comments on the package:

- I imagine the makefile patch will be upstreamed?
- no need to repeat the GPL3 license snippet in debian/copyright, have
it as a single line in the Copyright stanzas: "License: GPL-3+", and
then one block at the bottom of the file with "License: GPL-3+" and the
full body to follow.
- the keyring files are installed in /usr/share/pacman/keyrings/ but
other keyrings (like ubuntu-keyring) install to /usr/share/keyrings, so
I think this should do the same for consistency
- in debian/control the VCS fields list https://gitlab.archlinux.org/archlinux/archlinux-keyring as the
repository, but there's no sign of the packaging code there. You should
have it on a debian/sid (or similar) branch.

--
Kind regards,
Luca Boccassi

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCSqx93EIPGOymuRKGv37813JB4FAmLhI5MACgkQKGv37813 JB7vlQ/9Fp9mFk1RSE0j1Xknnjhi5TnwFi1hFjzSt77c1mm37sQXx5unygyoKme5 GNiV175GNFNh4zEhOoI7nt/D3iGGC4fScWTPzzlxwXKltE4QFi0XREVQwhnKkNyZ f8cyUgSRK26kpR3o8L3Z1U9/M0dOpDllgi93ynDgwHm1Fq+ANxsFykfn5x6sSFAr G5AvvKdOYwfdiKmZGv0q9vKwMiqrv7A7JA1c4RB/SrVGaOC6IJ17prsvI5cg7gKR L/6T72tp4R9bQZBOj+7WCeYEtRaV1LTggRAbE1zsTw5lg8i1zCMOxO5qpyLZc2xR qoVAEhuu6xDJgSHPRBhzHsArO7urJdBpDLlIaZgdFOfCZiD0xIDB6SuonjuF775S dt132lrp+vpk/YWX1ZpgZskdrF2dVp7roeQw67MATOD2PwddqGOeMN7tdlHj8kbi Xh1SCnFhgMymwtJsNDYKjMYpN8aZ/1sjxM2OXxtcRs2j09rsKknlrz7S2zhmhip5 ROghODVLSe7+sD6dIx1oYztUA8MPQY945cEEpuLeB6D2Ljz+g+P/AL5wwUrOm76x zlyQpgTt7Naah8jOS9EEzWUWUvYXOk0kbisP0ojclFmMJxScrCWd5cKxSSrfey6L bv8eI4kkliQGYgGxdn5YG9q+7u1JYdLTddynqI11/L8gmuiyN78=
=NzM7
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Luca,

On Wed, Jul 27, 2022 at 12:38:07PM +0100, Luca Boccassi wrote:

Dear mentors,

I am looking for a sponsor for my package "archlinux-keyring":

I can sponsor this.

A few comments on the package:

- I imagine the makefile patch will be upstreamed?
- no need to repeat the GPL3 license snippet in debian/copyright, have
it as a single line in the Copyright stanzas: "License: GPL-3+", and
then one block at the bottom of the file with "License: GPL-3+" and the
full body to follow.
- the keyring files are installed in /usr/share/pacman/keyrings/ but
other keyrings (like ubuntu-keyring) install to /usr/share/keyrings, so
I think this should do the same for consistency
- in debian/control the VCS fields list https://gitlab.archlinux.org/archlinux/archlinux-keyring as the
repository, but there's no sign of the packaging code there. You should
have it on a debian/sid (or similar) branch.

Thanks for the review! I've addressed the feedback, and also bumped to
the newly released 20220727

https://mentors.debian.net/package/archlinux-keyring/ https://salsa.debian.org/michel/archlinux-keyring/-/tree/main

Note: after deduplicating the GPL-3+ snippets, this now generates an
additional lintian warning because it thinks the license snippet is
missing.

Best regards,

--
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRdzi5+nDsc/9M1wdeLIp0vfMwE8gUCYuGwgQAKCRCLIp0vfMwE 8j7IAQDG+YguSNGu2OtTUFcVR4VMB0GHIN78T78K3d2o1dgd3AEA/puXSSHuFXEB CZbe/P5Dlz1qdL4WSfwOZlNwvakgIgw=
=FXs+
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Wed, 2022-07-27 at 16:39 -0500, Michel Alexandre Salim wrote:

Hi Luca,

Note: after deduplicating the GPL-3+ snippets, this now generates an additional lintian warning because it thinks the license snippet is
missing.

This is fixed now, thanks Luca for pointing out that all instances of a
shared license should not contain the text, and there should be a
separate section with both the single license line and the license
blurb.


Thanks,

--
Michel Alexandre Salim
identities:
https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

-----BEGIN PGP SIGNATURE-----

iI0EABYKADUWIQRdzi5+nDsc/9M1wdeLIp0vfMwE8gUCYuG4lBccbWljaGVsQG1p Y2hlbC1zbG0ubmFtZQAKCRCLIp0vfMwE8v57AP0YZgrLnYEYYDHhDZpV3oONSMG8 gNwbadpOoIdy6k9ezwD8CAvOh3y478zVAg65bc6jaxPkzVR/Krv+1J1j3R8nFwg=
=OVZX
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)