1. Forum
  2. Usenet
  3. LINUX.DEBIAN.DEVEL.MENTOR

  • Proposed attempt to make reviews less verbose. Move most data to a Debi

    From Phil Wyett@21:1/5 to All on Thu Feb 13 06:00:02 2025
    Example email below.

    Control: tags -1 +moreinfo or +confirmed

    <submitter>,

    Preamble
    ========

    Thank you for taking the time to prepare this package and your ongoing contribution to the Debian project.

    This review is offered to help package contributors to Debian mentors improve their packages (where needed) prior to possible sponsorship into Debian by a Debian Developer.

    For information on each of the tests I run, see the link below.

    https://wiki.debian.org/PhilWyett/DebianMentoring

    Test 1: Pass
    Test 2: Pass
    Test 3: Pass
    Test 4: Pass
    Test 5: Pass
    Test 6: Pass
    Test 7: Fail

    Test 7 Fail Summary
    ===================

    d/copyright | licensecheck

    BSD-3-clause | BSD-4-Clause-UC stubby/src/compat/getopt.c

    Summary
    =======

    I believe <package> is ready for review/possible sponsorship. Could a Debian Developer (DD) with available free time, please review this package and upload if you feel it is ready.

    Regards

    Phil

    --

    Donations...

    Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

    --

    "I play the game for the game’s own sake"

    Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

    --

    Internet Relay Chat (IRC): kathenas

    Website: https://kathenas.org

    Instagram: https://instagram.com/kathenasorg

    Threads: https://www.threads.net/@kathenasorg

    --


    -----BEGIN PGP SIGNATURE-----

    iQJOBAABCAA4FiEEcKCsRax3nv6E9jrtckqptS8CTIsFAmete70aHHBoaWxpcC53 eWV0dEBrYXRoZW5hcy5vcmcACgkQckqptS8CTItA7Q//eLnbU9lV5f4/x4KoJWE6 iO0Lt4rOv0VJ36gt1Mrs6ruxzZzVAE3rw5pRKmjsiuCWIBzYhvrsiM3RCypPj+DV Q/r9M03pEUSoP1fTho0KnUOFWH1vVj2JFLfvwSZjBB0zhSZ5jbY+lk8GEO2VT/nw h+YZBImnsuwp5PKqC5u5kYcBp6RnX/SOKeyTy/ioV9F7UoPmCkxTXlKMcy70ZAoy PibUJn8aS1mSPDn8+HY54yEwGb6VQwIOrKRh8helXeAOfsyMukIS/Z7+XppCRxy5 yGrMHRUh1O0YRy6ST7pIMgo/RC8wY3KJKueUMgaSZdDKAso9p1VYlSF9clbjD2Fp mvOVKGuklHOvSG2UBxci8IJANxlBpWimUDzWdMqFJ2Ar0z30cJqlyZRXOgzZkq7o +7MSCqqXs+hgB4gOKbQFHaQucKpKaPhCYsANVbIRmW6GVtCOiVqrmUJzlDZmM1De
    zr5aHNEB9jIp6
  • From =?UTF-8?Q?Julien_Plissonneau_Duqu=C@21:1/5 to All on Thu Feb 13 10:10:01 2025
    Hi Phil,

    I like the new synthetic preamble and failure summary, I would just
    suggest to mention what the tests are about, e.g. instead of just

    Le 2025-02-13 05:57, Phil Wyett a écrit :

    Test 1: Pass
    Test 2: Pass
    Test 3: Pass
    Test 4: Pass
    Test 5: Pass
    Test 6: Pass
    Test 7: Fail

    make it

    Test 1 (reproducibility): Pass
    Test 2 (pbuilder): Pass
    Test 3 (build twice): Pass
    Test 4 (sbuild): Pass
    Test 5 (ratt): Pass
    Test 6 (debian/watch): Pass
    Test 7 (licenserecon): Fail

    Also you could maybe still provide a more detailed log of detected
    (potential) issues (similar to the current format) as a text attachment.

    Cheers,

    --
    Julien Plissonneau Duquène

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Phil Wyett@21:1/5 to All on Thu Feb 13 10:20:01 2025
    On Thu, 2025-02-13 at 10:08 +0100, Julien Plissonneau Duquène wrote:
    Hi Phil,

    I like the new synthetic preamble and failure summary, I would just
    suggest to mention what the tests are about, e.g. instead of just

    Le 2025-02-13 05:57, Phil Wyett a écrit :

    Test 1: Pass
    Test 2: Pass
    Test 3: Pass
    Test 4: Pass
    Test 5: Pass
    Test 6: Pass
    Test 7: Fail

    make it

    Test 1 (reproducibility): Pass
    Test 2 (pbuilder):        Pass
    Test 3 (build twice):     Pass
    Test 4 (sbuild):          Pass
    Test 5 (ratt):            Pass
    Test 6 (debian/watch):    Pass
    Test 7 (licenserecon):    Fail

    Also you could maybe still provide a more detailed log of detected (potential) issues (similar to the current format) as a text attachment.

    Cheers,


    Julien,

    Thanks for the feedback. I have added the additional info to the test lines.

    There will still be detailed information where issues exist, I will just be taking additional time to weed out anything that is blatantly not necessary in reports.

    See how it goes and we can adjust if required.

    Regards

    Phil

    --

    Donations...

    Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

    --

    "I play the game for the game’s own sake"

    Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

    --

    Internet Relay Chat (IRC): kathenas

    Website: https://kathenas.org

    Instagram: https://instagram.com/kathenasorg

    Threads: https://www.threads.net/@kathenasorg

    --


    -----BEGIN PGP SIGNATURE-----

    iQJOBAABCAA4FiEEcKCsRax3nv6E9jrtckqptS8CTIsFAmetuO0aHHBoaWxpcC53 eWV0dEBrYXRoZW5hcy5vcmcACgkQckqptS8CTIusTA//W0sfrcT0FHuSoe5Nn3sF RqV4FS84BQwMIi2q0Ed7H2QmpsxR14uU0Oxw7SDD7EwXUbhkC+MAAVTGyRnSacM6 Yt2Iw+X18n3kfAzbKidMvsI/UD35CAltOdIwOIyYmAKc3G7gq5bGmT4D0GQJIDbm V8K/3LU2VgxqL/NOjIykId/BdqVAwxeMOZmdxyvKFRDompscxaowqkHQv/NAQTx1 PMNboDGd2xSCE1qjUgZf8ZKWrNp+Y8yoSKAPke+5EGoam9qVDiNVkavCgVmkHRSY bx5qPCcEXH4oDtWA2R+EGHWxbnPMiUTtLMm0XMcO2UjZ5WmsSmIP+GhTOxyvRjQI wt8dXEtbGZkXPOaCj32wVUf1KyC0kamY6en23AQarb3dBOEQwjLe1tmNAoHYfjTv sgIv0Dox0mhdOXlb+d4IvmI6VwKnVliQWfIOVCqul9NXQcXPuL8Wt96BoCiLdcH/
    zxOebhS8n3wW6
  • From Eduardo M KALINOWSKI@21:1/5 to Phil Wyett on Thu Feb 13 13:50:01 2025
    On 13/02/2025 01:57, Phil Wyett wrote:
    Test 1: Pass
    Test 2: Pass
    Test 3: Pass
    Test 4: Pass
    Test 5: Pass
    Test 6: Pass
    Test 7: Fail

    A short description of what is each test would be helpful, IMHO.


    --
    Your mode of life will be changed to EBCDIC.

    Eduardo M KALINOWSKI
    [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Phil Wyett@21:1/5 to Eduardo M KALINOWSKI on Thu Feb 13 17:00:02 2025
    On Thu, 2025-02-13 at 09:24 -0300, Eduardo M KALINOWSKI wrote:
    On 13/02/2025 01:57, Phil Wyett wrote:
    Test 1: Pass
    Test 2: Pass
    Test 3: Pass
    Test 4: Pass
    Test 5: Pass
    Test 6: Pass
    Test 7: Fail

    A short description of what is each test would be helpful, IMHO.



    Hi Eduardo,

    I have added the small descriptions kindly suggested by Julien Plissonneau Duquène. This can be seen in the example report at the link below.

    https://wiki.debian.org/PhilWyett/DebianMentoring

    The link is with each review and will eventually contain expanded information about tests and will link to appropriate pages also within Debian.

    This is an attempt at a reducing the email data dump and move some information to the wiki and maybe give better quality information overall.

    Regards

    Phil

    --

    Donations...

    Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

    --

    "I play the game for the game’s own sake"

    Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

    --

    Internet Relay Chat (IRC): kathenas

    Website: https://kathenas.org

    Instagram: https://instagram.com/kathenasorg

    Threads: https://www.threads.net/@kathenasorg

    --


    -----BEGIN PGP SIGNATURE-----

    iQJOBAABCAA4FiEEcKCsRax3nv6E9jrtckqptS8CTIsFAmeuFZ4aHHBoaWxpcC53 eWV0dEBrYXRoZW5hcy5vcmcACgkQckqptS8CTItHUw/6AjVuGrfks1J9ESDQPmUG m3zs7CeQpn9j/0ZnE7fnyL1+wf+5mBtlqi8ykBb5xIMAJ7lvOksLHlWhVxubrL9q WUtscD2wWfcCdVpt0gcvauWNqoTsXUMlkRF0DeUbrzhvfWoASQu7V9lmc9Dssmzp n+BuNoXl851D9qtKhC3jyeiDi+uqv85jU2aHERO3c12gfDwD86PpmNZSGcemu12z NQWu+dtjcZOJR+z7yJbV3Jsfhc0cC7mREGYf6ambjxmDy+96V+CDZBccAmaQLMou 5mfIKUrBDw/F5eknvhpldiFJneK+105H2M5mP12btzCd+Q+zzii6xfPcBy/7X7Fe 6jDNyK5dNs6uva99TFIrrDcVKr53GkYWcCzEzygSN+pRpGC1DH4Ud3jyOng8ELMY p2XQAvFjUBIEhc0UOtWo/WoeZKlybdx4H4UsxstMQMGVAkC3/MRfMPbiITmRp7Za
    /e5Kpej9xhLxN