1. Forum
  2. Usenet
  3. LINUX.DEBIAN.DEVEL.MENTOR

  • Spotted small bug after upload to NEW: Wait or fix now?

    From Jonathan Rubenstein@21:1/5 to All on Mon Oct 16 17:40:01 2023
    Hey debian-mentors,

    I recently made my first package, and with the guidance and help of Hugh McMaster (who I thank kindly) had it sponsored and uploaded to NEW in
    #1051150. I have spotted a tiny bug in my brand new package which
    somehow after hours rebuilding and testing (it's HTML documentation, so
    really just looking at and clicking around in) I never spotted.

    Some links are present in the front page of the documentation which lead nowhere in the packaged version. I have fixed this already in my salsa
    repo by adding a patch in debian/patches which removes the links and
    prepared a new debian version almost ready for upload. If this package
    was already in the archive the bug would likely be of priority "normal"
    or even "minor".

    Since this bug really doesn't affect the package that much as it works
    fine anyway with only a few broken links, is it worth going through the
    trouble of getting it fixed while it's still in NEW, or is it better to
    leave it and get the fix uploaded after it has cleared NEW and entered
    the archive?

    Would a few broken links (of note on the front page, easy to see)
    reasonably be enough to have the package rejected from NEW? That would
    surely be enough of a reason to go through the trouble, to potentially
    save further delay.



    Regards,
    Jonathan Rubenstein

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mattia Rizzolo@21:1/5 to Jonathan Rubenstein on Mon Oct 16 21:40:01 2023
    On Mon, Oct 16, 2023 at 06:36:48PM +0300, Jonathan Rubenstein wrote:
    If this package was already in
    the archive the bug would likely be of priority "normal" or even "minor".

    Since this bug really doesn't affect the package that much as it works fine anyway with only a few broken links, is it worth going through the trouble
    of getting it fixed while it's still in NEW, or is it better to leave it and get the fix uploaded after it has cleared NEW and entered the archive?

    Would a few broken links (of note on the front page, easy to see) reasonably be enough to have the package rejected from NEW? That would surely be enough of a reason to go through the trouble, to potentially save further delay.

    YMMV (and not only yours), but I vote for the "leave the current NEW
    version where it is, don't upload, wait until approved and upload the
    fit".

    Reasons:
    1) it was never really clear to me what the ftp-team look at when
    there are multiple versions of the same package pending in the queue
    (because technically when there are they go and approve all of them
    at once); I wouldn't want to burden them with an extra version and
    figure out why there is an extra version for such a minor thing
    2) asking them to reject the current version to fix a minor bug,
    it's also just bothering already busy people for very little gain

    --
    regards,
    Mattia Rizzolo

    GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
    More about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'`
    Debian QA page: https://qa.debian.org/developer.php?login=mattia `-

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAmUtjzgACgkQCBa54Yx2 K622hw/+NpPIgnzdys2uQibxLk2Kkfb5adfnA5S+n/ExjE2H/RbeHlIetj0wXFb6 DZOxYHDXeSeGazB3xLCCEG7i++WvvZ//4HSdZ9b+WJIEmpCGGOCsxMgu1g8GmyaQ eEbzXAMc5yM2XB7NuSM0vrzBrO+B3WuW5WaCT3eUGKInkz49/9xrGLHVt8TyXSDQ 8KiEnG8sBG74nh6PS85+PE4lCx/2XCvstfJXBy5QtJtmjRbGIx2IIcZyI9ExHmsn Lk5R2y+26gk2dACnt57oL8qOD8YFX7wlWL8cFDzygOAXyHKyBhMq7+lMQklX2KAS YTtPycaUgowsuW0njUUC+Jv195EaJRW+u85yPsg3bwJLvWXMq7ZmOzOxT0uQkcGN 1BBR8QviEwtYid8+LzEa4sdAl8I3xkVqW5TnwTcuWDc1WhgU/el9Dfb6BB603/6r aq40fdCPKmJ8Ccc6dSWFIkIAjobOIe22WJyGynjasgZq4E4G0w1IEIF2SCkqPDBo aQw5lnuJZX0+0z2c/FcPxtYlTlrT1GpeY1x+Qqqm+VMOro0dcvv
  • From Joerg Jaspert@21:1/5 to Jonathan Rubenstein on Mon Oct 16 22:20:01 2023
    On 17018 March 1977, Jonathan Rubenstein wrote:

    Since this bug really doesn't affect the package that much as it works
    fine anyway with only a few broken links, is it worth going through
    the
    trouble of getting it fixed while it's still in NEW, or is it better
    to
    leave it and get the fix uploaded after it has cleared NEW and entered
    the archive?

    Would a few broken links (of note on the front page, easy to see)
    reasonably be enough to have the package rejected from NEW? That would
    surely be enough of a reason to go through the trouble, to potentially
    save further delay.

    Such a broken link will not get you the package rejected, no.

    Now, for the fix-now-or-later question: Fix it now and upload. It does
    not create extra work for FTPMasters and if its a real bug we could
    spot, we see the fixed version right away. Also, it means that the bug
    won't enter the archive at approval time, only the fixed version.

    --
    bye, Joerg

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jonathan Rubenstein@21:1/5 to All on Tue Oct 17 01:50:01 2023
    On 16.10.2023 23.14, Joerg Jaspert wrote> Now, for the fix-now-or-later question: Fix it now and upload. It does
    not create extra work for FTPMasters and if its a real bug we could
    spot, we see the fixed version right away. Also, it means that the bug
    won't enter the archive at approval time, only the fixed version.


    Thanks for the response! I'll get on that.


    Jonathan

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)