• Re: [libbladerf2] Change udev rule to add plugdev group (3/4)

    From Hibby@1:229/2 to All on Tue Sep 10 17:50:01 2024
    [continued from previous message]

    <!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div style="font-family:menlo, consolas, monospace;">I saw the discussion on salsa!<br></div><div style="font-family:menlo, consolas,
    monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">I'm sure there's plenty of bugs to dig into at <a href="https://udd.debian.org/dmd/?email1=debian-hams%40lists.debian.org&amp;email2=&amp;email3=&amp;packages=&amp;ignpackages=&
    amp;format=html#todo">https://udd.debian.org/dmd/?email1=debian-hams%40lists.debian.org&amp;email2=&amp;email3=&amp;packages=&amp;ignpackages=&amp;format=html#todo</a><br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="
    font-family:menlo, consolas, monospace;">I know at least uronode is struggling on some 32bit architectures, there are some ftbfs issues, there are some upstream updates outstanding and more!<br></div><div style="font-family:menlo, consolas, monospace;"><
    </div><div style="font-family:menlo, consolas, monospace;">Cheers<br></div><div style="font-family:menlo, consolas, monospace;">H<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div id="sig145015272"><div class="signature">--&
    nbsp;</div><div class="signature">&nbsp; Hibby</div><div class="signature">&nbsp; Debian Developer</div><div class="signature">&nbsp; Packet Radioist</div><div class="signature">&nbsp; MM0RFN</div></div><div style="font-family:menlo, consolas, monospace;"
    <br></div><div>On Mon, 9 Sep 2024, at 9:09 PM, Martin Herren - HB9FXX wrote:<br></div><blockquote type="cite" id="qt" style=""><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><div>Hi Dave,
    <br></div><div><br></div><div>Thanks for your answer.<br></div></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;
    color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">Things have changed a little now. A new .deb package has been released with the new upstream release and thus my MR is now in conflict.<br></div><div style="font-family:Arial, sans-serif;font-size:
    14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">As suggested by Mait it is probably better to try to open my MR
    against upstream directly.<br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">If that doesn't work there is still time to adapt my MR again.<br></div><div style="font-family:Arial,
    sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">So i'll open an new MR directly to upstream as
    this makes sense and the issue can also affect other distributions.<br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:
    14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><div>I'd like to thanks all of you that helped and guided my over the last 2 months, i learned a lot, including about sbuild and quilt and the packaging process in general. So the time was not
    waisted and i hope to find other opportunities to contribute to Debian !<br></div><div><br></div><div>Cheers,<br></div><div><br></div><div>Martin - HB9FXX<br></div></div><div><div><br></div><div>On Tuesday, August 27th, 2024 at 12:51 PM, Dave Hibberd &lt;
    [email protected]&gt; wrote:<br></div></div><div style="font-family:Arial, sans-serif;font-size:14px;"><blockquote class="qt-protonmail_quote" type="cite"><div style="font-family:menlo, consolas, monospace;"><div style="font-family:menlo, consolas,
    monospace;">Hi Martin!<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Things have been a little hectic here but this is still on my radar to look at!<br></div><div style="font-
    family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Aa a quick reply -<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">For filing
    a bug - if you feel it's not desired behaviour, go ahead and file a bug. The bugtracker is a default method of interacting and discussing things with each other in Debian, so don't be shy. The worst that happens is it gets reassigned, merged with another
    or closed after discussion.<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">For the dpkg-divert, it's all fairly recent and tied to the usrmerge change, so it's probably best to
    look to mait for guidance on that. As you've changed the name of the rules, <i>something </i>will need to change at least!<br></div><div style="font-family:menlo, consolas, monospace;"><br></div><div style="font-family:menlo, consolas, monospace;">Cheers,
    <br></div></div><div style="font-family:menlo, consolas, monospace;"><br></div><div id="qt-sig57366953"><div class="qt-signature">--&nbsp;<br></div><div class="qt-signature">&nbsp; Hibby<br></div><div class="qt-signature">&nbsp; MM0RFN<br></div></div><
    div style="font-family:menlo, consolas, monospace;"><br></div><div>On Sun, 4 Aug 2024, at 2:02 PM, Martin Herren - HB9FXX wrote:<br></div><blockquote style="" id="qt-qt" type="cite"><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0,
    0);background-color:rgb(255, 255, 255);"><div>Hi all,<br></div><div><br></div><div>Thanks to all the help I received so far.<br></div><div><br></div><div>I updated my MR at <span><a href="https://salsa.debian.org/debian-hamradio-team/bladerf/-/merge_
    requests/1" rel="noreferrer nofollow noopener" target="_blank">https://salsa.debian.org/debian-hamradio-team/bladerf/-/merge_requests/1</a></span> as i managed to build and test the .deb using sbuild and now used quilt to adapt the udev patch.<br></div></
    <div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">The 2
    questions now are:<br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><ul><li style="list-style-type:&quot;- &quot;;"><span>As the issue with udev uaccess could be considered a bug,
    should i still open an bug report ? I can confirm the bug is already present in Bookworm</span><br></li><li style="list-style-type:&quot;- &quot;;"><span>I don't understand the `dpkg-divert` stuff, from my understanding as there are now new udev rules
    files with new names, all the dpkg-divert postinstall/preremove stuff could now be removed ?</span><br></li></ul><div><div><br></div><div>Thanks and best regards,<br></div><div><br></div><div>/Martin<br></div></div></div><div class="qt-qt-protonmail_
    quote"><div>On Monday, July 29th, 2024 at 12:48 AM, Martin Herren - HB9FXX &lt;[email protected]&gt; wrote:<br></div><blockquote type="cite" class="qt-qt-protonmail_quote"><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);
    background-color:rgb(255, 255, 255);"><div>Hi,<br></div><div><br></div><div>Thanks Dave, what a huge amount of help and pointers you just provided.<br></div></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-
    color:rgb(255, 255, 255);"><div><br></div><div>Previously i tried to build the .deb using `debuild`. While it succeeded to produce a .dsc it failed generating a .deb with the same error as in the salsa ci/cd pipeline as in <span><a target="_blank" rel="
    noreferrer nofollow noopener" href="https://salsa.debian.org/MartinHerren/bladerf/-/jobs/6029130">https://salsa.debian.org/MartinHerren/bladerf/-/jobs/6029130</a></span>.<br></div></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0,
    0, 0);background-color:rgb(255, 255, 255);">I had both original tarballs available. With some manual hacking i managed to get a little further without succeeding.<br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);
    background-color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><div>I then followed your procedure and managed to set up an initial unstable sbuild
    environment and it managed to build a .deb !<br></div><div>Now i'll validate the 2 issues i'm trying to solve with my MR by installing the new .deb.<br></div></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-
    color:rgb(255, 255, 255);"><br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);">Yes, the patch has been somewhat manually generated by modifying the .orig folder and generating a diff
    out of it that i used to update the patch. Next will be to look at quilt and i'll update my MR.<br></div><div style="font-family:Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><br></div><div style="font-family:
    Arial, sans-serif;font-size:14px;color:rgb(0, 0, 0);background-color:rgb(255, 255, 255);"><div>Thanks a lot, this helps a lot to go forward with this MR !<br></div><div><br></div><div>Cheers,<br></div><div><br></div><div>Martin<br></div></div><div style="
    font-family:Arial, sans-serif;font-size:14px;"><br></div><div class="qt-qt-protonmail_quote"><div>On Saturday, July 27th, 2024 at 1:14 AM, Dave Hibberd &lt;[email protected]&gt; wrote:<br></div><blockquote class="qt-qt-protonmail_quote" type="cite"><div>I
    always have sbuild[1] set up and an unstable chroot for building ready to go. Sbuild will always fail if you don’t have the orig.tar.gz matching the level - I notice this one relies on two original tarballs:<br></div><div><div>```<br></div><div>dpkg-
    source: info: unpacking bladerf_0.2023.02.orig.tar.gz<br></div><div>dpkg-source: info: unpacking bladerf_0.2023.02.orig-drivers.tar.xz<br></div></div><div>```<br></div><div>Maybe that’s part of your firmware issue?<br></div><div><br></div><div>I
    strongly recommend playing with sbuild, it’s a fantastic tool. I’ve been using it to do cross builds for different architectures and all kinds of funky stuff this year. Recently I learned you can feed it the url to a .dsc and it will download
    everything from the remote server required to build that package! `sbuild&nbsp;<a href="http://deb.debian.org/debian/pool/main/q/qsstv/qsstv_9.5.8-3.dsc%60" rel="noreferrer nofollow noopener" target="_blank">http://deb.debian.org/debian/pool/main/q/qsstv/
    qsstv_9.5.8-3.dsc`</a>&nbsp;(for example) now happens quite a lot in&nbsp;my house!<br></div><div><br></div><div><br></div><div><span>One thing I notice after a quick look at the commits is that your patch format looks odd to me - how did you generate
    updates to d/patches/</span><span>update-bladerf-udev-rules? Did you edit the patch file directly?</span><br></div><div><br></div><div>I notice lines like&nbsp;<span>diff --git a/host/misc/udev/60-nuand-bladerf1.rules.in b/host/misc/udev/60-nuand-
    bladerf1.rules.in are a bit unusual to my eyes (someone else, of course, may correct me - there’s many ways to interact with&nbsp;Debian!). It clearly still builds, so presumably it’s just a style difference! I tend to ship upstream’s code in my
    repos, not just the Debian folder so there may be a packing style difference between mait and I there too.</span><br></div><div><span style="color:rgb(0, 0, 0);"></span><br></div><div><span>I use quilt[2] for patching generally. It’s worth installing
    quilt and setting up a .quiltrc as the wiki page suggests.&nbsp;</span><br></div><div><span>You’ll be looking to push the relevant patch on to the stack with `quilt push&nbsp;</span><span>update-bladerf-udev-rules`</span><span>&nbsp;make changes
    directly to the code, run `quilt refresh` and then `quilt pop -a` to pull the patches off the stack, but it assumes the code is adjacent to the folder.</span><span></span><br></div><div><br></div><div><span>Hopefully&nbsp;this helps - you’re welcome to
    reach out and ask for help any time!</span><span><br></span><span><br>Cheers</span></div><div><div><span>Hibby<br></span><span><br></span><span>[1]&nbsp;</span><a href="https://wiki.debian.org/sbuild" rel="noreferrer nofollow noopener" target="_blank">
    https://wiki.debian.org/sbuild</a><span><br></span><span>[2]&nbsp;<a href="https://wiki.debian.org/UsingQuilt" rel="noreferrer nofollow noopener" target="_blank">https://wiki.debian.org/UsingQuilt</a></span></div><div><div><div>--<br></div><div>&nbsp;
    Hibby<br></div><div>&nbsp;&nbsp;Debian Developer<br></div><div>&nbsp;&nbsp;Packet Radioist<br></div><div>&nbsp;&nbsp;MM0RFN<br></div></div></div></div></blockquote></div></blockquote></div><div><br></div><div><b>Attachments:</b><br></div><ul><li>
    signature.asc<br></li></ul></blockquote><div style="font-family:menlo, consolas, monospace;"><br></div></blockquote></div><div><br></div><div><b>Attachments:</b><br></div><ul><li>signature.asc<br></li></ul></blockquote><div style="font-family:menlo,
    consolas, monospace;"><br></div></body></html>

    [continued in next message]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)