XPost: linux.debian.bugs.dist
From: [email protected]
Copy: [email protected]

On Tuesday, 24 December 2024 05:03:30 GMT tony mancill wrote:

Attached is a patch that simplifies the seeding of srand48().

Dave, if you'd like, I can go ahead and prepare an updated package.

Feel free to team upload!

The only reason I didn't go ahead and do so is because I noticed that
a minor difference between what's in the source package in the archive
and what's in the Salsa repo, and I didn't want to create a 3-way merge
in case you have other work in progess.

Interesting - I've got nothing in progress intentionally at the moment, I mustn't have tagged & pushed.

I suspect there is one missing commit (plus the tag for debian/1.19-11)
that needs to be pushed to Salsa. Specifically, the source package
doesn't contain the file .gitignore, which appears was accidentally
added in commit 47224e3868f6e2e845a024b9343ed35d01195ec0. If you would
like to push your commit and the tag, please do. Otherwise, I'll use
the commit and tag created by `gbp import-dsc` for the -11 revision and
push that.

I'm away from home til the 30th and some recent fiddling has rendered my normal build machine inaccessible (remote power-on is no longer powering it on!) so I won't be able to do anything until then - feel free to use the source package.

Thanks,
tony

Cheers!

--
Dave Hibberd <[email protected]>
Debian Developer
Packet Radioist
MM0RFN
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEXk9UUZPolpyKWbgKA6H7ehkEdxsFAmdq3AkACgkQA6H7ehkE dxu9qQgAqnwqIrtL4t0r1X69vtVKooLOQlMrSx1vKS0qfFwb+ZjwL1X2nuXUHPUz wlaBVfOoyQA5M/dWmORWr6kgcGbSy4KLkGSvxaaOmTxFtJGDlcwRvkeNSOwTEWO5 6Y9UUI35j/v6CUEpc72KMWKRdUli5dSpPcSDhRVwisQz5dBs+uTch+dnC8+uWD4g 3lhFOA2MFGh8p/50dnrNxFvwTVolsI/ged12SvApRGeOaIFjLEjnrkUoz6yDXQEX 8J8odaUnw1xMiYkJHfJSSMIbsi7vwIRnbXLL9/FID916jcHGEp7xJnaSdUzSgb/I QuJXc1rIWiZOM2cHTu0H5V/WHejmsQ==
=+6c9
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

XPost: linux.debian.bugs.dist
From: [email protected]

--BDzH44KJ+fWIkzlb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 23, 2024 at 06:33:56PM +0100, Lucas Nussbaum wrote:

Source: yagiuda
Version: 1.19-11
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: [email protected]
Usertags: ftbfs-20241223 ftbfs-trixie

random.c: In function ‘seedRNG’:
random.c:84:14: error: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]
84 | time(&seed_time); /* set seed_time to the number of seconds since Jan 1980 */
| ^~~~~~~~~~
| |
| long int *
In file included from /usr/include/features.h:510,
from /usr/include/arm-linux-gnueabihf/bits/libc-header-start.h:33,
from /usr/include/stdlib.h:26,
from random.c:2:
/usr/include/time.h:85:15: note: expected ‘time_t *’ {aka ‘long long int *’} but argument is of type ‘long int *’
85 | extern time_t __REDIRECT_NTH (time, (time_t *__timer), __time64);
| ^~~~~~~~~~~~~~
make[2]: *** [Makefile:615: random.o] Error 1

Attached is a patch that simplifies the seeding of srand48().

Dave, if you'd like, I can go ahead and prepare an updated package.

The only reason I didn't go ahead and do so is because I noticed that
a minor difference between what's in the source package in the archive
and what's in the Salsa repo, and I didn't want to create a 3-way merge
in case you have other work in progess.

I suspect there is one missing commit (plus the tag for debian/1.19-11)
that needs to be pushed to Salsa. Specifically, the source package
doesn't contain the file .gitignore, which appears was accidentally
added in commit 47224e3868f6e2e845a024b9343ed35d01195ec0. If you would
like to push your commit and the tag, please do. Otherwise, I'll use
the commit and tag created by `gbp import-dsc` for the -11 revision and
push that.

Thanks,
tony

--BDzH44KJ+fWIkzlb
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="long-int.patch"

Index: yagiuda/src/random.c ==================================================================--- yagiuda.orig/src/random.c
+++ yagiuda/src/random.c
@@ -79,10 +79,5 @@ int randint(void)
usually necessary to seed both sepparately */
void seedRNG(void)
{
- long seed_time;
-
- time(&seed_time); /* set seed_time to the number of seconds since Jan 1980 */
-
- srand48(seed_time); /* Seed the float type */
-
+ srand48((long)time(NULL)); /* Seed the float type */
}

--BDzH44KJ+fWIkzlb--

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmdqQKIACgkQIdIFiZdL PpYASBAAvFMwjTryf7CdSqm5m6rJqeBKwGxCcD2+13jdAFyi1O9sS1Qanv5IncSZ lAhfaiTp4jnLlqrQsepPbz2U0n02Gj8Q1slujr/4YWoJ3jjgVr0byGAo4U/+tLAd fYjFPQ7nKCw9mPGrgdKnAV7kTMhLpC1IgP2U6VamBMdMd9x124QqWw9rFpK8lYGb HcSzIRlse9/6PRON5ShgnCnp8zFlu38rlIoBQetOhWYI82fsrRC4XKSdWPs6aAEJ +4YQyN++UFoeVC8KtNNuWHCOyMvGuM97OL9xbc1sy3PJP7f1kM052NmVW2dj2Ltz Hv972q6X2TVhjHcgXEJLtlSdmLAwEV5PN/Sz9f//KypBZGLG4DLsiSX8Sf51nBdG qjnMQdXi9qfuXlYJ3MXMrUIPoRDAlqXdtvt44oMZ3N4EQNitivoV5Rt89x05ZdLg CGHEd1en/Mf9rMuh2aU7Xg8TF9NrSJqUVeyZlns2PceqXBRY4ZgCqtdx9MblXRac QvEQ1zmoyB871bUacHUv77QIYY617PeH4d3N1TqzPektopKWdBkc+eSWeu3VHspw y2Dcw8uWZp+hvnOODCmUYlOqrw1x5Z4ao3aPQRK2VQamWyzaz2oG1FCrUdvLwrnP 37iKSD+xBeqSRZyULhbSKQAQWinGKfU1oRaak8nVbPA7j3KlrGk=
=D8OJ
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

XPost: linux.debian.bugs.dist
From: [email protected]

Source: yagiuda
Version: 1.19-11
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: [email protected]
Usertags: ftbfs-20241223 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, this package failed to build
on armhf.

This package currently has binary packages on armhf, so this is a regression. Also, there are no known issues on amd64 or arm64 according to recent (a couple days ago) rebuilds.

The rebuild was done using an armhf chroot on an AWS "m6g" instance (Graviton2 CPU).

Relevant part (hopefully):

gcc -DPACKAGE_NAME=\"yagiuda\" -DPACKAGE_TARNAME=\"yagiuda\" -DPACKAGE_VERSION=\"1.19\" -DPACKAGE_STRING=\"yagiuda\ 1.19\" -DPACKAGE_BUGREPORT=\"[email protected]\" -DPACKAGE_URL=\"\" -DPACKAGE=\"yagiuda\" -DVERSION=\"1.19\" -DHAVE_LIBM=1 -DHAVE_

STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_STDIO_H=1 -DHAVE_MATH_H=1 -DHAVE_ERRNO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_
TIME_H=1 -DHAVE_SYS_TIME_H=1 -DHAVE_STRING_H=1 -DHAVE_CTYPE_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DHAVE_VALUES_H=1 -DHAVE_ALLOCA_H=1 -DHAVE_ALLOCA=1 -DHAVE_STRUCT_STAT_ST_BLKSIZE=1 -DHAVE_ST_BLKSIZE=1 -I. -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=
64 -D_TIME_BITS=64 -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -c -o get_command_line_options.o get_
command_line_options.c

random.c: In function ‘seedRNG’:
random.c:84:14: error: passing argument 1 of ‘time’ from incompatible pointer type [-Wincompatible-pointer-types]
84 | time(&seed_time); /* set seed_time to the number of seconds since Jan 1980 */
| ^~~~~~~~~~
| |
| long int *
In file included from /usr/include/features.h:510,
from /usr/include/arm-linux-gnueabihf/bits/libc-header-start.h:33,
from /usr/include/stdlib.h:26,
from random.c:2:
/usr/include/time.h:85:15: note: expected ‘time_t *’ {aka ‘long long int *’} but argument is of type ‘long int *’
85 | extern time_t __REDIRECT_NTH (time, (time_t *__timer), __time64);
| ^~~~~~~~~~~~~~
make[2]: *** [Makefile:615: random.o] Error 1

The full build log is available from: http://qa-logs.debian.net/2024/12/23/yagiuda_1.19-11_unstable-armhf.log

All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20241223;[email protected]
or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20241223&[email protected]&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)