1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.HAMS

  • seeking review of pat v0.15.0-1

    From Federico Grau@21:1/5 to All on Sat Jul 8 21:50:01 2023
    I've updated the `pat' Debian package to v0.15.0 and pushed to salsa.d.o git. Upstream changes since v0.13.1 include improvements to VARA and AX25 (AGWPE).

    As there are cycles a review is welcome.

    regards,
    donfede

    Fede Grau


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmSpvIwACgkQL/shsp/k V2QUug/9FQcLf6/rm1VmlxJzTTkUQqzZRO4ZBM23oEsKF2m4fQKrBr5VUpjIKS3U GsFzrZwGPijSCgtjrEjmpE0kiEh13Hnw7OkWNesh+ATL9KoV76c/T5mUIbUV4UPi pUUk9SSPc8uTAxgyZcEmdXbMqULOHBcUKm/n5EFzNJTXqu2KEvS7Nw9IgNjUN5e+ 8cxPecBs8HbwbigMZ/CqwLuaJynXmEfkr09H8OWNQfViKDLbURmuyFMvV8YxFPMn pT5xAKKG6mWXjCIsw4DR4ACaSUjZnMBZSsLmoHN84/vxNv7XIMGEnbP4w8VcA3VN kZVYmy77N+xw9wKcIYv/LKNfT4ELcpiXVXzb5x+IZAI3YNLszhHysmQP6hE2yroq zw7E2I12B1EEH8sHqFrKrvCnCFfLcVAaEcKLK3BNl52Sr/spPrZmeOUZBS9cplvd JUe7OEBAEF/40bXx9Tm1+jWekiT8po/SkfTtzgMWxSw+PaBnMCTg0ReDqQLbhgtx gmXMDZ2+20rECKr2NkHSvGnyrRLVp0wA2HBMjR5UK4zz17w2KkzePZCfzQ2idQ0C Jvo1XScBpTkzr4hIO5kQ2aahIczGqFspKNNS98yCfN6x2eec3LvKV2FlwJH7gJ1f XUyU6XiGpz+8qU77vGr40PqvNwBlRGpY6c4bxm8ec1Zu7us2Hxg=
    =Cb3Q
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From tony mancill@21:1/5 to Federico Grau on Mon Jul 10 01:20:01 2023
    Hello Federico,

    On Sat, Jul 08, 2023 at 03:44:19PM -0400, Federico Grau wrote:
    I've updated the `pat' Debian package to v0.15.0 and pushed to salsa.d.o git. Upstream changes since v0.13.1 include improvements to VARA and AX25 (AGWPE).
    While testing the package, I noticed a couple of minor issues.

    1) The binary package installs a manpage for pat-winlink-configure, but
    there is no binary with that name in the package. Perhaps this moved in
    this new version? I am able to edit my configuration with "pat-winlink configure" (that is, using the default binary with the verb "configure".

    2) The manpages for pat-winlink and for pat-winlink-configure refer to /home/USER/.wl2k/config.json, which is the legacyDataDir according to
    the sources (see internal/directories/directories.go). I believe the
    correct path ~/.config/pat/config.json. That's where my configuration
    file exists.

    Otherwise, the packaging looks good and the software works fine. I
    tested it in telnet mode and also exercised the http UI.

    Cheers,
    tony

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmSrP7cACgkQIdIFiZdL PpZQPhAAkfTeYA2/cEVmClRQFT1mEEQgHyGAv8nOXbbkCD9E46j8R8dp/IqKUJeO V6kFzYVLCj9bbBQvwDOG9fQZGXBaxGf4G54EtA40VqmD4Wo2mrBg4Nuv40mla4vi hqbL+2uP2KQx9HZx5jlEY5ZA0ooogGNRhaLZMOw5lFYgjbfyJ0FXCnmbM3l1U2n3 jrqb4nY8Amn7vuw4b4ROuazCO45DTuwkSyedYjoCnc1RqdIeMMijJHPe9boaWcaP KZbeQToGfdWNNwUBp0FQntNRNo6x+jDSrUdiVHbnmH8KRKxdUXKaIHKod6Xp2Qle HWq5RY24MRbA9wT/YA/YdJoO1gzqzGBsO3P3MhDhpBX+WErVwebng++uCep9xqb2 2Uyl+orN1YdK2Gxyws+aE9/WZFvyiGHsNSKr9/gRO5Ug/QuMJXpVZwGGJ16CHojf h2OaN2RaHA8gGmqFlkKxtEc6KlyawybldKr0zT/XzfrjmLt3VjdlJzqFNR0jTI7C 3iSLIcHkNdYLQfAkIL7QoZ2royGpQsJSoYEtiN1UDyCJppVzmRO/F93zSSAf42En Bl0YWo55DNodPABiA/WwDdiMwZVkEJtMaTfCZ7w4mkzorVdmPmnZEyuyVQDroV74 NtdlBhZZWNciA4wC175ZlnU/dN1Id3yniYn534Pt1KUMCxtY5NU=
    =8bee
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Federico Grau@21:1/5 to tony mancill on Sun Jul 16 17:30:01 2023
    On Sun, Jul 09, 2023 at 04:16:08PM -0700, tony mancill wrote:
    Hello Federico,

    On Sat, Jul 08, 2023 at 03:44:19PM -0400, Federico Grau wrote:
    I've updated the `pat' Debian package to v0.15.0 and pushed to salsa.d.o git.
    Upstream changes since v0.13.1 include improvements to VARA and AX25 (AGWPE).
    While testing the package, I noticed a couple of minor issues.

    1) The binary package installs a manpage for pat-winlink-configure, but there is no binary with that name in the package. Perhaps this moved in
    this new version? I am able to edit my configuration with "pat-winlink configure" (that is, using the default binary with the verb "configure".

    2) The manpages for pat-winlink and for pat-winlink-configure refer to /home/USER/.wl2k/config.json, which is the legacyDataDir according to
    the sources (see internal/directories/directories.go). I believe the
    correct path ~/.config/pat/config.json. That's where my configuration
    file exists.

    Otherwise, the packaging looks good and the software works fine. I
    tested it in telnet mode and also exercised the http UI.

    Cheers,
    tony


    Many thanks again for your feedback tony,

    Pardon my delays as I was addressing some RL items. Below are some attempted responses. If realtime chat may help, I'd be glad to make myself available on IRC (OFTC, donfede, UTC -4).


    1) The two man pages included with the `pat' Debian package follow the two pages provided by upstream, with the binary name "pat" replaced with "pat-winlink" per Debian bug #994822 (and d/patches/04-update_man_pages_for_renamed_binary_994822.patch circa 2021-Nov).

    The second man page "pat-configure" or "pat-winlink-configure", as you noted, provides information on the default binary and functionality using the verb or argument "configure". This is similar to man pages like "git help" / "git-help".

    I'm not clear what change if any is needed here, but subjectively I might
    leave things the way they are given upstream and other similar man page examples (though of course constructive dialog and direction is welcome).

    $ git remote -v
    origin https://github.com/la5nta/pat (fetch)
    origin https://github.com/la5nta/pat (push)
    $ ls -1 man/
    pat.1
    pat-configure.1
    $

    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994822


    2) Thanks for the good eyes. I've refreshed d/patches/04-update_man_pages_for_renamed_binary_994822.patch to use the updated configuration file locations documented by upstream.



    Standing by for next steps as cycles are available.


    regards,
    donfede


    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCAAdFiEEmr4kxVySlu8VKlyYL/shsp/kV2QFAmS0DAcACgkQL/shsp/k V2RhhhAAjBo8De+HIzZrqCOcz/HkHlVW9CAH/Dv0oUZhwn7k34HM41vvLgcEcjAZ tJs6yNzn66SXxdvIe/8w4URJrICdHuxwypCERFpbb5Ya4quxXh3PonIIgNt9qb9d KNscb4upBSMEyxn8+VtkJtZ1PpxiFMRq4Bh87JFjARw+dh1FC6jJDlhrtk40mPsI g298iUhFq1dqujAPT0sYtySf1F84QtR4sTpDw0PaxY5uAG/zUpFrOkbyanWLM5qO Kt8nbtX0Uzx68L6yrDwpXRfixRkxeM+8Dv/FzsCjkeutk1bB5/J7c2/ygH2fcpVL vpXjK16PqHh9D2paeImq82qexBHFKgJsORbPuPUO8+7JFfcEwxrIanyWF1FqbJlQ byFPuWCbyUTDF0Brz1APe4g5ubkO2TC3tJsd11177I+NjBZsLdpJHO+7FulaVuln Z17fvODj/y+JCCbZzOOuRw80EPDMtb9wU8nAxJYMlZbhwcSu7M7aAuj94+H6c5UF t8GD58821wVrm364UG5R3wKroP65loDghB9o43H4e+vl0lrdNhOahF159fctg1iy W4jkSAzP2oA4z89mzxPUxGUkmAXgJJtKYyG2XfGzWS/SgJphgfGN+KSxhvsBYs2P nw9syhsZHdzpjkIW94OXXcvvPuoOBmrklbu9skdEcvHGpgrVDEc=
    =cYhT
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From tony mancill@21:1/5 to Federico Grau on Fri Jul 28 05:20:01 2023
    On Sun, Jul 16, 2023 at 11:26:04AM -0400, Federico Grau wrote:
    Pardon my delays as I was addressing some RL items. Below are some attempted responses. If realtime chat may help, I'd be glad to make myself available on
    IRC (OFTC, donfede, UTC -4).

    No worries, I have been very busy myself.

    1) The two man pages included with the `pat' Debian package follow the two pages provided by upstream, with the binary name "pat" replaced with "pat-winlink" per Debian bug #994822 (and d/patches/04-update_man_pages_for_renamed_binary_994822.patch circa 2021-Nov).

    The second man page "pat-configure" or "pat-winlink-configure", as you noted, provides information on the default binary and functionality using the verb or
    argument "configure". This is similar to man pages like "git help" / "git-help".

    I'm not clear what change if any is needed here, but subjectively I might leave things the way they are given upstream and other similar man page examples (though of course constructive dialog and direction is welcome).

    Thanks for the patient explanation. I was simply confused here -
    specifically, I was under the impression that there was an additional
    binary in the 0.13.1 package, but that's not the case.

    2) Thanks for the good eyes. I've refreshed d/patches/04-update_man_pages_for_renamed_binary_994822.patch to use the updated configuration file locations documented by upstream.

    Thank you!

    Standing by for next steps as cycles are available.

    I will upload momentarily. Thank you again for your patience, and for
    keeping pat up to date.

    Cheers,
    tony

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEE5Qr9Va3SequXFjqLIdIFiZdLPpYFAmTDMf8ACgkQIdIFiZdL PpZtUw/9FYrfCcV6/x9WOcS/1Jox4FwKV/yko7fvW4ZiJ6rmHUKHIWb4RwjcN5EZ L1dm2SPhtdaFnatgpg1U23ksFW1vowxXOcARts4NoNFGLbrwt9+Qqqe7+N7EIFMp zGf1eyv6VHgjaZGsoUYZgPTPeGEI6v5AROSwleGXhBEspfTkpFwrZMEntba528ef ptsp6dqHKpbifqgS8I2uuktSI6Mo9Ek53Y7rBFKPGTHLU5Sy9iOXuUE/2OYhDRgN 5lnVy2LkfNO6ti1LZHy1OZyB3ZSO+cQQnXDlJ+OC3jtdwebupXhzs4JbafWTqYpD geflvcM5U98lo1I7eH04LG8H0koWc1J0S7CrhZ1xRmxQ6g3jOUz/uM0YuWfL1aH9 ZWCh4VBa2HpJVS9Y5HNnW+UTmlb6wSHwUKeirDOv9gz1kS0pFGkbQ0p7Rz2/pkjq BWS7IhVr4TCM9p+159a7cCD70sOs7eWNZ4WjZsnXru2GSVO3/+V3lYjBE+Vpiiob 1UjvPYs/TjSIAJbUIZLb+mph2xlPOy0qo3GrsKMBSEDMXDdxWpDWeAYbxDjj48R5 PP+QnQx5J9QK4p6DyncHy3J3aYNtc4na683MQXFCNXIDKc2AizjTeKrzzkizYwwY jEWPm+qlGVZVkzg220S91x6+ruFjuvanUPh22W9339YmRI10L6Q=
    =RhUR
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)