1. Forum
  2. Usenet
  3. LINUX.DEBIAN.BUGS.DIST

  • Bug#1110027: unblock: polari/46.0-5

    From Simon McVittie@21:1/5 to All on Mon Jul 28 12:10:02 2025
    XPost: linux.debian.devel.release

    Package: release.debian.org
    Severity: normal
    X-Debbugs-Cc: [email protected], [email protected]
    Control: affects -1 + src:polari
    User: [email protected]
    Usertags: unblock

    Please consider unblocking package polari.

    [ Reason ]
    Backport an upstream patch fixing ability to join a channel: #1095989 (https://gitlab.gnome.org/GNOME/polari/-/issues/232 upstream)

    [ Impact ]
    If not fixed, the UI becomes unresponsive when joining a channel.

    [ Tests ]
    I haven't tested this (I don't use this IRC client myself) but
    presumably the uploader, J�r�my Lal, did. (J�r�my, please could you
    follow up here with details of tests you did?)

    [ Risks ]
    Not a key package, but it used to be pulled in by GNOME metapackages
    (before 2020) and might still be present on older installations.

    The impact/visibility of the issue fixed here suggests that few developers
    are using this package regularly. But the fix is simple and
    narrowly-targeted (a 1-line change backported from upstream, explicitly
    closing a dialog instead of trying to trigger its destructor
    prematurely) so it seems low-risk; it's hard to see how it could cause a regression worse than the issue it's fixing.

    [ Checklist ]
    [x] all changes are documented in the d/changelog
    [x] I reviewed all changes and I approve them
    [x] attach debdiff against the package in testing

    unblock polari/46.0-5

    diffstat for polari-46.0 polari-46.0

    debian/changelog | 7 +++++++
    debian/patches/319.patch | 27 +++++++++++++++++++++++++++
    debian/patches/series | 1 +
    src/joinDialog.js | 2 +-
    4 files changed, 36 insertions(+), 1 deletion(-)

    diff -Nru polari-46.0/debian/changelog polari-46.0/debian/changelog
    --- polari-46.0/debian/changelog 2025-05-03 17:12:03.000000000 +0100
    +++ polari-46.0/debian/changelog 2025-07-24 18:49:57.000000000 +0100
    @@ -1,3 +1,10 @@
    +polari (46.0-5) unstable; urgency=medium
    +
    + * Team upload
    + * patch: fix crash when closing dialog. Closes: #1095989.
    +
    + -- J�r�my Lal <[email protected]> Thu, 24 Jul 2025 19:49:57 +0200
    +
    polari (46.0-4) unstable; urgency=medium

    * Team upload
    diff -Nru polari-46.0/debian/patches/319.patch polari-46.0/debian/patches/319.patch
    --- polari-46.0/debian/patches/319.patch 1970-01-01 01:00:00.000000000 +0100
    +++ polari-46.0/debian/patches/319.patch 2025-07-24 18:49:57.000000000 +0100
    @@ -0,0 +1,27 @@
    +From 56544fe9c036c8a0e6f4990054730627c32bb561 Mon Sep 17 00:00:00 2001
    +From: =?UTF-8?q?Ball=C3=B3=20Gy=C3=B6rgy?= <[email protected]>
    +Date: Fri, 30 Aug 2024 14:12:58 +0000
    +Subject: [PATCH] joinDialog: Fix closing the dialog
    +
    +Closes: https://gitlab.gnome.org/GNOME/polari/-/issues/232
    +Part-of: <https://gitlab.gnome.org/GNOME/po
  • From =?UTF-8?B?SsOpcsOpbXkgTGFs?=@21:1/5 to All on Mon Jul 28 12:10:02 2025
    XPost: linux.debian.devel.release

    Le lun. 28 juil. 2025 à 12:01, Simon McVittie <[email protected]> a écrit :

    Package: release.debian.org
    Severity: normal
    X-Debbugs-Cc: [email protected], [email protected]
    Control: affects -1 + src:polari
    User: [email protected]
    Usertags: unblock

    Please consider unblocking package polari.

    [ Reason ]
    Backport an upstream patch fixing ability to join a channel: #1095989 (https://gitlab.gnome.org/GNOME/polari/-/issues/232 upstream)

    [ Impact ]
    If not fixed, the UI becomes unresponsive when joining a channel.

    [ Tests ]
    I haven't tested this (I don't use this IRC client myself) but
    presumably the uploader, Jérémy Lal, did. (Jérémy, please could you follow up here with details of tests you did?)


    Yes, I can reproduce the bug, and once the patch is applied,
    the bug goes away (adding a channel no longer freezes the UI).

    I think it is safe to unblock.



    [ Risks ]
    Not a key package, but it used to be pulled in by GNOME metapackages
    (before 2020) and might still be present on older installations.

    The impact/visibility of the issue fixed here suggests that few developers are using this package regularly. But the fix is simple and
    narrowly-targeted (a 1-line change backported from upstream, explicitly closing a dialog instead of trying to trigger its destructor
    prematurely) so it seems low-risk; it's hard to see how it could cause a regression worse than the issue it's fixing.

    [ Checklist ]
    [x] all changes are documented in the d/changelog
    [x] I reviewed all changes and I approve them
    [x] attach debdiff against the package in testing

    unblock polari/46.0-5


    <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Le lun. 28 juil. 2025 à 12:01, Simon McVittie &lt;<a href="mailto:[email protected]">[email protected]</a>&gt; a écrit :<br></
    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Package: <a href="http://release.debian.org" rel="noreferrer" target="_blank">release.debian.org</a><br>
    Severity: normal<br>
    X-Debbugs-Cc: <a href="mailto:[email protected]" target="_blank">[email protected]</a>, <a href="mailto:[email protected]" target="_blank">[email protected]</a><br>
    Control: affects -1 + src:polari<br>
    User: <a href="mailto:[email protected]" target="_blank">[email protected]</a><br>
    Usertags: unblock<br>

    Please consider unblocking package polari.<br>

    [ Reason ]<br>
    Backport an upstream patch fixing ability to join a channel: #1095989 <br>
    (<a href="https://gitlab.gnome.org/GNOME/polari/-/issues/232" rel="noreferrer" target="_blank">https://gitlab.gnome.org/GNOME/polari/-/issues/232</a> upstream)<br>

    [ Impact ]<br>
    If not fixed, the UI becomes unresponsive when joining a channel.<br>

    [ Tests ]<br>
    I haven&#39;t tested this (I don&#39;t use this IRC client myself) but <br> presumably the uploader, Jérémy Lal, did. (Jérémy, please could you <br> follow up here with details of tests you did?)<br></blockquote><div><br></div><div>Yes, I can reproduce the bug, and once the patch is applied,</div><div>the bug goes away (adding a channel no longer freezes the UI).</div><div><br></div><div>I think it
    is safe to unblock.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">

    [ Risks ]<br>
    Not a key package, but it used to be pulled in by GNOME metapackages <br> (before 2020) and might still be present on older installations.<br>

    The impact/visibility of the issue fixed here suggests that few developers <br> are using this package regularly. But the fix is simple and <br> narrowly-targeted (a 1-line change backported from upstream, explicitly <br> closing a dialog instead of trying to trigger its destructor <br>
    prematurely) so it seems low-risk; it&#39;s hard to see how it could cause a <br>
    regression worse than the issue it&#39;s fixing.<br>

    [ Checklist ]<br>
      [x] all changes are documented in the d/changelog<br>
      [x] I reviewed all changes and I approve them<br>
      [x] attach debdiff against the package in testing<br>

    unblock polari/46.0-5<br>
    </blockquote></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)