• Bug#703163: Fixed in Git but minor question

    From Andreas Tille@21:1/5 to All on Fri Jul 25 11:10:01 2025
    Control: tags -1 pending
    Thanks

    Hi,

    since you agreed in the Github issue[1] I migrated the packaging for laptop-mode-tools to Salsa. I think I fixed this bug in Git[2] and
    found the following differences in the resulting binary:

    $ debdiff laptop-mode-tools_1.74-1.4_all.deb ../laptop-mode-tools_1.74-2_all.deb
    [The following lists of changes regard files as different if they have different names, permissions or owners.]

    Files in second .deb but not in first
    -------------------------------------
    -rw-r--r-- root/root /etc/laptop-mode/lm-profiler.conf
    lrwxrwxrwx root/root /etc/power/event.d/laptop-mode -> ../scripts.d/laptop-mode

    Files in first .deb but not in second
    -------------------------------------
    -rw-r--r-- root/root /usr/share/lintian/overrides/laptop-mode-tools -rwxr-xr-x root/root /etc/power/event.d/laptop-mode

    Control files: lines which differ (wdiff format) ------------------------------------------------
    Depends: [-lsb-base (>= 3.0-10), util-linux (>= 2.13),-] {+lsb-release,+} psmisc
    Installed-Size: [-392-] {+391+}
    {+Pre-Depends: init-system-helpers (>= 1.54~)+}
    Version: [-1.74-1.4-] {+1.74-2+}


    The only relevant part here is:

    new:
    lrwxrwxrwx root/root /etc/power/event.d/laptop-mode -> ../scripts.d/laptop-mode

    old:
    -rwxr-xr-x root/root /etc/power/event.d/laptop-mode


    which boils down to the following diff inside the upstream source:


    laptop-mode-tools(master) $ diff -u etc/power/event.d/laptop-mode etc/power/scripts.d/laptop-mode
    --- etc/power/event.d/laptop-mode 2025-07-25 07:45:31.913904502 +0200
    +++ etc/power/scripts.d/laptop-mode 2025-07-25 07:45:31.913904502 +0200
    @@ -27,6 +27,9 @@
    performance)
    $LMODE "stop"
    ;;
    + resume)
    + $LMODE "auto" "force"
    + ;;
    esac
    elif [ -x logger ]; then
    logger -p daemon.error -t laptop-mode "Laptop-mode support missing in kernel."


    I think this is an intended change inside install.sh and the other
    laptop-mode file might be just some regression due to using some
    competing installer procedure in d/rules in the old package. In any
    case I would like to catch your attraction onto this matter since you
    are upstream as well.

    Kind regards
    Andreas.

    [1] https://github.com/rickysarraf/laptop-mode-tools/issues/215#issuecomment-3095553605
    [2] https://salsa.debian.org/debian/laptop-mode-tools/-/commit/8e9c80f7c0e20e055fe88bae18d041b5ff3f13