• Bug#1109673: fix for #1108526 made test suite flaky

    From Joey Hess@21:1/5 to All on Mon Jul 21 20:30:01 2025
    --iAbhCWh8B76qbJ9H
    Content-Type: text/plain; charset=us-ascii
    Content-Disposition: inline
    Content-Transfer-Encoding: quoted-printable

    Package: git-annex
    Version: 10.20250416-2
    Severity: normal

    Unfortunately, the patch used to fix #1108526 in git-annex causes its
    test suite to fail about 1 run in 10 or so. And there is new buggy
    behavior in some circumstances.

    See https://git-annex.branchable.com/bugs/flaky_test_failure_add_dup/
    for details and analysis.

    The attached patch applied on top of the fix your previously cherry
    picked will fix this. (It's commit
    cf449837ea9ab7687d8a157f21cad31ddf5bbfb6 in git-annex)

    --
    see shy jo

    --iAbhCWh8B76qbJ9H
    Content-Type: text/x-diff; charset=us-ascii
    Content-Disposition: attachment; filename="git-annex.patch" Content-Transfer-Encoding: quoted-printable

    diff --git a/Database/Keys.hs b/Database/Keys.hs
    index 98a1db9053..d3fce7bbd8 100644
    --- a/Database/Keys.hs
    +++ b/Database/Keys.hs
    @@ -260,7 +260,7 @@ isInodeKnown i s = or <$> runReaderIO ContentTable
    - is an associated file.
    -}
    reconcileStaged :: Bool -> H.DbQueue -> Annex DbTablesChanged
    -reconcileStaged dbisnew qh = ifM notneeded
    +reconcileStaged dbisnew qh = ifM isBareRepo
    ( return mempty
    , do
    gitindex <- inRepo currentIndexFile
    @@ -299,12 +299,12 @@ reconcileStaged dbisnew qh = ifM notneeded
    inRepo $ update' lastindexref newtree
    fastDebug "Database.Keys" "reconcileStaged end"
    return (DbTablesChanged True True)
    - -- git write-tree will fail if the index is locked or when there is
    - -- a merge conflict. To get up-to-date with the current index,
    - -- diff --staged with the ol
  • From Joey Hess@21:1/5 to Sean Whitton on Thu Jul 31 18:00:01 2025
    Sean Whitton wrote:
    How bad is the buggy behaviour? We are too late for trixie unless it's critical, I think.

    I think the bug is fairly unlikely to trigger. And git-annex fsck will
    correct the problem later.

    It does seem unfortunate timing that git 2.50 made it into testing so
    close to a freeze that there was less than a month to fix integration
    problems with it.

    --
    see shy jo

    -----BEGIN PGP SIGNATURE-----

    iQIzBAABCgAdFiEEKKUAw1IH6rcvbA8l2xLbD/BfjzgFAmiLjlMACgkQ2xLbD/Bf jzjJsw/+KoPH2LUeN08gvpgPDD0ykBCP6v8DhLdQFEaJOEw81wInPYDnZk1CafEu hG1sVKLQWiYzfP7qMBFR/TZfWeWto+Z164gUeFZhRk2O7yH3HefYbeFOTyttSsQx EDV311/CCiZct30CDHGSmOvbQjiK5SRYK7LRGyy6YR6p3DuVTlju6pDXFvvfvu5Z YBXs43htcHv5zsepLA28lfaIO9FZDaIsxB1S0R30px8xOmYshm8ZMDAecYlX8y9Z w5A0oc5ewCPK1iNVsO1a8See4eeZS88omQJP1Nwi9WERAx/APMm8v8VAhDsgHoHA u1ZD7n2VrdRAi3VHSL9rPhDjSgimvpNQYPgh+OpjU3GAe3UQnRGnpLrHEqsd0eAT 1M/y2mhiCxZC1rIzmtrNTkUNO3zvOSESqJRMkO5JcCotShjBcgOLf5Ju2tsFRS55 dTPgoGyxbTVcTBOWYA4yDvu5yhNNXW2UxAaj4pi3vA2mTW4WefkJweJOzZOzZBbk 6bxwwFvKC5Xk+G6VOOtwv1bFPeZ4I6d3416tM7P0MISWinZTDazTPGsq+iTz4wj+ 4bdNY2TXvh5CbOMMEkjB884lCBy8YgyHBsED0jE9/wST7deQblxg+D6KE0C7z2Ff npJCHS6q+OnUqACdQoDm502Evg6JyCUrTz9IcVrIDcYNsi3/Hx4=
    =OW8p
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Sean Whitton@21:1/5 to Joey Hess on Sun Aug 3 15:00:01 2025
    Hello,

    On Thu 31 Jul 2025 at 11:40am -04, Joey Hess wrote:

    Sean Whitton wrote:
    How bad is the buggy behaviour? We are too late for trixie unless it's
    critical, I think.

    I think the bug is fairly unlikely to trigger. And git-annex fsck will correct the problem later.

    Okay, thanks.

    It does seem unfortunate timing that git 2.50 made it into testing so
    close to a freeze that there was less than a month to fix integration problems with it.

    Yeah.

    --
    Sean Whitton

    --=-=-Content-Type: application/pgp-signature; name="signature.asc"

    -----BEGIN PGP SIGNATURE-----

    iQJNBAEBCgA3FiEEm5FwB64DDjbk/CSLaVt65L8GYkAFAmiPWzYZHHNwd2hpdHRv bkBzcHdoaXR0b24ubmFtZQAKCRBpW3rkvwZiQA/LD/4yJ1YyMlO7tlCA32owfjGH kbz/+t8W8asC46NM9NZmp6xJ5jF2IRbuEHT43XQqfGrP/Tm31pWGEntwBTFp9vC5 2uAoW95xvIvl5yzBtDCXW1xVP+22KXkRBa0O5gVI6yIFnDDvwhsOgGk7oe3zuUKy 8UhJ7FW2u4WmI232ZetXStswQEAyIjcLemDiiaj8yVsWAmBQbjtJnMUmwNFnE6hT YzoPHUCcYE4tv9OLba8tdP4vFfOT7Ay3wRh0+PDbADBn7TyQU5YfS0A8CEI094um szjHdCNNHrcUJDP7zfPYq05AtCR22ywjx3v8W5UOm1QO2Ev27nfEbIJe1+aXQ8pd CKusqoUUKhaEo3uoEBe2F3C4CvoB6OgkDVASQxwtOpfX8Jqu3U4AH2dmA8y7SRAT jxZYJSwzS2a08TRA1GE+aeTfTZbnnxt/PctztrLuzCpiJwzVMKJaVo6tFGymG/fC TaD+FJFm1kz72GnVQDHNZRmUY0M59b7b/URQNZgYV0y3CbJvLLwF71cqZdePHgSb DT2UMKlaNWl6z4MmjOg4evblBzz7hxSO+MszXVFEzVVjMZ79W3+OyGelpsXpiffG 3Sj2yD/2X+OVGNRfxHO5flHl+RWX9Xu5/0LO1HzHRfPIgkKZXL8KBATY9UpFoAzb KhcYR6BsaW9WvLB0Vn4DjA==pWmz
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Us