XPost: linux.debian.devel.release

Package: release.debian.org
Severity: normal
X-Debbugs-Cc: [email protected]
Control: affects -1 + src:gnome-terminal
User: [email protected]
Usertags: unblock

I would like this to be considered for Debian 13.0 if possible, but if
we're too late for that, it can be deferred to 13.1 by converting this
request into a trixie-pu request.

[ Reason ]

Upstream bugfix release, plus a patch cherry-picked from upstream to
fix #1109086.

[ Impact ]

trixie's current gnome-terminal has undefined behaviour during startup
due to a missing initialization, which practice leads to intermittent
failure to start if given "--wait" and a lot of other arguments.

It also uses a legacy icon name which is no longer available in default
GNOME installations (#1109086) leading to use of an unsightly "broken
image" icon instead of the intended checkmark.

[ Tests ]

Manually tested with and without command-line arguments.

Also manually tested #1109086 by creating a second "profile" and
swapping the default between the two, which works fine and displays an appropriate icon now.

[ Risks ]

Key package in our default desktop environment, and will likely be used
by any new GNOME user who needs to debug an unrelated issue.

The changes are narrowly-targeted and proportionate to the issues fixed.

[ Checklist ]

[x] all changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in testing

[ Other info ]

The change in subprojects/vte/ can be ignored, we don't use that copy in Debian. Our vte2.91 package already had that bug fix cherry-picked.

unblock gnome-terminal/3.56.2-2

diffstat for gnome-terminal-3.56.1 gnome-terminal-3.56.2

ChangeLog | 19 ++++++++++++-------
debian/.gitignore | 1 +
debian/changelog | 24 ++++++++++++++++++++++++
debian/patches/prefs-Replace-icon.patch | 26 ++++++++++++++++++++++++++
debian/patches/series | 1 +
meson.build | 2 +-
src/terminal-options.cc | 1 +
src/terminal-options.hh | 2 --
src/terminal-prefs.cc | 2 +-
subprojects/vte/meson.build | 2 +-
subprojects/vte/src/vteseq.cc | 2 +-
11 files changed, 69 insertions(+), 13 deletions(-)

diff -Nru gnome-terminal-3.56.1/ChangeLog gnome-terminal-3.56.2/ChangeLog
--- gnome-terminal-3.56.1/ChangeLog 2025-04-12 22:44:49.635889300 +0100
+++ gnome-terminal-3.56.2/ChangeLog 2025-05-24 20:12:16.107137000 +0100
@@ -1,8 +1,13 @@
-commit e0e5623d52555491da2227949978c5326e947a37
-Author: Hugo Carvalho <[email protected]>
-Date: Sat Mar 29 15:21:05 2025 +0000
+commit 941d51d151c0e25b285ffe98ad4a38b4ce5dda69
+Author: Christian Persch <[email protected]>
+Date: Sat May 3 12:30:36 2025 +0200

- Update Portuguese translation
+ client: legacy: Initialise --wait to false
+
+ Fixes: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/8122
+ (cherry picked from commit 3056b8e862c07f2fb2b02e3e634e153449cb3f76)
+ (cherry picked from commit 1a26d534e214dff9c66644d695128e0f3e5f9371)
+ (cherry picked from commit 98b798d25ac23a200ffba6377dd0d49a38788fa7)

.dir-locals.el | 15 +
.gitlab-ci.yml | 81 +
@@ -255,8 +260,8 @@
src/terminal-notebook-menu.ui