Hi Maytham,
Thanks for the review.
On 7/8/25 9:31 AM, Maytham Alsudany wrote:
- debian/control: The source package and the binary package names don't
match; the source package uses "d++" whereas the binary package uses
"dpp". I reckon it would be better to choose one and stick with it.
I did this because the name of the project is D++, but the actual lib
name is dpp because not every system plays nicely with the + character.
I suppose it would make sense to change the source package to "dpp"
since the binary packages also use this name, and it avoids confusion.
- debian/patches/soversion.patch: As per the discussion at [1],
should this be removed entirely or switched to minor version
increments?
I would prefer not to do this, as it would mean uploading to NEW very
often and I would need to get a DD to do that every time as I am a DM.
However I am willing to do this if it makes more sense for everyone.
- The docs from the libdpp-doc package are unusable; it looks like the
formatting was lost somewhere. For instance, the logo covers the
entire screen and I cannot access anything from the navigation bar.
I just tested this, and it looks like it happens both with and without
my local CSS patch. So the upstream's local doc build support must be
broken in a big way; I'll look into it.
- debian/patches/doc-local-web-source.patch: Instead of removing the
YouTube video entirely, you can still provide a link to it.
Done.
- debian/control: This isn't mission critical, but the last line in the
descriptions of the -dev and -doc packages (This package contains...)
should be separated by a period (".") on its own line to avoid it
wrapping with the rest of the description.
Done.
- Your repo has both a debian/unstable and debian/master branch. You
should choose only one i.e. your "upload to unstable" commit should be
pushed straight to debian/master, having a separate branch for uploads
is not necessary.
I don't like having "unstable" in my changelog on the master branch
unless the package is actually in unstable. But that's in the changelog
for my mentors upload so you can send it right to NEW without editing.
When this package actually is in unstable, that part will be in master.
- Since the trixie freeze is still ongoing, you'll want to target the
upload of this package to experimental to avoid interfering with the
new Debian release.
As Mathias said, it doesn't matter since it still needs to go to NEW.
I have addressed these points in a new upload to mentors, which also has
a new minor version from upstream. Thanks again for the in-depth review!
--
Ben Westover
LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0NCg0Kd3NGNUJBQUJDQUFqRmlFRU9HbmFjcVJo ZFU2ZU5tdEZ3eEhGOVU2SnRwZ0ZBbWh3RmhBRkF3QUFBQUFBQ2drUXd4SEY5VTZKdHBpcA0KSncv K0lPZkc3czBnVllka1k2eEJMSnNXR0ZyNHd6dTBGNmdiYUV5ZWxZVUd2U09NbzVldzFVY2kvVkJU bnIrZU1BSmFaN0hUNnE2cQ0KZHNWTGUwMHB4UUp0S0ZLSWRUVENuVDZ5OXJDSGppUUpwSXRwdmdF ZWs5ZEFsaVhSd01pZmVaZ3ZXNUxyWHgzMWZnenYwWVZTczMyag0KcFlrQVZOejVCMHY1dXRUUGFz bzYva3RpRnIyZWh4MWhkLytndzZZaktQWTl6RkszenBxd3c3Wno3QWw0Wjd4VFVtdUZBQjN0Mis2 UA0KZktxZzVETjdQcDIwSkhpY0FDbG1wcVNhcFJNZXY5a2xPU2pMWC9LbnEvL0VrK0s2MFlERHBl UW1ZT3RGR280VHFCbEtFb0NOVTlRUg0KQ2JyVFEvckNKbzlqQlFGd05JTXRnUUF6SGpEbU9yekZi TytxSngyc0IyYlBSZlNsWkgrYlZydW5ra2FrNlpIa3o4cGl4QU5YdGJpLw0KU0o3NG5LT1ZVQjZm Qlo5N3JSVGp2V2Q0cXJqY1dyM1N2NHQ0aFNDR29qanRPWXlHbm96TkZQaGxUYlpkTE5DSHVuc1JH S3BXakYvLw0KYmthUlFDSHdKY0crUTBHblNZakE4V0VxRWF1Y3BUUEFwRGFMazlzeHJzOGE0ZjJ6 TlkzTTBRekNkTFg5aTFzZngrNlJuZzdJdVhxWA0KQ2xNbmE5MkFwZ1A4UFA1b2syMjRaQ2FhSWh6 cWJ5cjB3TGtzdDJoY2xHMmJReG9DVjVIN20wcUhrbU1jSkZ2V0xuWC8vNTRLYnM2UQ0KenlCNWR6 aWMwcEVOU2RNSzA5QVQ4MUpXVXVzUXI1Vm4yOWpKL3FMeGFmWjZLc3VDWTV4WTluREZZQktkV2xV a0ZqUitUdk1va2VySQ0KMlhBPQ0KPS9QWDUNCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQ0K
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)