From: [email protected]

Package: hardware-monitor
Severity: normal
Tags: patch

When building 'hardware-monitor' with gcc-3.4 I get the following error:

x86_64-linux-g++ -DHAVE_CONFIG_H -I. -I. -I.. -DHARDWARE_MONITOR_GLADEDIR=\""/usr/share/hardware-monitor/glade/"\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DGNOMEICONDIR=\""/usr/share/pixmaps"\" -DSENSORS_CONF_FILE=\""/etc/sensors.conf"\" -g -O2 -
DXTHREADS -DORBIT2=1 -pthread -I/usr/include/libgnomeuimm-2.6 -I/usr/lib/libgnomeuimm-2.6/include -I/usr/include/libgnomemm-2.6 -I/usr/lib/libgnomemm-2.6/include -I/usr/include/libgnomecanvasmm-2.6 -I/usr/lib/libgnomecanvasmm-2.6/include -I/usr/include/
gconfmm-2.6 -I/usr/lib/gconfmm-2.6/include -I/usr/include/libglademm-2.4 -I/usr/lib/libglademm-2.4/include -I/usr/include/libgnomeui-2.0 -I/usr/include/gnome-vfsmm-2.6 -I/usr/lib/gnome-vfsmm-2.6/include -I/usr/include/gtkmm-2.4 -I/usr/lib/gtkmm-2.4/
include -I/usr/include/libgnome-2.0 -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/gdkmm-2.4 -I/usr/lib/gdkmm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/include/atkmm-1.6 -I/usr/include/gtk-2.0 -I/usr/include/
sigc++-2.0 -I/usr/lib/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/include/orbit-2.0 -I/usr/include/
libbonobo-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/
include/libbonoboui-2.0 -I/usr/include/panel-2.0 -I/usr/include/libgtop-2.0 -Wall -O3 -c preferences-window.cpp
preferences-window.cpp: In member function `Monitor* PreferencesWindow::run_choose_monitor_window(const Glib::ustring&)':
preferences-window.cpp:593: error: no match for 'operator*' in '*window' make[3]: *** [preferences-window.o] Error 1
make[3]: Leaving directory `/hardware-monitor-1.2/src'

With the attached patch 'hardware-monitor' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp ./src/preferences-window.cpp
--- ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp 2004-07-10 12:07:22.000000000 +0200
+++ ./src/preferences-window.cpp 2004-08-18 14:18:38.285186057 +0200
@@ -590,7 +590,7 @@

Monitor *PreferencesWindow::run_choose_monitor_window(const Glib::ustring &str)
{
- ChooseMonitorWindow window(applet.get_icon(), *window);
+ ChooseMonitorWindow window(applet.get_icon(), *this->window);

return window.run(applet.get_gconf_client(), str);
}


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

On Wed, Aug 18, 2004 at 02:24:48PM +0200, Andreas Jochens wrote:

Package: hardware-monitor
Severity: normal
Tags: patch

Ok, thanks.

When building 'hardware-monitor' with gcc-3.4 I get the following error:

x86_64-linux-g++ -DHAVE_CONFIG_H -I. -I. -I.. -DHARDWARE_MONITOR_GLADEDIR=\""/usr/share/hardware-monitor/glade/"\" -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DGNOMEICONDIR=\""/usr/share/pixmaps"\" -DSENSORS_CONF_FILE=\""/etc/sensors.conf"\" -g -O2 -

DXTHREADS -DORBIT2=1 -pthread -I/usr/include/libgnomeuimm-2.6 -I/usr/lib/libgnomeuimm-2.6/include -I/usr/include/libgnomemm-2.6 -I/usr/lib/libgnomemm-2.6/include -I/usr/include/libgnomecanvasmm-2.6 -I/usr/lib/libgnomecanvasmm-2.6/include -I/usr/include/
gconfmm-2.6 -I/usr/lib/gconfmm-2.6/include -I/usr/include/libglademm-2.4 -I/usr/lib/libglademm-2.4/include -I/usr/include/libgnomeui-2.0 -I/usr/include/gnome-vfsmm-2.6 -I/usr/lib/gnome-vfsmm-2.6/include -I/usr/include/gtkmm-2.4 -I/usr/lib/gtkmm-2.4/
include -I/usr/include/libgnome-2.0 -I/usr/include/glibmm-2.4 -I/usr/lib/glibmm-2.4/include -I/usr/include/gdkmm-2.4 -I/usr/lib/gdkmm-2.4/include -I/usr/include/pangomm-1.4 -I/usr/include/atkmm-1.6 -I/usr/include/gtk-2.0 -I/usr/include/sigc++-2.0 -I/usr/
lib/sigc++-2.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/lib/gtk-2.0/include -I/usr/X11R6/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/atk-1.0 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/
usr/include/gconf/2 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/
libbonoboui-2.0 -I/usr/include/panel-2.0 -I/usr/include/libgtop-2.0 -Wall -O3 -c preferences-window.cpp

preferences-window.cpp: In member function `Monitor* PreferencesWindow::run_choose_monitor_window(const Glib::ustring&)':
preferences-window.cpp:593: error: no match for 'operator*' in '*window' make[3]: *** [preferences-window.o] Error 1
make[3]: Leaving directory `/hardware-monitor-1.2/src'

With the attached patch 'hardware-monitor' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp ./src/preferences-window.cpp
--- ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp 2004-07-10 12:07:22.000000000 +0200
+++ ./src/preferences-window.cpp 2004-08-18 14:18:38.285186057 +0200
@@ -590,7 +590,7 @@

Monitor *PreferencesWindow::run_choose_monitor_window(const Glib::ustring &str)
{
- ChooseMonitorWindow window(applet.get_icon(), *window);
+ ChooseMonitorWindow window(applet.get_icon(), *this->window);

return window.run(applet.get_gconf_client(), str);
}

Ole, will you integrate it also upstream ?

Friendly,

Sven Luther

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

Sven Luther <[email protected]> writes:

[...]

diff -urN ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp ./src/preferences-window.cpp
--- ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp 2004-07-10 12:07:22.000000000 +0200
+++ ./src/preferences-window.cpp 2004-08-18 14:18:38.285186057 +0200
@@ -590,7 +590,7 @@

Monitor *PreferencesWindow::run_choose_monitor_window(const Glib::ustring &str)
{
- ChooseMonitorWindow window(applet.get_icon(), *window);
+ ChooseMonitorWindow window(applet.get_icon(), *this->window);

return window.run(applet.get_gconf_client(), str);
}

Ole, will you integrate it also upstream ?

Yes, I've done that now. Silly bug. I've got a bunch of translation
updates, so I might make a new release soon.

Thanks for reporting it!

--
Ole Laursen
http://www.cs.aau.dk/~olau/


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

On Wed, Aug 18, 2004 at 08:06:55PM +0200, Ole Laursen wrote:

Sven Luther <[email protected]> writes:

[...]

diff -urN ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp ./src/preferences-window.cpp
--- ../tmp-orig/hardware-monitor-1.2/src/preferences-window.cpp 2004-07-10 12:07:22.000000000 +0200
+++ ./src/preferences-window.cpp 2004-08-18 14:18:38.285186057 +0200
@@ -590,7 +590,7 @@

Monitor *PreferencesWindow::run_choose_monitor_window(const Glib::ustring &str)
{
- ChooseMonitorWindow window(applet.get_icon(), *window);
+ ChooseMonitorWindow window(applet.get_icon(), *this->window);

return window.run(applet.get_gconf_client(), str);
}

Ole, will you integrate it also upstream ?

Yes, I've done that now. Silly bug. I've got a bunch of translation
updates, so I might make a new release soon.

Too late for sarge probably though, unless it happens in the very next days.

Friendly,

Sven Luther


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)