• Bug#266569: rsnapshot doesn't give useful info on errors

    From Peter Palfrader@1:229/2 to All on Wed Aug 18 12:30:14 2004
    From: [email protected]

    Package: rsnapshot
    Version: 1.1.6-5
    Severity: normal
    Tags: patch

    Consider this logfile:

    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-user.conf hourly: started
    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-user.conf hourly: completed successfully
    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-foto.conf hourly: started
    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-foto.conf hourly: completed successfully
    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-privat.conf hourly: started
    [18/Aug/2004:12:00:51] /usr/bin/rsnapshot -c /home/backup/rsnapshot-confs/hades-dibral-privat.conf hourly: completed successfully
    [18/Aug/2004:12:04:01] ERROR: rsnapshot refuses to create snapshot_root when no_create_root is enabled
    [18/Aug/2004:12:06:55] ERROR: rsnapshot refuses to create snapshot_root when no_create_root is enabled

    You can clearly see that the ERROR line is less than helpful. It should print which config file it used etc.

    Peter

    --- /usr/bin/rsnapshot 2004-08-18 12:06:19.000000000 +0200
    +++ rsnapshot 2004-08-18 12:06:26.000000000 +0200
    @@ -1414,7 +1414,7 @@

    # print to STDERR
    if ((!defined($verbose)) or ($level <= $verbose)) {
    - print STDERR 'ERROR: ', $str, "\n";
    + print STDERR "$run_string: ERROR: ", $str, "\n";
    }

    # write to log
    @@ -1492,7 +1492,7 @@

    chomp($str);

    - $str = 'ERROR: ' . $str;
    + $str = "$run_string: ERROR " . $str;
    log_msg($str, $level);
    }

    @@ -1550,7 +1550,7 @@
    # this run is no longer perfect since we have an error
    raise_error();

    - return syslog_msg("ERROR: $msg", 'user', 'err');
    + return syslog_msg("$run_string: ERROR $msg", 'user', 'err');
    }

    # sets exit code for at least a warning

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)