From: [email protected]

Package: shaketracker
Severity: normal
Tags: patch

When building 'shaketracker' with gcc-3.4 I get the following error:

In file included from effect_table.h:21,
from player_interface.h:22,
from player.h:22,
from timer.h:22,
from timer.cpp:19:
effect.h: In member function `virtual void Effect_Vibrato::process(int, int)': effect.h:106: warning: passing `float' for converting 2 of `virtual void Effect_Vibrato::set_value(int, int)'
g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE=\"shaketracker\" -DVERSION=\"0.4.6\" -I. -I. -I/usr/lib/sigc++-1.0/include -I/usr/include/sigc++-1.0 -I/usr/lib/gtkmm/
include -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/lib/sigc++-1.0/include -I/usr/include/sigc++-1.0 -DPOSIX_ENABLED -DALSA_ENABLED -g3 -c devicelist.cpp
devicelist.cpp: In member function `bool User_Device_List::load_device_from_reader(File_Reader*)':
devicelist.cpp:77: error: no matching function for call to `File_Reader::get_byte(Uint8)'
file_reader.h:58: note: candidates are: void File_Reader::get_byte(Uint8&) devicelist.cpp:78: error: no matching function for call to `File_Reader::get_byte(Uint8)'
file_reader.h:58: note: candidates are: void File_Reader::get_byte(Uint8&) devicelist.cpp:79: error: no matching function for call to `File_Reader::get_byte(Uint8)'
file_reader.h:58: note: candidates are: void File_Reader::get_byte(Uint8&) make[2]: *** [devicelist.o] Error 1
make[2]: Leaving directory `/shaketracker-0.4.6/build-tree/shaketracker-0.4.6/trackercore'

With the attached patch 'shaketracker' can be compiled using gcc-3.4.

Regards
Andreas Jochens

diff -urN ../tmp-orig/shaketracker-0.4.6/debian/patches/05_g++3.4_fixes.patch ./debian/patches/05_g++3.4_fixes.patch
--- ../tmp-orig/shaketracker-0.4.6/debian/patches/05_g++3.4_fixes.patch 1970-01-01 01:00:00.000000000 +0100
+++ ./debian/patches/05_g++3.4_fixes.patch 2004-08-17 19:52:52.870222209 +0200
@@ -0,0 +1,131 @@
+diff -urN tmp/interface_gtk/interface_update.cpp shaketracker-0.4.6/interface_gtk/interface_update.cpp
+--- tmp/interface_gtk/interface_update.cpp 2002-01-01 19:53:40.000000000 +0100
++++ shaketracker-0.4.6/interface_gtk/interface_update.cpp 2004-08-17 19:46:08.006770809 +0200
+@@ -23,7 +23,7 @@
+ char *tmpchrstring;
+ unsigned int i;
+
+- (void*)tmpchrstring=malloc(sourcestring.length()+5);
++ tmpchrstring=(char*)malloc(sourcestring.length()+5);
+ tmpchrstring[0]='0'+number/100;
+ tmpchrstring[1]='0'+(number/10) % 10;
+ tmpchrstring[2]='0'+number%10;
+@@ -673,4 +673,4 @@
+
+ label_system_totaltracks->set_text(tmp_string);
+
+-}
+\ No newline at end of file
++}
+diff -urN tmp/interface_gtk/tracker.cpp shaketracker-0.4.6/interface_gtk/tracker.cpp
+--- tmp/interface_gtk/track