Package: synce-kde
Severity: normal
Tags: patch
When building 'synce-kde' with gcc-3.4 I get the following error:
g++ -DHAVE_CONFIG_H -I. -I../../../../raki/plugins/agsync -I../../.. -I../../../../raki -I../../../../raki/interfaces -I/usr/include/kde -I/usr/include/qt3 -I/usr/X11R6/include -DQT_THREAD_SUPPORT -D_REENTRANT -Wnon-virtual-dtor -Wno-long-long -Wundef -Wall -pedantic -W
-Wpointer-arith -Wmissing-prototypes -Wwrite-strings -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -DNDEBUG -DNO_DEBUG -O2 -fno-exceptions -fno-check-new -c
librakiagsync_la.all_cpp.cpp -MT librakiagsync_la.all_cpp.lo -MD -MP -MF .deps/librakiagsync_la.all_cpp.TPlo -DPIC cc1plus: warning: command line option "-Wmissing-prototypes" is valid for Ada/C/ObjC/Pascal but not for
C++ In file included from librakiagsync_la.all_cpp.cpp:3: ../../../../raki/plugins/agsync/agsyncfactory.cpp:56: error: extra `;' make[6]: *** [librakiagsync_la.all_cpp.lo] Error 1
make[6]: Leaving directory `/synce-kde-0.7.3/obj-x86_64-linux/raki/plugins/agsync'
With the attached patch 'synce-kde' can be compiled using gcc-3.4.
The attached patch also adds '-fPIC' to CXXFLAGS in debian/rules because otherwise the package does not compile on amd64 (and probably some other architectures).
Regards
Andreas Jochens
diff -urN ../tmp-orig/synce-kde-0.7.3/debian/rules ./debian/rules
--- ../tmp-orig/synce-kde-0.7.3/debian/rules 2004-08-17 08:34:02.564169905 +0200 +++ ./debian/rules 2004-08-17 08:27:10.940746177 +0200
@@ -63,7 +63,7 @@
# run configure with build tree $(objdir)
cd $(objdir) && \
- ../configure $(configkde) \
+ CXXFLAGS=-fPIC ../configure $(configkde) \
--with-distribution="$$version (`cat /etc/debian_version`)" \
--enable-mitshm --with-alsa --with-ipv6-lookup=auto \
$(FAST_MALLOC) $(XINERAMA)
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/plugins/agsync/agsyncfactory.cpp ./raki/plugins/agsync/agsyncfactory.cpp --- ../tmp-orig/synce-kde-0.7.3/raki/plugins/agsync/agsyncfactory.cpp 2003-06-2
6 01:28:20.000000000 +0200 +++
./raki/plugins/agsync/agsyncfactory.cpp 2004-08-17 08:25:22.775189841 +0200
@@ -53,6 +53,6 @@
{
return new AGSyncFactory();
}
-};
+}
#endif
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/plugins/kdeaddressbooksync/kdeaddressbooks
ync.h ./raki/plugins/kdeaddressbooksync/kdeaddressbooksync.h ---
../tmp-orig/synce-kde-0.7.3/raki/plugins/kdeaddressbooksync/kdeaddressbooks
ync.h 2004-01-19 23:13:00.000000000 +0100 +++
./raki/plugins/kdeaddressbooksync/kdeaddressbooksync.h 2004-08-17 08:28:51.821409985 +0200 @@ -38,7 +38,7 @@
class AddressBook;
class ResourceFile;
class Resource;
-};
+}
class KdeAddressBookSync : public RakiSyncPlugin
{
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/plugins/kdeaddressbooksync/kdeaddressbooks
yncfactory.cpp
./raki/plugins/kdeaddressbooksync/kdeaddressbooksyncfactory.cpp --- ../tmp-orig/synce-kde-0.7.3/raki/plugins/kdeaddressbooksync/kdeaddressbooks
yncfactory.cpp 2003-06-26 01:28:20.000000000 +0200 +++
./raki/plugins/kdeaddressbooksync/kdeaddressbooksyncfactory.cpp 2004-08-17
08:28:34.311071961 +0200 @@ -49,4 +49,4 @@
{
return new KdeAddressBookSyncFactory();
}
-};
+}
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/rakiworkerthread.cpp ./raki/rakiworkerthread.cpp --- ../tmp-orig/synce-kde-0.7.3/raki/rakiworkerthread.cpp 2003-10-19 00:41:09.000000000 +0200 +++ ./raki/rakiworkerthread.cpp 2004-08-17 08:31:55.434496553 +0200 @@ -47,7 +47,7 @@
void RakiWorkerThread::start(WorkerThreadInterface *wti, void (
- WorkerThreadInterface::*userRun)(QThread *thread, void *data = NULL), + WorkerThreadInterface::*userRun)(QThread *thread, void *data), void *data)
{
threadMutex.lock();
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/rakiworkerthread.h ./raki/rakiworkerthread.h --- ../tmp-orig/synce-kde-0.7.3/raki/rakiworkerthread.h 2003-10-12 13:15:15.000000000 +0200 +++ ./raki/rakiworkerthread.h 2004-08-17 08:33:11.260969177 +0200
@@ -52,8 +52,8 @@
public:
void run();
void start(WorkerThreadInterface *wti,
- void (WorkerThreadInterface::*userRun)(QThread *thread = NULL,
- void *data = NULL), void *data = NULL);
+ void (WorkerThreadInterface::*userRun)(QThread *thread,
+ void *data), void *data = NULL);
WorkerThreadInterface *getCurrentInterface();
void stop();
static bool running();
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/threadevent.cpp ./raki/threadevent.cpp ---
../tmp-orig/synce-kde-0.7.3/raki/threadevent.cpp 2004-03-31 01:58:48.000000000 +0200 +++ ./raki/threadevent.cpp 2004-08-17 08:31:01.297726593 +0200
@@ -30,7 +30,7 @@
ThreadEvent::ThreadEvent(WorkerThreadInterface *wti,
- void *(WorkerThreadInterface::*userEventMethode)(void *data =
NULL), + void *(WorkerThreadInterface::*userEventMethode)(void
*data), void *data) : QCustomEvent(QEvent::User)
{
this->wti = wti;
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/threadevent.h
./raki/threadevent.h ---
../tmp-orig/synce-kde-0.7.3/raki/threadevent.h 2003-10-12 12:45:06.000000000 +0200 +++ ./raki/threadevent.h 2004-08-17 08:29:45.918186025 +0200
@@ -43,7 +43,7 @@
{
public:
ThreadEvent(WorkerThreadInterface *wti,
- void *(WorkerThreadInterface::*userEventMethode)(void *data = 0), + void *(WorkerThreadInterface::*userEventMethode)(void *data), void *data);
void *(WorkerThreadInterface::*userEventMethode)(void *data = 0);
WorkerThreadInterface *wti;
diff -urN ../tmp-orig/synce-kde-0.7.3/raki/workerthreadinterface.cpp ./raki/workerthreadinterface.cpp --- ../tmp-orig/synce-kde-0.7.3/raki/workerthreadinterface.cpp 2004-03-31
| Sysop: | Keyop |
|---|---|
| Location: | Huddersfield, West Yorkshire, UK |
| Users: | 715 |
| Nodes: | 16 (3 / 13) |
| Uptime: | 43:10:10 |
| Calls: | 12,111 |
| Calls today: | 2 |
| Files: | 15,008 |
| Messages: | 6,518,439 |