From: [email protected]

I spoke to the upstream developers about this and they said this is a non-issue. Neither the regular nor applet slideshows recurse albums.
If there are no photos (e.g. in an album that only has subalbums),
there's nothing to see in the slideshow.

There's something really fishy here then because:
1) I have the button in my root album, which only contains sub-albums.
2) If I make the change I described, the slideshow is recursive.

--Jayen



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

reopen 265873
tags 265873 fixed-upstream
thanks

Jayen Ashar wrote:

Michael Schultheiss wrote:

I spoke to the upstream developers about this and they said this is a non-issue. Neither the regular nor applet slideshows recurse albums.
If there are no photos (e.g. in an album that only has subalbums),
there's nothing to see in the slideshow.

There's something really fishy here then because:
1) I have the button in my root album, which only contains sub-albums.
2) If I make the change I described, the slideshow is recursive.

--Jayen

I spoke to the upstream developers again and the person spoke to earlier
today overlooked the recursive_slideshow option. A fix will be included
in gallery 1.4.5.

--
----------------------------
Michael Schultheiss
E-mail: [email protected]


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

so does that mean the real fix should be to change albums.php to ((check
the recursive option and have visible items) or have visible photos) and
the same for view_album.php? maybe they could use a common function that
does this calculation and also checks if slideshows are enabled?

thanks,
jayen

On Mon, 16 Aug 2004, Michael Schultheiss wrote:

reopen 265873
tags 265873 fixed-upstream
thanks

Jayen Ashar wrote:

Michael Schultheiss wrote:

I spoke to the upstream developers about this and they said this is a non-issue. Neither the regular nor applet slideshows recurse albums.
If there are no photos (e.g. in an album that only has subalbums), there's nothing to see in the slideshow.

There's something really fishy here then because:
1) I have the button in my root album, which only contains sub-albums.
2) If I make the change I described, the slideshow is recursive.

--Jayen

I spoke to the upstream developers again and the person spoke to earlier today overlooked the recursive_slideshow option. A fix will be included
in gallery 1.4.5.

--
----------------------------
Michael Schultheiss
E-mail: [email protected]

--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)

From: [email protected]

Jayen Ashar wrote:

so does that mean the real fix should be to change albums.php to ((check
the recursive option and have visible items) or have visible photos) and
the same for view_album.php? maybe they could use a common function that does this calculation and also checks if slideshows are enabled?

The upstream fix was to view_album.php. If you have further
suggestions, I'd post them in the Suggestions and Feedback forum at http://gallery.menalto.com/index.php?name=PNphpBB2&file=viewforum&f=2

diff -u -d -r1.252 -r1.253
--- view_album.php 2 Aug 2004 11:05:44 -0000 1.252
+++ view_album.php 17 Aug 2004 01:34:15 -0000 1.253
@@ -461,7 +461,7 @@
}

$userCommands = '';
-if ($gallery->album->fields["slideshow_type"] != "off" && $numPhotos !=0) { +if ($gallery->album->fields["slideshow_type"] != "off" && ($numPhotos != 0 || ($numVisibleItems != 0 && $gallery->album->fields['slideshow_recursive'] == "yes"))) {
$userCommands .= "<a class=\"admin\" href=\"" .
makeGalleryUrl("slideshow.php",
array("set_albumName" => $albumName)) .


--
----------------------------
Michael Schultheiss
E-mail: [email protected]


--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

--- SoupGate-Win32 v1.05
* Origin: you cannot sedate... all the things you hate (1:229/2)