• Bug#265871: Samba 3.0.5 Printserver doesn't work with WinXP SP2

    From Markus Kolb@1:229/2 to All on Sun Aug 15 15:40:08 2004
    From: [email protected]

    Package: samba
    Version: 3.0.5-1
    Severity: grave

    It is a known change in the WinXP SP2 and Samba 3.0.6 release client 2
    is already patched.
    So I hope there will be a patched Debian package before Sarge becomes
    stable.

    Changes since 3.0.6rc1
    [...]
    o Gerald Carter <[email protected]>
    * BUG 1520: Work around bug in Windows XP SP2 RC2 where the
    client sends a FindNextPrintChangeNotify() request without
    previously sending a FindFirstPrintChangeNotify(). Return
    the same error code as Windows 2000 SP4.


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Steve Langasek@1:229/2 to Markus Kolb on Mon Aug 16 11:00:18 2004
    From: [email protected]

    severity 265871 important
    thanks

    I disagree that a workaround for a bug in a Windows release candidate is
    a bug that should delay the release of Samba with sarge.

    Regards,
    --
    Steve Langasek
    postmodern programmer

    On Sun, Aug 15, 2004 at 03:00:06PM +0200, Markus Kolb wrote:
    Package: samba
    Version: 3.0.5-1
    Severity: grave

    It is a known change in the WinXP SP2 and Samba 3.0.6 release client 2
    is already patched.
    So I hope there will be a patched Debian package before Sarge becomes stable.

    Changes since 3.0.6rc1
    [...]
    o Gerald Carter <[email protected]>
    * BUG 1520: Work around bug in Windows XP SP2 RC2 where the
    client sends a FindNextPrintChangeNotify() request without
    previously sending a FindFirstPrintChangeNotify(). Return
    the same error code as Windows 2000 SP4.

    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.2.4 (GNU/Linux)

    iD8DBQFBIHC5KN6ufymYLloRAuYsAJ9BqAldWhtYBW0vzebdN4Lw2+mFuQCgumKb 7xTdtdgKd5CqsloFkEUcg2M=
    =5N0o
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Markus Kolb@1:229/2 to Steve Langasek on Mon Aug 16 16:10:12 2004
    From: [email protected]

    Steve Langasek wrote:

    severity 265871 important
    thanks

    I disagree that a workaround for a bug in a Windows release candidate is
    a bug that should delay the release of Samba with sarge.

    Regards,

    It is not only in the Release Candidate of SP2.
    The bug is in the final Service Pack 2 of Windows XP, too.
    That's the problem. I've told that it is the Service Pack 2 and not any
    release candidate.
    MS won't repair it because there is no problem in MS only networks.
    Samba 3.0.5 is useless with WinXP SP 2 and printing.




    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Fabien Chevalier@1:229/2 to All on Mon Aug 16 19:40:10 2004
    From: [email protected]

    Le lundi 16 Ao�t 2004 14:48, Markus Kolb a �crit :
    Steve Langasek wrote:

    severity 265871 important
    thanks

    I disagree that a workaround for a bug in a Windows release candidate is
    a bug that should delay the release of Samba with sarge.

    Regards,

    It is not only in the Release Candidate of SP2.
    The bug is in the final Service Pack 2 of Windows XP, too.
    That's the problem. I've told that it is the Service Pack 2 and not any release candidate.
    MS won't repair it because there is no problem in MS only networks.
    Samba 3.0.5 is useless with WinXP SP 2 and printing.


    I would tend to agree with Markus on this point. I detail ny thoughts here : the whole purspose of Samba is to
    provide internetworking with Windows systems. As such it contains "workarounds" for numerous (mis?)features
    of the Windows OS. The samba team is very fast to provide fixes in the case Microsoft breaks something in one of its
    patch / service pack. I think ignoring this breakage for the release of sarge would make quite a lot of people unhappy,
    which is quite sad, given the little work that is required to apply the patch.

    However i agree that this bug doesn't fit into the "grave" category. But temptation is high for users to flag everything as
    "grave" so that it gets fixed for the Sarge release... :-)

    And i won't as Steve to build a new package, as he must be already overwhealmed by his RM task. :-(
    Maybe Eloy could find time to update a patched 3.0.5?

    Cheers,

    Fabien


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Eloy A. Paris@1:229/2 to Fabien Chevalier on Tue Aug 17 15:00:15 2004
    From: [email protected]

    On Mon, Aug 16, 2004 at 06:25:17PM +0100, Fabien Chevalier wrote:

    And i won't as Steve to build a new package, as he must be already overwhealmed by his RM task. :-( Maybe Eloy could find time to update
    a patched 3.0.5?

    If someone sends a patch I can certainly build fixed packages. I don't
    have time right now to go find the patch myself, though.

    Cheers!

    Eloy.-


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Fabien Chevalier@1:229/2 to All on Tue Aug 17 20:40:12 2004
    From: [email protected]


    If someone sends a patch I can certainly build fixed packages. I don't
    have time right now to go find the patch myself, though.

    Cheers!


    Taking you to the word, here is your patch, ready to be dropped in debian/patches :-)

    I've attached also fixes for two other serious bugs, which may be important to have fixed before sarge.
    Please note that these patches apply with offset, and will need to be removed from debian/patches when you package 3.0.6 in the future.

    And please find time to send the package to testing-proposed-updates, or maybe Steve can handle this part. :-)

    Cheers,

    Fabien

    --- samba-3.0.5-orig/source/nsswitch/wins.c.orig 2004-06-21 21:01:02.000000000 +0100
    +++ samba-3.0.5/source/nsswitch/wins.c 2004-06-21 21:02:22.000000000 +0100
    @@ -90,7 +90,7 @@
    {
    int fd = -1;
    struct ip_service *address = NULL;
    - struct in_addr *ret;
    + struct in_addr *ret = NULL;
    int j, flags = 0;

    if (!initialised) {

    --- samba-3.0.5-orig/source/rpc_server/srv_spoolss_nt.c
    +++ samba-3.0.5/source/rpc_server/srv_spoolss_nt.c
    @@ -3725,6 +3725,12 @@
    info->data=NULL;
    info->count=0;

    + /* a bug in xp sp2 rc2 causes it to send a fnpcn request without
    + sending a ffpcn() request first */
    +
    + if ( !option )
    + return WERR_BADFID;
    +
    for (i=0; i<option->count; i++) {
    option_type=&(option->ctr.type[i]);

    @@ -3787,6 +3793,12 @@
    info->data=NULL;
    info->count=0;

    + /* a bug in xp sp2 rc2 causes it to send a fnpcn request without
    + sending a ffpcn() request first */
    +
    + if ( !option )
    + return WERR_BADFID;
    +
    get_printer_snum(p, hnd, &snum);

    for (i=0;