• Bug#264340: 0.0.29 is worse than before

    From Marc Haber@1:229/2 to All on Fri Aug 13 11:00:25 2004
    From: [email protected]

    reopen 264340
    tags 264340 -patch
    thanks

    0.0.29 has broken mailon=changes. Obviously, all apt-get invocations
    are diffed against each other which makes cron-apt send a mail every
    hour. This is exactly what was originally to be avoided, only that the
    messages it sends now are much less readable than previously.

    Greetings
    Marc

    ----- Forwarded message from root <[email protected]> -----

    From: root <[email protected]>
    Subject: CRON-APT completed on janeway
    To: [email protected]
    Date: Fri, 13 Aug 2004 10:25:46 +0200

    CRON-APT RUN [/etc/cron-apt/config-hourly]: Fri Aug 13 10:25:42 CEST 2004 CRON-APT ACTION: 3-download
    --- /var/lib/cron-apt/mailchanges/3-download 2004-08-13 10:25:36.000000000 +0200
    +++ /var/lib/cron-apt/temp 2004-08-13 10:25:45.000000000 +0200
    @@ -1,3 +1,4 @@
    -CRON-APT LINE: autoclean -y
    +CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes
    Reading Package Lists...
    Building Dependency Tree...
    +0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    ----- DIFF END HERE -----
    CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes Reading Package Lists...
    Building Dependency Tree...
    0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    --- /var/lib/cron-apt/mailchanges/3-download 2004-08-13 10:25:45.000000000 +0200
    +++ /var/lib/cron-apt/temp 2004-08-13 10:25:46.000000000 +0200
    @@ -1,4 +1,3 @@
    -CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes
    +CRON-APT LINE: autoclean -y
    Reading Package Lists...
    Building Dependency Tree...
    -0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    ----- DIFF END HERE -----
    CRON-APT LINE: autoclean -y
    Reading Package Lists...
    Building Dependency Tree...

    ----- End forwarded message -----

    -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Karlsruhe, Germany | lose things." Winona Ryder | Fon: *49 721 966 32 15 Nordisch by Nature | How to make an American Quilt | Fax: *49 721 966 31 29


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Marc Haber@1:229/2 to All on Fri Aug 13 11:30:10 2004
    From: [email protected]

    The problem is that the diff file is named after ACTIONF, and the diff
    is built once for each apt-get invocation. This is fine as long as an
    ACITONF file only contains a single line, but fails miserably if
    multiple calls to apt-get are configured - for example in the default /etc/cron-apt/action.d/3-download. We end up diffing the output of
    apt-get autoclean -y against the output of apt-get upgrade $OPTIONS
    which are bound to differ.

    Greetings
    Marc

    -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Karlsruhe, Germany | lose things." Winona Ryder | Fon: *49 721 966 32 15 Nordisch by Nature | How to make an American Quilt | Fax: *49 721 966 31 29


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Ola Lundqvist@1:229/2 to Marc Haber on Fri Aug 13 11:30:11 2004
    From: [email protected]

    Hello

    On Fri, Aug 13, 2004 at 10:30:18AM +0200, Marc Haber wrote:
    reopen 264340
    tags 264340 -patch
    thanks

    0.0.29 has broken mailon=changes. Obviously, all apt-get invocations
    are diffed against each other which makes cron-apt send a mail every
    hour. This is exactly what was originally to be avoided, only that the messages it sends now are much less readable than previously.

    Doh. I'll fix this. I missed that action and line is not the same thing.

    Regards,

    // Ola

    Greetings
    Marc

    ----- Forwarded message from root <[email protected]> -----

    From: root <[email protected]>
    Subject: CRON-APT completed on janeway
    To: [email protected]
    Date: Fri, 13 Aug 2004 10:25:46 +0200

    CRON-APT RUN [/etc/cron-apt/config-hourly]: Fri Aug 13 10:25:42 CEST 2004 CRON-APT ACTION: 3-download
    --- /var/lib/cron-apt/mailchanges/3-download 2004-08-13 10:25:36.000000000 +0200
    +++ /var/lib/cron-apt/temp 2004-08-13 10:25:45.000000000 +0200
    @@ -1,3 +1,4 @@
    -CRON-APT LINE: autoclean -y
    +CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes
    Reading Package Lists...
    Building Dependency Tree...
    +0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    ----- DIFF END HERE -----
    CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes
    Reading Package Lists...
    Building Dependency Tree...
    0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    --- /var/lib/cron-apt/mailchanges/3-download 2004-08-13 10:25:45.000000000 +0200
    +++ /var/lib/cron-apt/temp 2004-08-13 10:25:46.000000000 +0200
    @@ -1,4 +1,3 @@
    -CRON-APT LINE: upgrade --ignore-missing --download-only --show-upgraded --yes
    +CRON-APT LINE: autoclean -y
    Reading Package Lists...
    Building Dependency Tree...
    -0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    ----- DIFF END HERE -----
    CRON-APT LINE: autoclean -y
    Reading Package Lists...
    Building Dependency Tree...

    ----- End forwarded message -----

    -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Karlsruhe, Germany | lose things." Winona Ryder | Fon: *49 721 966 32 15 Nordisch by Nature | How to make an American Quilt | Fax: *49 721 966 31 29


    --
    --------------------- Ola Lundqvist ---------------------------
    / [email protected] Annebergsslingan 37 \
    | [email protected] 654 65 KARLSTAD |
    | +46 (0)54-10 14 30 +46 (0)70-332 1551 |
    | http://www.opal.dhs.org UIN/icq: 4912500 |
    \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
    ---------------------------------------------------------------


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)
  • From Ola Lundqvist@1:229/2 to Marc Haber on Fri Aug 13 12:40:12 2004
    From: [email protected]

    Hello

    On Fri, Aug 13, 2004 at 11:03:16AM +0200, Marc Haber wrote:
    The problem is that the diff file is named after ACTIONF, and the diff
    is built once for each apt-get invocation. This is fine as long as an
    ACITONF file only contains a single line, but fails miserably if
    multiple calls to apt-get are configured - for example in the default /etc/cron-apt/action.d/3-download. We end up diffing the output of
    apt-get autoclean -y against the output of apt-get upgrade $OPTIONS
    which are bound to differ.

    Yes. That was the reason why it worked for me.

    It has been fixed in 0.0.30 now. :)

    Regards,

    // Ola

    Greetings
    Marc

    -- ----------------------------------------------------------------------------- Marc Haber | "I don't trust Computers. They | Mailadresse im Header Karlsruhe, Germany | lose things." Winona Ryder | Fon: *49 721 966 32 15 Nordisch by Nature | How to make an American Quilt | Fax: *49 721 966 31 29


    --
    --------------------- Ola Lundqvist ---------------------------
    / [email protected] Annebergsslingan 37 \
    | [email protected] 654 65 KARLSTAD |
    | +46 (0)54-10 14 30 +46 (0)70-332 1551 |
    | http://www.opal.dhs.org UIN/icq: 4912500 |
    \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
    ---------------------------------------------------------------


    --
    To UNSUBSCRIBE, email to [email protected]
    with a subject of "unsubscribe". Trouble? Contact [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: you cannot sedate... all the things you hate (1:229/2)