• Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault

    From Andreas =?UTF-8?B?UsO2bm5xdWlzdA==?@21:1/5 to [email protected] on Sat Jul 5 21:50:01 2025
    On Wed, 02 Jul 2025 23:21:47 +0200 "Francesco Poli (wintermute)" <[email protected]> wrote:
    Package: geeqie
    Version: 1:2.5-6
    Severity: normal
    Tags: patch
    X-Debbugs-Cc: [email protected]

    Hello,
    I have recently experienced a bug in the way geeqie invokes exiftran
    (in the "Losslessly rotate JPEG image" plugins).

    See bug [#1108680] for the details of the issue with exiftran.

    [#1108680]: <https://bugs.debian.org/1108680>

    While waiting for an actual fix in package 'exiftran', I attach
    a patch that works around bug [#1108680], dropping the '-g' option
    from the exiftran invocation.

    Please consider applying this patch.


    Thanks for your report - Will the rotated image still have it's
    thumbnail correct (and that also rotated) if used without the '-g'
    option?

    To me it looks like exiftran is unmaintained both in Debian and
    upstream, so the best course of action would probably be to migrate it
    to exiftool from the libimage-exiftool-perl package.

    But then, the very best idea might really be to simply drop these debian-specific scripts (since they don't work like they are supposed to anyway).

    /Andreas Rönnquist
    [email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Francesco Poli@1:229/2 to All on Sun Jul 6 12:20:02 2025
    From: [email protected]

    On Sat, 5 Jul 2025 21:09:45 +0200 Andreas Rönnquist wrote:

    On Wed, 02 Jul 2025 23:21:47 +0200 "Francesco Poli (wintermute)" <[email protected]> wrote:
    Package: geeqie
    Version: 1:2.5-6
    Severity: normal
    Tags: patch
    X-Debbugs-Cc: [email protected]

    Hello,
    I have recently experienced a bug in the way geeqie invokes exiftran
    (in the "Losslessly rotate JPEG image" plugins).

    See bug [#1108680] for the details of the issue with exiftran.

    [#1108680]: <https://bugs.debian.org/1108680>

    While waiting for an actual fix in package 'exiftran', I attach
    a patch that works around bug [#1108680], dropping the '-g' option
    from the exiftran invocation.

    Please consider applying this patch.


    Thanks for your report

    You're welcome! :-)

    - Will the rotated image still have it's
    thumbnail correct (and that also rotated) if used without the '-g'
    option?

    I don't know, I am not displaying any thumbnail embedded in EXIF data
    (if any is present).

    How do I check?

    Also, you can reproduce the exiftran bug by yourself, I even provided an example JPEG image in bug [#1108680]...
    Please help me in investigating the issue, I am not as knowledgeable
    about the EXIF metadata format, as I wish to be... :-(


    To me it looks like exiftran is unmaintained both in Debian and
    upstream,

    I was under this impression, too, that's why I thought I could file
    this bug report against geeqie, with a patch to work around the
    exiftran bug (while waiting for a proper fix in exiftran).

    so the best course of action would probably be to migrate it
    to exiftool from the libimage-exiftool-perl package.

    How?

    By searching the web, I found a forum [thread] that seems to state
    that exiftool is *not* able to losslessly rotate JPEG images, since it
    only edits EXIF metadata.

    [thread]: <https://exiftool.org/forum/index.php?topic=16163.0>

    I searched for other tools similar to exiftran in Debian, able to
    losslessly rotate a JPEG image, but I haven't found much: jpegtran
    (from package 'libjpeg-turbo-progs') seems to be able to losslessly
    rotate JPEG images, but without preserving EXIF metadata.
    It even suggests to use exiftran for JPEG images with EXIF data in its
    own jpegtran(1) man page...

    It seems that the only solution is that someone volunteers to adopt
    package 'exiftran'!
    Wow, yes, that was so obvious, why haven't I thought about it before?!? Maybe... you could volunteer?!? ;-)


    But then, the very best idea might really be to simply drop these debian-specific scripts (since they don't work like they are supposed to anyway).

    Well, but they are handy to quickly losslessly rotate JPEG photos from
    within qeeqie, without having to start another terminal and without
    having to always remember the correct options to be passed to exiftran
    (or other tool).

    Of course, I can write a small script with the correct options
    hardcoded...
    But, wait, those two "rotate-*.desktop" scripts are exactly that: small
    scripts with the correct options hardcoded and they can be even called
    directly from within geeqie...

    So, why should we drop the wheel and then re-invent the wheel?!?



    --
    http://www.inventati.org/frx/
    There's not a second to spare! To the laboratory! ..................................................... Francesco Poli .
    GnuPG key fpr == CA01 1147 9CD2 EFDF FB82 3925 3E1C 27E1 1F69 BFFE

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEygERR5zS79/7gjklPhwn4R9pv/4FAmhqSh4ACgkQPhwn4R9p v/69wA//ZsJSmEYEeIp4xGKgMV43h+fwhnmWlyNoi+jr8KruvZOw3sCFnGKat3lV KZ5Au7IxtkJaALmWDnF5hJqH1rbv554JqCeHawtBJxMvo4mzbR9DKqf6FzeaNuXE I9/vuVGS/VXhRP1oWEZgWIFNJK2lMISCJGQdxOqTXVBB8OTcHDYGWwhz8jsFKOS8 58FOdy770eraVYIy9kCUtNhkUF2BaKTF8ry9SkFRQiKMDu++ttlvzyBXrK8dGUCh KC7FSDq9inSYQYXAi6Ezmz/9IjbAcWAxmxn1h495qxzCKKSFVZqIVaMJs3VTaK0c gzck5du+vlWi39l3pADQtKFgJ2Cc0xxKO3uCu9E6PHqORzp459H7fuR0RQ2mrPFu Y5zfKPM8CWsBmIr2IAqY46hATSSdnUSmnnAswZoF3Brmpuvwz++WikqxaGUviZiG LD3FfA+VVrcgRxkriO70myhhzKOg+0TVQv+nmPU/wfhuNs4eGRbKZB98L/O/Czo9 jcDh08qH3LhSMhVkXOgNYqAWks1A8U2+7+A0z3cS/SZg4TYU4KHn2ZXbst/OcvzJ drjIx/RyOcZSxgPyFFzqZ5HaV1v/rNP3WeUmr3dv3rTU5OFz8ISFGyIzOdCow403 wH+iiaajAu3ktz8bQ2U0RzA+6C2H9v5M