• Bug#1106428: Additional insights on the failing QUERY method test (2/2)

    From =?UTF-8?B?SsOpcsOpbXkgTGFs?=@1:229/2 to All on Thu Jun 5 09:20:01 2025
    [continued from previous message]

            // update this implementation to run on supported versions of 21 once they exist<br>
            // upstream tracking <a href="https://github.com/nodejs/node/issues/51562" rel="noreferrer" target="_blank">https://github.com/nodejs/node/issues/51562</a><br>
            // express tracking issue: <a href="https://github.com/expressjs/express/issues/5615" rel="noreferrer" target="_blank">https://github.com/expressjs/express/issues/5615</a><br>
    -      return getMajorVersion(versionString) === &#39;21&#39;<br>
    +      return true<br>
          }<br>

          methods.slice().sort().forEach(function (method) {<br>

    Method 3: Assume that the function would return true in the place where the return value is used:<br>

    --- a/test/body-parser.js<br>
    +++ b/test/body-parser.js<br>
    @@ -89,7 +89,7 @@ describe(&#39;bodyParser()&#39;, function () {<br>
            if (method === &#39;connect&#39;) return<br>

            it(&#39;should support &#39; + method.toUpperCase() + &#39; requests&#39;, function (done) {<br>
    -        if (method === &#39;query&#39; &amp;&amp; shouldSkipQuery(process.versions.node)) {<br>
    +        if (method === &#39;query&#39;) {<br>
                this.skip()<br>
              }<br>
              request(this.server)[method](&#39;/&#39;)<br>


    I could make a team upload if some authorized voice tells me which solution is best/preferred.<br>
    (My personal preference would be method 2).<br>

    Thanks.<br></blockquote><div><br></div><div><br></div><div>The best fix would be in the embedded copy of llhttp in nodejs 20.19.2 - remove the HTTP QUERY support that was</div><div>added in <a href="https://github.com/nodejs/node/commit/
    eb25047b1b08180ed68dcefe2299682fbc7966