• Bug#1106428: Additional insights on the failing QUERY method test

    From Santiago Vila@21:1/5 to All on Thu Jun 5 03:20:01 2025
    Note: Beware: The package has autopkgtests, so maybe it's not as simple
    as disabling some tests. What can happen with the tests in testing
    if they run again now? Could they fail?

    Thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?B?SsOpcsOpbXkgTGFs?=@21:1/5 to All on Thu Jun 5 09:20:01 2025
    Le jeu. 5 juin 2025 à 03:17, Santiago Vila <[email protected]> a écrit :

    Note: Beware: The package has autopkgtests, so maybe it's not as simple
    as disabling some tests. What can happen with the tests in testing
    if they run again now? Could they fail?


    I believe this case is supported by the transition-to-testing logic.

    <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Le jeu. 5 juin 2025 à 03:17, Santiago Vila &lt;<a href="mailto:[email protected]">[email protected]</a>&gt; a écrit :<br></
    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Note: Beware: The package has autopkgtests, so maybe it&#39;s not as simple<br>
    as disabling some tests. What can happen with the tests in testing<br>
    if they run again now? Could they fail?<br></blockquote><div><br></div><div>I believe this case is supported by the transition-to-testing logic.</div><div><br></div></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Santiago Vila@21:1/5 to All on Thu Jun 5 11:40:01 2025
    El 5/6/25 a las 9:11, Jérémy Lal escribió:
    The best fix would be in the embedded copy of llhttp in nodejs 20.19.2 - remove the HTTP QUERY support that was
    added in https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab <https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab>

    This would avoid potentially hidden bugs in the nodejs-dependents packages. Shall we reassign this bug to nodejs ?

    Maybe, but in such case we might also forward this upstream. It would be troublesome
    if Debian adds or removes something in our nodejs 20.19.2 and then they remove or add
    it again in 20.19.3.

    Thanks.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?B?SsOpcsOpbXkgTGFs?=@21:1/5 to All on Thu Jun 5 11:40:01 2025
    Le jeu. 5 juin 2025 à 11:20, Santiago Vila <[email protected]> a écrit :

    El 5/6/25 a las 9:11, Jérémy Lal escribió:
    The best fix would be in the embedded copy of llhttp in nodejs 20.19.2 -
    remove the HTTP QUERY support that was
    added in
    https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab
    < https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab


    This would avoid potentially hidden bugs in the nodejs-dependents
    packages.
    Shall we reassign this bug to nodejs ?

    Maybe, but in such case we might also forward this upstream. It would be troublesome
    if Debian adds or removes something in our nodejs 20.19.2 and then they remove or add
    it again in 20.19.3.


    It already is ;) https://github.com/nodejs/node/issues/51562#issuecomment-2943008360

    <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Le jeu. 5 juin 2025 à 11:20, Santiago Vila &lt;<a href="mailto:[email protected]">[email protected]</a>&gt; a écrit :<br></
    <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">El 5/6/25 a las 9:11, Jérémy Lal escribió:<br>
    &gt; The best fix would be in the embedded copy of llhttp in nodejs 20.19.2 - remove the HTTP QUERY support that was<br>
    &gt; added in <a href="https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab</a> &lt;<a href="https://github.com/
    nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab" rel="noreferrer" target="_blank">https://github.com/nodejs/node/commit/eb25047b1b08180ed68dcefe2299682fbc7966ab</a>&gt;<br>
    &gt; <br>
    &gt; This would avoid potentially hidden bugs in the nodejs-dependents packages.<br>
    &gt; Shall we reassign this bug to nodejs ?<br>

    Maybe, but in such case we might also forward this upstream. It would be troublesome<br>
    if Debian adds or removes something in our nodejs 20.19.2 and then they remove or add<br>
    it again in 20.19.3.<br></blockquote><div><br></div><div>It already is ;)</div><div><a href="https://github.com/nodejs/node/issues/51562#issuecomment-2943008360">https://github.com/nodejs/node/issues/51562#issuecomment-2943008360</a></div><div><br></div><
    /div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From =?UTF-8?B?SsOpcsOpbXkgTGFs?=@21:1/5 to All on Sat Jul 12 12:50:02 2025
    Le ven. 11 juil. 2025 à 23:45, Chris Hofstaedtler <[email protected]> a
    écrit :

    Hi Jérémy,

    On Thu, Jun 05, 2025 at 12:17:13PM +0200, Jérémy Lal wrote:
    Le jeu. 5 juin 2025 à 11:53, Santiago Vila <[email protected]> a écrit
    :

    Good news from the github issue:

    "I'm gonna include 65c8380 in the v20 release"

    https://github.com/nodejs/node/issues/51562#issuecomment-2943090159

    I'm waiting a few hours to see if someone steps up, and will upload a patched nodejs with that commit.

    I saw you uploaded a security release after this message, but the
    fix was not included if I read the changelog right.

    Could you take another look?


    The 20.19.2 upload happened on may 18th, so not really "after this message".

    I'm to upload a fixed nodejs with only selected patches, because upstream
    keeps changing stuff
    and 20.19.3 has not the level of quality that I expected.

    Jérémy (from Brest !)

    <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Le ven. 11 juil. 2025 à 23:45, Chris Hofstaedtler &lt;<a href="mailto:[email protected]">[email protected]</a>&gt; a écrit :<br><
    /div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Jérémy,<br>

    On Thu, Jun 05, 2025 at 12:17:13PM +0200, Jérémy Lal wrote:<br>
    &gt; Le jeu. 5 juin 2025 à 11:53, Santiago Vila &lt;<a href="mailto:[email protected]" target="_blank">[email protected]</a>&gt; a écrit :<br>
    &gt; <br>
    &gt; &gt; Good news from the github issue:<br>
    &gt; &gt;<br>
    &gt; &gt; &quot;I&#39;m gonna include 65c8380 in the v20 release&quot;<br>
    &gt; &gt;<br>
    &gt; &gt; <a href="https://github.com/nodejs/node/issues/51562#issuecomment-2943090159" rel="noreferrer" target="_blank">https://github.com/nodejs/node/issues/51562#issuecomment-2943090159</a><br>
    &gt; <br>
    &gt; I&#39;m waiting a few hours to see if someone steps up, and will upload a<br>
    &gt; patched nodejs with that commit.<br>

    I saw you uploaded a security release after this message, but the <br>
    fix was not included if I read the changelog right.<br>

    Could you take another look?<br></blockquote><div><br></div><div>The 20.19.2 upload happened on may 18th, so not really &quot;after this message&quot;.</div><div><br></div><div>I&#39;m to upload a fixed nodejs with only selected patches, because upstream
    keeps changing stuff</div><div>and 20.19.3 has not the level of quality that I expected.</div><div><br></div><div>Jérémy (from Brest !)</div></div></div>

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)