Control: tags -1 patch
On Fri, Nov 29, 2024 at 02:48:21PM +0100, John Paul Adrian Glaubitz wrote:
Hello,
On Fri, 2024-11-29 at 14:28 +0100, Michael Prokop wrote:
I'm not sure how relevant hfsutils is those days, but due to this
FTBFS issue, hfsutils is no longer present in Debian unstable
nor testing, so it won't be shipped with Debian/trixie unless
someone takes care of this. :)
I am going to take care of this during the holidays. I'm just currently overloaded.
The Ubuntu diff has this fixed.
A minimal-ish change (without the debian/rules rewrite in the Ubuntu diff) based on that is attached.
Thanks,
Adrian
cu
Adrian
diff -Nru hfsutils-3.2.6/debian/patches/0006-Fix-memory-corruption.patch hfsutils-3.2.6/debian/patches/0006-Fix-memory-corruption.patch
--- hfsutils-3.2.6/debian/patches/0006-Fix-memory-corruption.patch 1970-01-01 02:00:00.000000000 +0200
+++ hfsutils-3.2.6/debian/patches/0006-Fix-memory-corruption.patch 2024-04-14 14:46:37.000000000 +0300
@@ -0,0 +1,57 @@
+Description: Fix memory corruption in hfssh
+ This was caused by mismatched alloc/free functions.
+ Memory allocated by Tcl must be freed by TclFree and memory transferred to
+ Tcl must be allocated using TclAlloc.
+Author: Zixing Liu <
[email protected]>
+Bug-Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=421457 +Bug-Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/hfsutils/+bug/493273 +Forwarded: no
+Last-Update: 2024-06-11
+---
+Index: hfsutils/tclhfs.c +===================================================================
+--- hfsutils.orig/tclhfs.c
++++ hfsutils/tclhfs.c
+@@ -378,7 +378,7 @@ int file_cmd(ClientData clientData, Tcl_
+ return TCL_ERROR;
+ }
+
+- mem = ALLOC(char, bytes + 1);
++ mem = Tcl_Alloc(bytes + 1);
+ if (m