1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.PERL

  • Is some real Depends from libnet-telnet-perl needed in libasterisk-agi-

    From Andreas Tille@21:1/5 to All on Thu May 15 12:10:01 2025
    Hi,

    I updated the packaging of libasterisk-agi-perl in Salsa. I stumbled upon the failed autopkgtest[1] which says:

    # Can't locate Net/Telnet.pm in @INC ...

    So it seems that we do not need only a Build-Depends: libnet-telnet-perl (which is set in d/control) but also a Depends. There is:

    $ grep -Ri Net::Telnet
    lib/Asterisk/Astman.pm:use Net::Telnet;
    lib/Asterisk/Astman.pm: $self->{'telnet'} = new Net::Telnet;
    Makefile.PL: 'Net::Telnet' => 0
    META.yml: Net::Telnet: '0'
    META.json: "Net::Telnet" : "0"


    Any reason why this Depends is not automatically detected?

    Kind regards
    Andreas.

    [1] https://salsa.debian.org/pkg-voip-team/libasterisk-agi-perl/-/jobs/7584065#L852

    --
    https://fam-tille.de

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Andreas Tille on Thu May 15 12:40:01 2025
    On Thu, 15 May 2025 12:01:11 +0200, Andreas Tille wrote:

    # Can't locate Net/Telnet.pm in @INC ...
    So it seems that we do not need only a Build-Depends: libnet-telnet-perl (which
    is set in d/control) but also a Depends.

    Right.

    META.yml: Net::Telnet: '0'
    META.json: "Net::Telnet" : "0"

    Any reason why this Depends is not automatically detected?

    I'm pretty sure that dh-make-perl would find / would have found it …


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- BOFH excuse #412: Radial Telemetry Infiltration

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Sebastiaan Couwenberg on Thu May 15 13:40:02 2025
    On Thu, 15 May 2025 13:15:42 +0200, Sebastiaan Couwenberg wrote:

    Any reason why this Depends is not automatically detected?
    I'm pretty sure that dh-make-perl would find / would have found it …
    It would be nice if dh_perl would add the dependencies from the
    META files to the appropriate substvars like dh_python3 does for
    Python packages.

    Hm …

    That automatically adds runtime dependencies when upstream adds
    those their package metadata, for Perl packages I always have to
    remember to update dependencies manually when the upstream diff
    shows dependency changes in the META files.

    Well, first of all, the mapping between CPAN distribution names (and
    versions) and Debian package names (and versions) is surprisingly
    difficult. Also, you'd have to add them to Build-Depends{,-Indep]
    manually anyway in all but very unusual cases.


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- BOFH excuse #68: only available on a need to know basis

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From gregor herrmann@21:1/5 to Sebastiaan Couwenberg on Thu May 15 14:00:01 2025
    On Thu, 15 May 2025 13:52:13 +0200, Sebastiaan Couwenberg wrote:

    Also, you'd have to add them to Build-Depends{,-Indep]
    manually anyway in all but very unusual cases.
    Those are quickly revealed as the package most often will FTBFS
    without the new build dependencies.

    Right, and then I add dependencies to both B-D and (after checking)
    Depends, if I have missed them in the diff :)

    Missing runtime dependencies are easy to miss until the autodep8
    autopkgtests complain, which tends to happens only after the upload
    when Salsa CI is not enabled.

    I always run autopkgtests locally before the upload.

    But yes, either Salsa CI or a local autopkgtest run is very helpful
    or even necessary.


    Cheers,
    gregor

    --
    .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
    : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
    `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
    `- BOFH excuse #354: Chewing gum on /dev/sd3c

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Andreas Tille@21:1/5 to All on Thu May 15 21:40:02 2025
    Hi Gregor,

    Am Thu, May 15, 2025 at 12:34:24PM +0200 schrieb gregor herrmann:
    Any reason why this Depends is not automatically detected?

    I'm pretty sure that dh-make-perl would find / would have found it …

    I assumed that ${perl:Depends} would find it as well - but you are
    correct that dh-make-perl does a proper job.

    Thanks for confirming
    Andreas.

    --
    https://fam-tille.de

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)