On Tue, 22 Feb 2022 23:16:14 +0100, Jonas Smedegaard wrote:

1) moving to our discussion list
2) cc'ing Jelmer as the janitor maintainer
3) fullquote for context

Apparently janitor now auto-imports new upstream releases: https://salsa.debian.org/perl-team/modules/packages/libcode-tidyall-perl/-/commit/1f41595

I think that is problematic: It cannot guess how exactly new upstream releases should integrated with git repo (upstream does not always tag
their releases, and some Debian developers was to sync upstream git tags others don't).

Also, in the concrete case of libcode-tidyall-perl it failed to include
the repackaging suffix.

I also noticed that the janitor now tries to import & push new
upstream releases, and I'm at least skeptical about the usefulness of
this feature; either it fails or it succeeds but then it doesn't save
any actual work over dpt-import-orig or similar (ok, I guess the idea
is that it shows maintainers "hey I tried and it works, go ahead
without having to fear troubles").

The behaviour comes, AFAICS, from https://salsa.debian.org/jelmer/janitor.debian.net/blob/master/k8s/policy.conf#L313

Not sure how/why pkg-perl got special cased here; it might be an
honour :) but 5dec4fa only says "Update proposal description for
fresh-*".

As Jonas considers this behaviour as problematic and I'm unconvinced,
I suggest to wait for other opinions in the group and drop those
lines from policy.conf if there is no support and consensus for it in
a couple of days.


Jelmer, on a related note (as I was looking at policy.conf), I
noticed that the janitor doesn't add anything to d/changelog anymore
since, well, at least half a year, although DEB_UPDATE_CHANGELOG is
still set to "update" for pkg-perl in policy.conf. (The problem here
is that changes may never end up in the shipped d/changelog if
someone updates the file after the janitor's commits and this person
or someone else later runs (gbp-)dch). No idea if some software
changed in the background and/or if 124df13 is connected (probably
not, I noticed the missing entries at least in September), or
something else :)


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmIWVZNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgY0Lw//UarKT/nw2FfkVtHJVAbPVCOhDy9wczP+HicH7DrQpmxFSsO4PgqfzzK1 hZp0iorPQyOaQ5HZg/mpTpQMezWMAaJ/ZFPgs+ZDQ2h450gQeTQldvVimBtQiBgA 7YpONzSVu1wYZ+hRfe2lkVzsfQj9n1oL7zDgfHBu+P3Hr0+RYV6R9wzN9GRb2VJC 9+ZNvN/mT5Y4Y4G0QaOL4yoDA2YklR+IuB1S245k/brPEgKkAvDF5j6qajhx9aX/ P9ycViT8xAUYK49en1OzGwX9Yx5GNpmexYx415vsZrmZyHHUjyCFAZVU2fXgBw92 oeR8CwWTLgJ3+L5cIXY4bveWNYJxu68XwtbE+MFSTnsdeyJzuoyIa6JJEsMMs+iq eOJ9lbqwrljZ+eJrkLVeTb5PVdQ5kasPvmOmqH3R8vVLeM8MpewVvmL6xiC8ynE2 ibjxsXuBS/juQLZ3jZXfX5iCGJIWDxpfHKEEdKWU+9FQ2vGHP4TNDVdIDdBZF1B5 AIl+60NPcLGQA0svchx/CCtRJMWnLlped41sTO5zrP39Bt+sdEZTH/znIWz5ueK2 pMY8VTLIzwT9t/ahD29kNRCOyydJXM65okV3kV6Oe8r02G6c/w87Itm8TvaR5BwE oP67wHL8gwH5LXdoWKY3ab7G/5dlV5yeMv5k36H0zKZu11b+b2w=
=V89a
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi Jonas, Gregor,

On Wed, Feb 23, 2022 at 04:40:58PM +0100, gregor herrmann wrote:

On Tue, 22 Feb 2022 23:16:14 +0100, Jonas Smedegaard wrote:

Apparently janitor now auto-imports new upstream releases: https://salsa.debian.org/perl-team/modules/packages/libcode-tidyall-perl/-/commit/1f41595

I think that is problematic: It cannot guess how exactly new upstream releases should integrated with git repo (upstream does not always tag their releases, and some Debian developers was to sync upstream git tags others don't).

Also, in the concrete case of libcode-tidyall-perl it failed to include
the repackaging suffix.

I also noticed that the janitor now tries to import & push new
upstream releases, and I'm at least skeptical about the usefulness of
this feature; either it fails or it succeeds but then it doesn't save
any actual work over dpt-import-orig or similar (ok, I guess the idea
is that it shows maintainers "hey I tried and it works, go ahead
without having to fear troubles").

The behaviour comes, AFAICS, from https://salsa.debian.org/jelmer/janitor.debian.net/blob/master/k8s/policy.conf#L313

Not sure how/why pkg-perl got special cased here; it might be an
honour :) but 5dec4fa only says "Update proposal description for
fresh-*".

As Jonas considers this behaviour as problematic and I'm unconvinced,
I suggest to wait for other opinions in the group and drop those
lines from policy.conf if there is no support and consensus for it in
a couple of days.

My apologies for these - it was not my intention to enable that,
certainly not in this way - I've reverted the change to policy.conf
that snuck in with the template change.

Background is that I am indeed looking at automatically importing
new upstream releases - not just for perl but across Debian. There are
two aspects to this - both discovering where upgrades can happen
but also making freshly built packages available (with caveats, of
course).

My intent was to start by creating MRs like I have for the other
changes since that provides a good opportunity to get feedback without
changes packages. The bot is not meant to delight rather than
surprise, and that clearly failed here.

(Whether this is the kind of thing that could eventually migrate to
direct pushes rather than MRs in some cases, I don't know - I think
that'd would have to be a request from the maintainer like it has been
for other "campaigns" and it's skipping a few steps to even be
considering that at this point)

And yes, you are special :P
I was going to start with the perl team because of the huge
number of packages and the feedback from the perl team
in the early stages previously has been really helpful.

In terms of feedback so far, I wasn't aware of dpt-orig-import and I
do think for at least some of the version manipulation the business
logic can be fixed (at least to know when to error out). That said,
if this isn't useful then I can also just do the builds but not create
the MRs.

Jelmer, on a related note (as I was looking at policy.conf), I
noticed that the janitor doesn't add anything to d/changelog anymore
since, well, at least half a year, although DEB_UPDATE_CHANGELOG is
still set to "update" for pkg-perl in policy.conf. (The problem here
is that changes may never end up in the shipped d/changelog if
someone updates the file after the janitor's commits and this person
or someone else later runs (gbp-)dch). No idea if some software
changed in the background and/or if 124df13 is connected (probably
not, I noticed the missing entries at least in September), or
something else :)

I'm not sure what's happening there but let me investigate. Let me
look into that and follow up here.

Cheers,

Jelmer

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Wed, 23 Feb 2022 21:27:34 +0000, Jelmer Vernooij wrote:

The behaviour comes, AFAICS, from https://salsa.debian.org/jelmer/janitor.debian.net/blob/master/k8s/policy.conf#L313

Not sure how/why pkg-perl got special cased here; it might be an
honour :) but 5dec4fa only says "Update proposal description for
fresh-*".

As Jonas considers this behaviour as problematic and I'm unconvinced,
I suggest to wait for other opinions in the group and drop those
lines from policy.conf if there is no support and consensus for it in
a couple of days.

My apologies for these - it was not my intention to enable that,
certainly not in this way - I've reverted the change to policy.conf
that snuck in with the template change.

Thanks!

Background is that I am indeed looking at automatically importing
new upstream releases - not just for perl but across Debian. There are
two aspects to this - both discovering where upgrades can happen
but also making freshly built packages available (with caveats, of
course).

Right, I had forgotten about the second part of this idea.

(Whether this is the kind of thing that could eventually migrate to
direct pushes rather than MRs in some cases, I don't know - I think
that'd would have to be a request from the maintainer like it has been
for other "campaigns" and it's skipping a few steps to even be
considering that at this point)

Yeah, let's see how it develops.

And yes, you are special :P

<watch collective blushing here>

In terms of feedback so far, I wasn't aware of dpt-orig-import

It's just a wrapper around gbp-import; relevant in this context is
that it adds a changelog entry after the import (in order to have the
new version in d/changelog)

and I
do think for at least some of the version manipulation the business
logic can be fixed (at least to know when to error out). That said,
if this isn't useful then I can also just do the builds but not create
the MRs.

I guess we can try and see what it looks like.

Jelmer, on a related note (as I was looking at policy.conf), I
noticed that the janitor doesn't add anything to d/changelog anymore
since, well, at least half a year, although DEB_UPDATE_CHANGELOG is
still set to "update" for pkg-perl in policy.conf. (The problem here
is that changes may never end up in the shipped d/changelog if
someone updates the file after the janitor's commits and this person
or someone else later runs (gbp-)dch). No idea if some software
changed in the background and/or if 124df13 is connected (probably
not, I noticed the missing entries at least in September), or
something else :)

I'm not sure what's happening there but let me investigate. Let me
look into that and follow up here.

Great, thank you!


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`-

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAmIZAxNfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgbNDBAAvR62OWrzmhVvn+trW76VszgcGxoqKlzbahcfD+4sIfk6jR3Rpa/a1fal uEfJjLDWVxOfNU3bQss6i6w2HClCktlba4j/XWXkCS9msdtnIQGseymvKzGpxIHt yWUOyhdt98wEG9AWv5FetCYjUOH/CMIslo3DqdwEwMfVNLkKoH0pQeLVMrW4Y4pD d2KlHE6ibT5BOATjnDWupa8w3oiz4vasvUHbf0B4ouqqraabRVEzuu3cjGGdNcyk IYyMKoVqcFVg0Eh8ceqQnrL62wyTZsOe4RzomjRr9NEtrUgY4kyQnq8WhXorLDtq feCTFBrzx3kZvm69PjnynPVJM5jaiDYtOmmaJbranmaHfzNxOAcgcHSYk8FTcd3u o5nOJDtjl5jIQlGyl+flVU8FqBjihqC5msFyU1YjQybWRxSrOwQ7L73bJOqJFp8j KdbVKzveDz8DRqz3J6dROe5fREgeoVE/CpT9lYlgP5Hqoj9xaMTaxPDbZdzEWuBb vRlg/2ypghU500L9AnsJ+atVU97w8oX+f8u+FKdqSY8wn8I3czGb1J53HT/7SJMV Lqqo9YgIEvLLr3spCBKnHZL/L/QYuYecvPj/jGbS5P/EXLfWFmSuAQIOY0BbTkjv n21/AKD3yZNnXzbzarlyPd/c0tR8s2SrjO4Y9nKJTO8o8AqkfiU=
=1WKM
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)