On Mon, 06 Jul 2020 11:33:14 +1200, Andrew Ruthven wrote:
I added a couple of small commits, and I put two questions in debian/changelog, for you and others :)
They're good questions, I've resolved them both. The clean step was
because when the tests failed due to an old patch the blib directory
was left. I've moved it to a clean target.
I have to admit that I'm still not convinced that this needed; an
inconsistent state after a failed build (due to a failed test) is
nothing I would worry about, and nothing we handle in other packages.
(And maybe EUMM or M::B rm blib/ anyway?)
After your last change, which kind of "hijacks" the clean target, the
package now fails to build twice in a row:
[end of first build]
dpkg-deb: building package 'libgnupg-interface-perl' in '../libgnupg-interface-perl_1.00-1_all.deb'.
dpkg-genbuildinfo
dpkg-genchanges >../libgnupg-interface-perl_1.00-1_amd64.changes dpkg-genchanges: info: including full source code in upload
dpkg-source --after-build .
dpkg-buildpackage: info: full upload (original source is included) dpkg-buildpackage: info: source package libgnupg-interface-perl dpkg-buildpackage: info: source version 1.00-1
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Debian Janitor <
[email protected]>
dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
debian/rules clean
rm -rf blib
dpkg-source -b .
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Interface.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Signature.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Fingerprint.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Options.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::PublicKey.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::SubKey.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Key.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Revoker.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::Handles.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::UserAttribute.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::SecretKey.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::UserId.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/man/man3/GnuPG::PrimaryKey.3pm.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/doc/libgnupg-interface-perl/changelog.Debian.gz
dpkg-source: error: unwanted binary file: debian/libgnupg-interface-perl/usr/share/doc/libgnupg-interface-perl/changelog.gz
dpkg-source: error: detected 15 unwanted binary files (add them in debian/source/include-binaries to allow their inclusion).
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 255 E: Failed autobuilding of package
I suggest to remove the rm from debian/rules.
(And if there should be a case to care for blib/ manually, to stick
it into debian/clean.)
(And the current override_dh_clean doesn't do anything and can be
removed).
Oh, and override_dh_auto_configure also can be removed, as
Makefile.PL does basically the same now.
I've now pushed these changes to debian/rules, please shout if you
see any problem or have any issues building!
Last night laying in bed I realised I hadn't checked the dependencies
on gnupg. I've now fixed those as well. ;)
Great, thanks!
Cheers,
gregor
--
.''`.
https://info.comodo.priv.at -- Debian Developer
https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Donovan: Epistle To Derroll
-----BEGIN PGP SIGNATURE-----
iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl8DN39fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgZkCQ/+NdC6QGQa3LBfvyDIU8+QNRUc536AQn8tkO9L37vAlWpbpg+bh5PM0QRn ZSarT380H5oobYnUzg2fIE8x2vdYbuRE3avlcIPu6bRrjRRicyw+Zq+vVJ/SAUEG tAiktk75fra2U4fCGl7yxb6zptYyuIq5+3YbJKTNkXY5I3tIJpa2aP8SXzSQlBiD 6yfcfMr8gnhd1K/vFjHJXsK90HVnn1H+Lv5dbBLuoTGAfuekJrmyaXTxTdbTyH27 PRLObCWdxixJjY3II9xeMmhlWS8Py+i3zBnQVM9mabOXen+fVCmi7WfeYrl6aoCv lXiwx8Uahrp7kYevAfFirBy3DaFxAUTC2NyJ5KIvXCXk8attTeSBt5L2kmF/mePn 1UQ//JAa5XAu07pMjcfrtNGjZ5SCBhPHvrwy9CUGUDCKX/UH2WHGXzkUFLDJXOad TmSY6N2RKCnx0BcdclztP0xIX3vr5qu0830VcXL5KWMM9hWpf2pgxycJ/OsUlP/+ 2GgQ7r9qVNSUl3d9A2I0RP0rj7hD9rmIPKfnyLgfSX/RQ8t3NbWH1S8SyvoeNSf6 baALB+W4Eaqw82EkzISBvpclwHMycMUeDtNOJxuyf0UAO+X1h2lpNtf7/VwBOm0i HcF9jCLIU7T7TACRycP32ajebkRdE10TQGe0Xf05pmxIUyp/7I8=
=P/oV
-----END PGP SIGNATURE-----
--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)