Hello,

I am working on a package already having pkg-perl autopkgtest suite, and
with 'Testsuite: autopkgtest-pkg-perl' in d/control. I want to add a
regular autopkgtest in addition to already existing pkg-perl suite. I
add d/tests/control with a 'Test-Command' there, but now lintian
complains with:

team/pkg-perl/testsuite/no-team-tests autopkgtest, autopkgtest-pkg-perl

The same tag is shown even if I change to 'Testsuite: autopkgtest, autopkgtest-pkg-perl'. Am I doing something wrong, or is this an issue
with lintian?

Thanks,
Andrius

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi,

On 2020-12-07 16:51, gregor herrmann wrote:

On Mon, 07 Dec 2020 16:07:46 +0200, Andrius Merkys wrote:

I am working on a package already having pkg-perl autopkgtest suite, and
with 'Testsuite: autopkgtest-pkg-perl' in d/control. I want to add a
regular autopkgtest in addition to already existing pkg-perl suite.

Out of curiosity: Why? [0]

The package in question (libjson-validator-perl) is to provide symlinks
to files in another binary package (openapi-specification) [1]. With
this autopkgtest I want to make sure the symlinks are not broken by
changes in openapi-specification.

I
add d/tests/control with a 'Test-Command' there, but now lintian
complains with:

team/pkg-perl/testsuite/no-team-tests autopkgtest, autopkgtest-pkg-perl

The same tag is shown even if I change to 'Testsuite: autopkgtest,
autopkgtest-pkg-perl'. Am I doing something wrong, or is this an issue
with lintian?

I think I've seen this before, and so far I've ignored it (or maybe overridden it) as "well, yes, this is a special situation …"

But maybe lintian could be improved, I never really looked into the
details of this combination.

By looking into lintian code [2], it seems that the code expects
'Testsuite' to contain a single entry, not comma-separated entries. I
will file an issue on lintian.

[0]
We do have some packages like this:

% ls -1d */debian/tests/control
boxer/debian/tests/control
debsums/debian/tests/control
equivs/debian/tests/control
lemonldap-ng/debian/tests/control libapache-authenhook-perl/debian/tests/control libapache-ssllookup-perl/debian/tests/control libapache2-mod-perl2/debian/tests/control libapache2-reload-perl/debian/tests/control libcli-framework-perl/debian/tests/control libdbd-mariadb-perl/debian/tests/control libdbd-mysql-perl/debian/tests/control
libdist-inkt-perl/debian/tests/control
mb2md/debian/tests/control

(Although some of them would probably be fine with a default autopkgtest-pkg-perl. Others are applications and not typical CPAN distributions/modules, and others really need special casing.)

[1] https://bugs.debian.org/964496
[2] /usr/share/lintian/checks/team/pkg-perl/testsuite.pm

Thanks,
Andrius

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, 07 Dec 2020 16:07:46 +0200, Andrius Merkys wrote:

I am working on a package already having pkg-perl autopkgtest suite, and
with 'Testsuite: autopkgtest-pkg-perl' in d/control. I want to add a
regular autopkgtest in addition to already existing pkg-perl suite.

Out of curiosity: Why? [0]

I
add d/tests/control with a 'Test-Command' there, but now lintian
complains with:

team/pkg-perl/testsuite/no-team-tests autopkgtest, autopkgtest-pkg-perl

The same tag is shown even if I change to 'Testsuite: autopkgtest, autopkgtest-pkg-perl'. Am I doing something wrong, or is this an issue
with lintian?

I think I've seen this before, and so far I've ignored it (or maybe
overridden it) as "well, yes, this is a special situation …"

But maybe lintian could be improved, I never really looked into the
details of this combination.


Cheers,
gregor


[0]
We do have some packages like this:

% ls -1d */debian/tests/control
boxer/debian/tests/control
debsums/debian/tests/control
equivs/debian/tests/control
lemonldap-ng/debian/tests/control libapache-authenhook-perl/debian/tests/control libapache-ssllookup-perl/debian/tests/control libapache2-mod-perl2/debian/tests/control libapache2-reload-perl/debian/tests/control libcli-framework-perl/debian/tests/control libdbd-mariadb-perl/debian/tests/control
libdbd-mysql-perl/debian/tests/control
libdist-inkt-perl/debian/tests/control
mb2md/debian/tests/control

(Although some of them would probably be fine with a default autopkgtest-pkg-perl. Others are applications and not typical CPAN distributions/modules, and others really need special casing.)

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Joe Cocker: With a Little Help from My Fri

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl/OQY5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgYdXg/+Py5Bx/j/5dsiqYWdo02RXfhnGJhjyjvsQZdKd96CKX3PsL3OMU23lFqL iFHew+62ugaxbTAIMVag6Mo5ZnR6m4Hf7uzCh5vNpdlhqyBUgjc1JQPL5zVczwko 5OXIVrsztixHA7WAixMEmDd7vMfqRVfiag2IMx1MgYrRzpoE+l4UQV7rdwoWYkkX Li87I5lWSP1nKfK2MozOyIQwDeHPru909Y7EiCzDI3Sg+SdUwCV0KHQWQR1w6ILl lZY7OLB4b66IUWn4QDApEE5C927s4//Im1TLExlHo5fENfl8SxtvhhyttoEAtHGX hy68FcSPMxUkfHx3Nnc0pi9T3HbNRLpkzFxvLM8D6SBRPVjgzl82VgLvAPP2n/Fa NKhuDzZ5DVFDYFIvwK6PMkdhG5J/PI9Z1YqlfvE7937PEmEZRjILHVUNs8zS56HI oQ6DR9w4UOTiI8CPMhA7e8EosFXm

On Mon, 07 Dec 2020 17:01:05 +0200, Andrius Merkys wrote:

I am working on a package already having pkg-perl autopkgtest suite, and >> with 'Testsuite: autopkgtest-pkg-perl' in d/control. I want to add a
regular autopkgtest in addition to already existing pkg-perl suite.

Out of curiosity: Why? [0]

The package in question (libjson-validator-perl) is to provide symlinks
to files in another binary package (openapi-specification) [1]. With
this autopkgtest I want to make sure the symlinks are not broken by
changes in openapi-specification.

Ah, right, I also just saw your commit.
An additional test seems useful indeed.

But maybe lintian could be improved, I never really looked into the
details of this combination.

By looking into lintian code [2], it seems that the code expects
'Testsuite' to contain a single entry, not comma-separated entries. I
will file an issue on lintian.

https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst
says:

Source package header
---------------------

To allow test execution environments to discover packages which provide
tests, their source packages need to have a ``Testsuite:`` header
containing ``autopkgtest`` (or a value like ``autopkgtest-pkg-perl``,
see below). Multiple values get comma separated, as usual in control
files. This tag is added automatically by dpkg-source version 1.17.11
or later, so normally you don't need to worry about this field.

so it looks like more than one values are indeed allowed.


Cheers,
gregor

--
.''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org
: :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06
`. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
`- NP: Neil Young: There's A World

-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEE0eExbpOnYKgQTYX6uzpoAYZJqgYFAl/OTP5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQx RTEzMTZFOTNBNzYwQTgxMDREODVGQUJCM0E2ODAxODY0OUFBMDYACgkQuzpoAYZJ qgbh0w//YoUK4CFDI/Zg/T7Z5nbgwlxs/V6GhguTaR48qN3lhi0aNaMr7X6GR3Qi ERyoaFDPJt49oZ7Mbg5o8V6kLoAYTWn8Buf0QGMG37/raw3SglF4jJfs6KwJBdrJ mMvX8Jnuc81cbA6elrJfvHr47wKWk37EEaprINqX+Oi+J7DQXKsQez6gRARywBzL lKu007jENba5JQdLaCSDh/twvAlTX3YN+l9C27Dk0sOhQ8Yoqg60QV6242+sU8OO 8SsxhM9ath1KH2BqvrwnQcbR6/G1Az3JAtQOYfqDWAdauOoavEj5/9bOrTU19i0Y LwOa71OCPo7qSi6Tm69UYvH3UBu3fdWzU5lfyk3xY4OchiZ99ABaIc5RzwDioYAP I5xe9y9pTtdt6zVsRrZHVUkpK4QbeFv/bNA53Mpn4VF8HvYRD56YmIuZyAU61doi OOVtHy6abqGGzu28bRDVJiPN3ZuJEhtRHvJxRIjmNchqvXXcWfONAbWSSldOpgYe IzjHITU1cN7r6PPoo7lZTM21rjR6ZgDSLLmTUwhDKPtRLTbLtT9D7MRJML/5By+k OYvjnYkwqNgbkdKrzX43qwIzCQFXVpulg67blrZCCzvOwrjKAlRqwVWfMPfG8qfi aCed7y+v8y1qIUwcA+ZhxabJL7qhHzFS40EwmssRmkwmnOG3rrs=
=J8+5
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On 2020-12-07 17:40, gregor herrmann wrote:

https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst
says:

Source package header
---------------------

To allow test execution environments to discover packages which provide
tests, their source packages need to have a ``Testsuite:`` header
containing ``autopkgtest`` (or a value like ``autopkgtest-pkg-perl``,
see below). Multiple values get comma separated, as usual in control
files. This tag is added automatically by dpkg-source version 1.17.11
or later, so normally you don't need to worry about this field.

so it looks like more than one values are indeed allowed.

Debian policy says the same [1]:

5.6.30. Testsuite

Simple field containing a comma-separated list of values allowing test execution environments to discover packages which provide tests.

This field is automatically added to Debian source control files (.dsc)
by dpkg, with the value autopkgtest, when a debian/tests/control file is present in the source package. This field may also be used in source
package control files (debian/control) if needed in other situations.

[1] https://www.debian.org/doc/debian-policy/ch-controlfields.html#testsuite

Best,
Andrius

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)