On Sat, Dec 28, 2024 at 03:34:07PM +0500, Andrey Rakhmatullin wrote:

On Sat, Dec 28, 2024 at 11:21:11AM +0100, Simon Josefsson wrote:

Hi. Asking for some advice here, in python-netfilterqueue there is now:

export PYBUILD_TEST_ARGS=--ignore tests/conftest.py

conftest.py is not a file with test cases, it's a "config" file for all tests, ignoring it doesn't make sense and not running code from it (if
that's what you want) is likely impossible. I don't understand what do you want to achieve by ignoring it so I cannot suggest anything useful though.

If you want to replace the unshare module with the ctypes code as proposed
by Helmut or with something else, you need to *patch* the code.


--
WBR, wRAR

-----BEGIN PGP SIGNATURE-----

iQJhBAABCgBLFiEEolIP6gqGcKZh3YxVM2L3AxpJkuEFAmdv1KEtFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3Jnd3JhckBkZWJpYW4ub3JnAAoJEDNi9wMaSZLh iLkQAIJpuriqogomjxz35Bi33wcWxd7XkwfPpdy3L5BaUQGo2XGLbbdPJX7csHRw 8nLnyEk2/MwFMengyHWbAUh1Rxj4sUCtXK1Nyf82vIBFHJWLkVZyU738IKIkFSHY rsahaWaV0nXmcFkPk5dFptsXIxLOXGimnAvPIs1rW4+u1yPcJx8tkvwYY0v/Z9gm B/V+A3zz7XJV56Anf4ioZg8nMUpfc79eqnzs5Gj3cwouLfgqb8n09ja64Dqk7ErV 1pQtr4Hauz1GubdsMJZnhJiOiKnQ+c6s12RDTDLFIYIfr9Yp5v2QzfxVIGURZtMT Z6kkTuabfrjzfPrdn6QW9d+LLOAXQ3+g7k8YVKefvwR1ZkNEpa5qECh16MY3bwb2 FZxAAWQFYfNbs1u8Oe5Yg4U4nwkplNFBmOZM0lxfPg8k6MwWdAYiwIuAvFTLH6e6 uM0247VP1ojZKKeh/2Nx4YEIK7g3Zwnj9du+7BKuVxqsNmHSpetDjKuZiHpZW+Kx VxdnzBUTZLrlIkZJof3B9VcqiZ3MqbzDh6H2OHHRqKbnE7hhlufiesEJfwpSbema MeYlI/nqx0nCVLhPyllOo4ngmvXCqZPd0YH78jQS1RHTAuHyW+ej7g/u7CBEtOpy pfzVhZ5ySRMBE4T/Ju9EKfP9Gwm3K5htu1omItOnvkVGnIge
=8Tiy
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Hi. Asking for some advice here, in python-netfilterqueue there is now:

export PYBUILD_TEST_ARGS=--ignore tests/conftest.py

but dh_auto-test still seems to use that file, see output below.

How do I make pytest (for both build and autopkgtest) really ignore that
file and not try to use it?

My reading of https://wiki.debian.org/Python/Pybuild suggests it should
work.

/Simon

dh_auto_test
I: pybuild base:311: cd /builds/python-team/packages/python-netfilterqueue/debian/output/source_dir/.pybuild/cpython3_3.13/build; python3.13 -m pytest --ignore tests/conftest.py
ImportError while loading conftest '/builds/python-team/packages/python-netfilterqueue/debian/output/source_dir/.pybuild/cpython3_3.13/build/tests/conftest.py'.
tests/conftest.py:8: in <module>
import unshare # type: ignore
E ModuleNotFoundError: No module named 'unshare'
E: pybuild pybuild:389: test: plugin pyproject failed with: exit code=4:
cd /builds/python-team/packages/python-netfilterqueue/debian/output/source_dir/.pybuild/cpython3_3.13/build;
python3.13 -m pytest --ignore tests/conftest.py

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCZ2/RFxQcc2ltb25Aam9z ZWZzc29uLm9yZwAKCRBRcisI/kdFohAUAP9w58oKKTEEeJm93YQi3wN+Hk+/tjEr lapeZo6c+aF+NwEAqtMaDMRO+l4JBVivr+0qbqJXq08ebCOnC2QLg0bzhQE=V2Io
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sat, Dec 28, 2024 at 11:21:11AM +0100, Simon Josefsson wrote:

Hi. Asking for some advice here, in python-netfilterqueue there is now:

export PYBUILD_TEST_ARGS=--ignore tests/conftest.py

conftest.py is not a file with test cases, it's a "config" file for all
tests, ignoring it doesn't make sense and not running code from it (if
that's what you want) is likely impossible. I don't understand what do you
want to achieve by ignoring it so I cannot suggest anything useful though.

--
WBR, wRAR

-----BEGIN PGP SIGNATURE-----

iQJhBAABCgBLFiEEolIP6gqGcKZh3YxVM2L3AxpJkuEFAmdv1BotFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3Jnd3JhckBkZWJpYW4ub3JnAAoJEDNi9wMaSZLh zw4QAKwy5OSh3newEsi4otzCNGCu+bzwZRtPhJlWTXVd4GMPM5S9dJwEhNLBdrul rYJMa0YxHRCqXR5j/In+EA1HdJAyHfjdMIQreMJWZu4Nfm5ZUXaghNepp10LO1i+ squJbSGPCGT/bicqRIFVM0+lkFVtWOt6/Re1hNuOo/ECGS7fZYT7kg/L0Qf14Jam wMPU1pNjRYJdeS9hFH0b51pEsYcCTIEoWmuQSaBeDD61qjDBIMOLkifUQp977PLW y9/9M4sEnXjjkcLp3N2MJos1BbBYW7CnZOek89Mxk1I+BikFt/k5J7glPdydvuGy jNyR5j1Eo6XovnELxKo+A5lNYIyg/pha19SvL7TeXjowmHDKuCW2QXgVGIqo30r+ WPTdtechYxWoLfbhGZI7ltp4DmQc+teNFz/19GJAg57t3WX9mN+w9shC6CJy4vTi gyo/stz3yDhHKhAjJZcXsbal8xDj9bQ3ifwy0YA3tSX3iZYy+BHppotGvSH0IS5w aR9yfwHroiDmeXnyaYVoYzYp9RCbwTODH4N59iUb5BqX9qQ7Mp3KVul1R45zBAVH 5e/GJ1eNh3/Nv/GXnNvlMwL2GXghRX/0u/DiRV1R7FSd4FVuKh7sZtzna960Teq8 l6GI78y6+eJ/DYuUwx0Ylb1X0/hvOWjVH+n+uFDII7B+H1fJ
=QvYY
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Andrey Rakhmatullin <[email protected]> writes:

On Sat, Dec 28, 2024 at 11:21:11AM +0100, Simon Josefsson wrote:

Hi. Asking for some advice here, in python-netfilterqueue there is now:

export PYBUILD_TEST_ARGS=--ignore tests/conftest.py

conftest.py is not a file with test cases, it's a "config" file for all tests, ignoring it doesn't make sense and not running code from it (if
that's what you want) is likely impossible. I don't understand what do you want to achieve by ignoring it so I cannot suggest anything useful though.

Thank you -- what I want to achieve is a build that succeeds after I
remove this heavy hammer that ignores all self-tests errors:

override_dh_auto_test:
-dh_auto_test $(DH_BUILD_OPTS)

Maybe all of upstreams self-tests really do depend on the unshare
module, and if we don't want to include that in Debian [1] there is no
hope to get netfilterqeueue self-tests to work. And then we just as
well disable all self-tests like that.

/Simon

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091506#10

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIoEARYIADIWIQSjzJyHC50xCrrUzy9RcisI/kdFogUCZ2/VzxQcc2ltb25Aam9z ZWZzc29uLm9yZwAKCRBRcisI/kdFomxNAQCSKk8jTH/BWTRVaMKgNLNDbXYwXgj7 UFo03yQDR8VMzwD+L9noS4LUEv/QCRQGYPcttjR87To0EGEfpVoTB5FTcA8=2J+z
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sat, Dec 28, 2024 at 11:41:19AM +0100, Simon Josefsson wrote:

Hi. Asking for some advice here, in python-netfilterqueue there is now: >>
export PYBUILD_TEST_ARGS=--ignore tests/conftest.py

conftest.py is not a file with test cases, it's a "config" file for all tests, ignoring it doesn't make sense and not running code from it (if that's what you want) is likely impossible. I don't understand what do you want to achieve by ignoring it so I cannot suggest anything useful though.

Thank you -- what I want to achieve is a build that succeeds after I
remove this heavy hammer that ignores all self-tests errors:

override_dh_auto_test:
-dh_auto_test $(DH_BUILD_OPTS)

Maybe all of upstreams self-tests really do depend on the unshare
module,

They likely do, considering that they all use it via pytest_runtestloop().

and if we don't want to include that in Debian [1] there is no
hope to get netfilterqeueue self-tests to work. And then we just as
well disable all self-tests like that.

/Simon

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091506#10

That says "you can use this instead of that".

--
WBR, wRAR

-----BEGIN PGP SIGNATURE-----

iQJhBAABCgBLFiEEolIP6gqGcKZh3YxVM2L3AxpJkuEFAmdv2XAtFIAAAAAAFQAP cGthLWFkZHJlc3NAZ251cGcub3Jnd3JhckBkZWJpYW4ub3JnAAoJEDNi9wMaSZLh 7j4P/0RDUjj2F3ikV30kS5/JSccQI3nZWbNNS3dOqng9x6GPVlWXgwnWvnaFii8G CHiCRQQoFbFMNVlteOjMN7HypwW92kRooTqbB15qqemJvczQm/aLInUPjDMuawM5 v+84M+aD6M70p8mOpn0ehB49w4GzdSZQOfeEYQa8b3pQlSSG0Jx/cH+gvvrhbNT5 Y6JWhK33LIRhgWStafHzqAYUA7dzGRFA5tZmzXHB0JwihrIQBSOuW80T1bxjBlgW vmBQGwx04DTarMr4uEPDXj/TKq0q7bHoqDSJ9+9cvrjDTLXo6xWLSnsTg1LhdPfp qe5BGslQm98R38nkO4Xs+xdNhA9QXt3uTNuDu43ZF3nP+GpFLhPuSEoCg/dfRqEl JuWUJ0u7KOeLt+1uxVA3BQByQis8wPV5ObJCB4SelPPtGkPbyFGnosX8WABTsb4N oteVev8W00z+CRgJqT8vpVnkXvZBHdt213o7ThELGOW5euDyDRhwj0MVyVmcj+oZ pXULdx8bIk1hJCB/B4F95C5DOPEebA0LgauZ+V8J1ph8J0Fft4w4ifXL1/5yI7+O cBgug4ITyoAbNnbvZWGIvartI2p6oRznHzg7Eynej+bclDdXo7Zi8zzO3AoszSvZ +DhvBJlQeaV/KiCaK6fFlGKBFQXnpG8mwlp6HG74nHQZGMrX
=ibqI
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)