Hello,

I need someone from the Python packaging team to review the packaging of cocotb

The package can be found on Git: https://salsa.debian.org/electronics-team/cocotb

I am particularly puzzled by the files layout of cocotb, for example
compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
and data files (makefiles mostly) are under: /usr/lib/python3/dist-packages/cocotb/share/

The package has the following lintian issues:
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libembed.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpi.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/simulator.cpython-312-x86_64-linux-gnu.so]
I: python3-cocotb: hardening-no-fortify-functions [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:12]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:13]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:5]
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

Regards,

--
‎أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761
8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEggahliCEfm0N+LF2vBlqlO3dobcFAmal1bUACgkQvBlqlO3d obd5/Qf+OU/Cqxss9bS1x6k6Q/laf6DcCYVN7FxO0Sth7jL+SDt+ccsIEZNnwMp1 lhdTrN/wsgRFPWJpL7PhdkMhOx2wWAFn7OAbG27Ja6NbXMWItAIOczzfcW6OD21N FKY2vCtQMz0/TcE/pnXay8d6p5aPAT1YzvwlKkyQfLzXDyFBi38KJ+9OnMRxyBo3 CP3jYgpeGJ+nXMW+8dMPKa1TtRFXfoHqOjQVB0hH57r5chrFM2WCPrB/y9rgWYjH AbBFNP8w5eih2kENEtHwbCseZpZH1L4nTptBqQs8CfdQA74sHlySwUdyNBA/Tewt RnKfil9CdTkJnC/1EbZVVgIRfqjc9w==
=IQMD
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

مرحبًا أحمد

I was not able to fix the hardening-no-bindnow errors by adding the
usual hardening=+bindnow to the DEB_BUILD_MAINT_OPTIONS in d/rules.

However I saw some other things that I think should be fixed before you
upload. I have created a PR here:

https://salsa.debian.org/electronics-team/cocotb/-/merge_requests/1

debian/copyright | 10 ++++------
debian/lintian-overrides | 2 ++
debian/source/lintian-overrides | 3 +++
3 files changed, 9 insertions(+), 6 deletions(-)

Otherwise I think the package is good to upload. Maybe the other
warnings can be fixed later.

Best regards,

Agathe.

2024-07-28 07:23 CEST, أحمد المحمودي:

Hello,

I need someone from the Python packaging team to review the packaging of cocotb

The package can be found on Git: https://salsa.debian.org/electronics-team/cocotb

I am particularly puzzled by the files layout of cocotb, for example
compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
and data files (makefiles mostly) are under: /usr/lib/python3/dist-packages/cocotb/share/

The package has the following lintian issues:
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libembed.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpi.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so]
I: python3-cocotb: hardening-no-bindnow [usr/lib/python3/dist-packages/cocotb/simulator.cpython-312-x86_64-linux-gnu.so]
I: python3-cocotb: hardening-no-fortify-functions [usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:12]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:13]
I: cocotb source: uses-python-distutils [cocotb_build_libs.py:5]
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:

Otherwise I think the package is good to upload. Maybe the other
warnings can be fixed later.

---end quoted text---

Thanks for your reply, yet my primary concern, rather than the lintian
issues, was the files layout for python3-cocotb:

compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/
shouldn't those rather be under: /usr/lib/<multiarch-triplet>/cocotb/ ?

also, the data files (makefiles mostly) are under: /usr/lib/python3/dist-packages/cocotb/share/, shouldn't those rather be
under /usr/share/cocotb ?

I'm not sure if this lintian issue is related:
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

Here's a snipet of the files layout for python3-cocotb:

./usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so ./usr/lib/python3/dist-packages/cocotb/libs/libembed.so ./usr/lib/python3/dist-packages/cocotb/libs/libgpi.so ./usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so ./usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so

./usr/lib/python3/dist-packages/cocotb/share/include/ ./usr/lib/python3/dist-packages/cocotb/share/include/cocotb_utils.h ./usr/lib/python3/dist-packages/cocotb/share/include/embed.h ./usr/lib/python3/dist-packages/cocotb/share/include/exports.h ./usr/lib/python3/dist-packages/cocotb/share/include/gpi.h ./usr/lib/python3/dist-packages/cocotb/share/include/gpi_logging.h ./usr/lib/python3/dist-packages/cocotb/share/include/py_gpi_logging.h ./usr/lib/python3/dist-packages/cocotb/share/include/vhpi_user_ext.h ./usr/lib/python3/dist-packages/cocotb/share/include/vpi_user_ext.h ./usr/lib/python3/dist-packages/cocotb/share/lib/ ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/ ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/verilator.cpp ./usr/lib/python3/dist-packages/cocotb/share/makefiles/ ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.deprecations ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.inc ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.sim ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/ ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.activehdl
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.cvc ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ghdl ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.icarus
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ius ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.modelsim
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.nvc ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.questa
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.riviera
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.vcs ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.verilator
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.xcelium

Sorry for the late reply, I had no internet access in the previous
months.

--
‎أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761
8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEggahliCEfm0N+LF2vBlqlO3dobcFAmdV1ZAACgkQvBlqlO3d obc9eQf/ei2C2Hby8tdm5zEfxSJiAlReosZ+TMgfLOoSsgNU16c/fX2hl2tQLO20 dMxFAReAaIR3kDGhBorGLdpdca6tX4iZA9Lwd6mS74cg3jmsnHaV6T3crjSTDX+2 nQVtU/kKi5luREUt7q0cdojoq7QlQDoZgRVHGncLGvK+yby8vwi2m5oDl2v4lFRa g1esslloVoyVXtvuw9m0P0QVq15tc/36FQfyhX5hwUhP3oAlgZ8hd5lKCVaJCh7e eQM3Axr4xfqAdMwLu21Yj4m9zF7cVDySSCtFPztyRAzUY3c7ta3zxmAtb0Aqksqq oVFQEEvFSV+dBdAOr+jwPblx5b8tNA==
=7qmj
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

On Sun, Dec 08, 2024 at 06:21:23PM +0100, أحمد المحمودي wrote:

On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:

Otherwise I think the package is good to upload. Maybe the other
warnings can be fixed later.

---end quoted text---

A recent build gsve this lintian issue:
W: python3-cocotb: python-module-in-wrong-location usr/lib/python3.13/dist-packages/cocotb -> usr/lib/python3/dist-packages/cocotb

Thanks for your reply, yet my primary concern, rather than the lintian issues, was the files layout for python3-cocotb:
compiled libs are under: /usr/lib/python3/dist-packages/cocotb/libs/ shouldn't those rather be under: /usr/lib/<multiarch-triplet>/cocotb/ ?

also, the data files (makefiles mostly) are under: /usr/lib/python3/dist-packages/cocotb/share/, shouldn't those rather be under /usr/share/cocotb ?

I'm not sure if this lintian issue is related:
P: python3-cocotb: repeated-path-segment lib [usr/lib/python3/dist-packages/cocotb/share/lib/]

Here's a snipet of the files layout for python3-cocotb:

./usr/lib/python3/dist-packages/cocotb/libs/libcocotb.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbfli_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbutils.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_aldec.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_ius.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvhpi_nvc.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_aldec.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ghdl.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_icarus.vpl ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_ius.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_modelsim.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_vcs.so ./usr/lib/python3/dist-packages/cocotb/libs/libcocotbvpi_verilator.so ./usr/lib/python3/dist-packages/cocotb/libs/libembed.so ./usr/lib/python3/dist-packages/cocotb/libs/libgpi.so ./usr/lib/python3/dist-packages/cocotb/libs/libgpilog.so ./usr/lib/python3/dist-packages/cocotb/libs/libpygpilog.so

./usr/lib/python3/dist-packages/cocotb/share/include/ ./usr/lib/python3/dist-packages/cocotb/share/include/cocotb_utils.h ./usr/lib/python3/dist-packages/cocotb/share/include/embed.h ./usr/lib/python3/dist-packages/cocotb/share/include/exports.h ./usr/lib/python3/dist-packages/cocotb/share/include/gpi.h ./usr/lib/python3/dist-packages/cocotb/share/include/gpi_logging.h ./usr/lib/python3/dist-packages/cocotb/share/include/py_gpi_logging.h ./usr/lib/python3/dist-packages/cocotb/share/include/vhpi_user_ext.h ./usr/lib/python3/dist-packages/cocotb/share/include/vpi_user_ext.h ./usr/lib/python3/dist-packages/cocotb/share/lib/ ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/ ./usr/lib/python3/dist-packages/cocotb/share/lib/verilator/verilator.cpp ./usr/lib/python3/dist-packages/cocotb/share/makefiles/ ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.deprecations ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.inc ./usr/lib/python3/dist-packages/cocotb/share/makefiles/Makefile.sim ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/ ./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.activehdl
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.cvc
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ghdl
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.icarus
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.ius
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.modelsim
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.nvc
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.questa
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.riviera
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.vcs
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.verilator
./usr/lib/python3/dist-packages/cocotb/share/makefiles/simulators/Makefile.xcelium

Sorry for the late reply, I had no internet access in the previous
months.

--
‎أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761
8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

---end quoted text---

--
‎أحمد المحمودي (Ahmed El-Mahmoudy)
Digital design engineer
GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7
GPG Fingerprints:
6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761
8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEggahliCEfm0N+LF2vBlqlO3dobcFAmdjf6UACgkQvBlqlO3d obevpgf/RBI2ZAKIavoM9t1TVZhBiDg3csZwELoqXghcL5gcLTMfHMCTB1mNprTs z4kStAg+nIaCSpooIjhryzFZW3rX3zxrV4MkixvPW5xSnJ/n5cPHJSUQydCudEdK r8+6PZES2lgNRsdCZYvcVgfBoaYDfBJ56byDJcNvA37zx0PQVrbyxvKuAfI1R/zV RScoxZyUDt+syvnFVM4HKx6W5y2QHUuAWQrTGwDg7scqalmy3MTZO4YYWe4A0Frd Hbp3DQKOHZT/JZjATX7XkRalHc2H6fi+TpoVJBZEyf9BZGd4ggPLss3GHHfW4srO WVSAvM8nPYWBA+UXfpmXaU/maeSzRA==
=RJwh
-----END PGP SIGNATURE-----

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)

Am 19.12.24 um 04:06 schrieb أحمد المحمودي:

On Sun, Dec 08, 2024 at 06:21:23PM +0100, أحمد المحمودي wrote:

On Mon, Aug 12, 2024 at 09:01:33PM +0200, Agathe Porte wrote:

Otherwise I think the package is good to upload. Maybe the other
warnings can be fixed later.

---end quoted text---

A recent build gsve this lintian issue:
W: python3-cocotb: python-module-in-wrong-location usr/lib/python3.13/dist-packages/cocotb -> usr/lib/python3/dist-packages/cocotb

You've forgot to add dh-sequence-python3 to the Build-Depends?
Iy you add this package you can then also drop "--with=python3" in the
default make target in debian/rules.

And you should consider to sort the entries in debian/contral
alphabetical, this helps human to read the entries more eaasy.

--
Regards
Carsten

--- SoupGate-Win32 v1.05
* Origin: fsxNet Usenet Gateway (21:1/5)