1. Forum
  2. Usenet
  3. LINUX.DEBIAN.MAINT.PYTHON

  • review for kivy/2.1.0-1

    From Jeroen Ploemen@21:1/5 to All on Thu Dec 8 16:30:01 2022
    hi Dean,

    I reviewed the kivy package up for sponsorship in the Python team:

    * There's quite a few lintian hits [1], and most of those look legit.
    Please fix the correctly identified issues, and add overrides for
    any false positives.

    * In the changelog, you should mention this is a team upload;
    otherwise (with you not listed as either maintainer or uploader) it
    looks like an NMU.

    * The copyright file is missing many entries, including: doc/sources/.static/jquery.cookie.js:6: * Copyright (c) 2010 Klaus Hartl (stilbuero.de)
    doc/sources/.static/jquery-effects-core-and-slide.js:4: * Copyright 2011, AUTHORS.txt (http://jqueryui.com/about)
    doc/sources/.static/jquery-effects-core-and-slide.js:736: * Copyright 2001 Robert Penner
    kivy/lib/kivy_endian.h:3: Copyright (C) 1997-2018 Sam Lantinga kivy/lib/sdl2.pxi:1:#Copyright (c) 2010-2012, Gabriel Jacobo kivy/lib/libtess2/Source/...:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
    kivy/lib/libtess2/Include/tesselator.h:3:** Copyright (C) [dates of first publication] Silicon Graphics, Inc.
    kivy/tools/pep8checker/pep8.py:4:# Copyright (C) 2006-2009 Johann C. Rocholl kivy/tools/pep8checker/pep8.py:5:# Copyright (C) 2009-2014 Florent Xicluna kivy/tools/pep8checker/pep8.py:6:# Copyright (C) 2014-2016 Ian Lee


    Once fixed, simply add the package back to the RFS list in the IRC
    channel topic.


    [1] https://salsa.debian.org/python-team/packages/kivy/-/jobs/3617039

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmOSAn0ACgkQQoMEoXSN zHrzDhAAuk61jH9l26Gsnt/uETghUFHuyNDv3ZqlEeC1U22r4pI2op9SEy4xMkrf eoQYBxcvt/o72+vwCAo3pY5kmmsOjEaWlTsC1C7rd4SaI5FLv2qa82miMOBp4zOH OPCaiX/TTvwVnV8mKnjOwkY4y0UBx0SHNDOhZnLD2HpqYdumrtUKsWZu4crMpgzS eoPG8v/d2hPETZEcGA02yLQGmpzC7qJUOEV9ajcxdTS/u06mkuW0suu3AC26Vb/8 CQTmqaShjGtPyKL8oKJoU3pV+pd7K/w4XSUJVmpS+fwEKh3o+bYOdGcFyq9TeyY/ xmwT3EJQ/0jPdUx+ejx+qtoIJFv/X234uFtrgeANlprIAHMCJY6UitLO6s4YUSRA QmynePJiPE2gGizFRrVFjs+tJ6azwaXCpDs5xEov62Tf/d9biHD8Q10yuycmw0Wq +C46okM8nBiwD7KTw6EQ6qQ6RVM9TQy/kCzrN/wl03e9syNUm1HgBATnAIv0kNyD gmw17zGnHfbg2RJQ/qf8r7xFIlbTM23WRmrdgbPy5lJbk8Sbs5/LvFnQT1GqTb1p 7Kp8vpUvt/Lp0/J+ctVTLDUHLo9tnfZpvx3sBjYXYTH3MNSiVj0YSKnkf/AJtDfZ X6jXlAwwiugvEW2rE5uVDauVD4H9iKxE6K8GPJyaZ3mJpSd22DI=
    =ZctZ
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jeroen Ploemen@21:1/5 to All on Tue Dec 27 19:30:01 2022
    hi Dean,

    thanks for making all those improvements. Only a couple of things
    remaining:

    * Copyright: try using standard license shortnames [1] where
    possible: Easing appears identical to BSD-3-clause; Khronos looks
    a lot like Expat.

    * Rules, lintian: are the files in kivy/tools/image-testsuite somehow
    used by or called from within kivy? The readme in there talks about
    generating image test suites for kivy's imageloaders. I don't know
    whether this is something end users of kivy normally do; if not,
    probably best to not install that directory at all rather than
    appease lintian with an override and that chmod in d/rules.


    [1]https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmOrN8YACgkQQoMEoXSN zHr5QBAAx1TW4Wk4tUJdjQ3/s91UHqXV3+I+RYY2HAM1CUXfYMoWN/OCBBCohq7t nyWYTeHFfsVCbD8ihMdtZovQtA38624i+u39LIg/WJaVfpAyVsnfIbQHeZm+gKXJ BbtM7f2F4ePzk4afQ9Lapj28eX97kGKj2dGfT4JaWPXgRl8T0iWlNYNtAU6cRa7C sfTXYkKz0O+zwDL4vxWSNbO7X8juAzce2NANgAE/yGWi0bpfyiQJRMbEP6aTsefU +8bVLF7+7iczsNRThYK2+bC8If9Cj/TEpGP25XmMLqwmNA6gTxly4z5mcoLwqus0 76mJ40bCYlrN35AhBuV4HdKiPUCzIFBSxiz/sWSvW22KPgCZZ1Pwr6EXZci+ApgL /kdTcvYaRwLME1rMi/kS+4OMGkWmVVCWfws5tfWN9ip2FvMIcLFJa3Br6Qf8EICs Nw+wTAusiGn5fo77lXbOwhKqrryReACFqqvaFgy++R7I2b23skERRU1rFu7OZU3+ ro/9QoJu2frVpeIOPm1YAc+xGvv2ho5HB4yl708xARlX1e3rIPJuSj4yJv4D3nG5 OSJYZhGHm3ePes9WPINsLdipPNHJ8Dcol/ygcfnSkGlWrMZAH0WnxNosWfIlswPC I+spMrE17Cx2f5qk8I83EwV65bjRjHBBXS5qEnfv4DxL3bnm8VE=
    =Mgf4
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From jcfp@21:1/5 to All on Sun Jan 1 12:20:01 2023
    ---- On Sun, 01 Jan 2023 07:06:20 +0100 Dean Serenevy wrote ---
    * Copyright: try using standard license shortnames [1] where
    possible: Easing appears identical to BSD-3-clause; Khronos looks
    a lot like Expat.

    You're right, the wording differed from the sample text, so I used different names, but the differences are not enough to change the license.

    I can change the Easing to use the BSD-3-clause short name, but I'm not sure what to do about the Khronos. The copyright file already has an "Expat" entry and according to Policy section 12.5. A "verbatim copy of its copyright and distribution license"
    must be included. An email in debian-legal [1] clarifies that really there should be no changes other than minor punctuation or whitespace variations. The standard Expat uses the word "Software" and the Khronos uses "Materials".

    If I need a verbatim copy of both licenses, don't I need to rename one of them? If I merge them, which text do I keep?

    I didn't do a word-for-word comparison, I usually recognise Expat because it uses some specific legalese terms. So thank you for being so precise when looking into this. If they're different enough (somewhat of an edge case here, maybe Khronos includes
    material that may not be universally considered "software" such as images or fonts?), you should indeed keep two entries (each with its own shortname). Maybe one Expat and the other Expat-Khronos to signal the license terms are very close but not
    identical?

    PS: I'm using an ancient laptop while waiting for a replacement part for my normal system, so it could be a few days before I can do an upload.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Vincent Cheng@21:1/5 to All on Thu Jan 5 10:20:01 2023
    Hi Dean,

    Thanks for doing the heavy lifting in getting kivy/2.1.0-1 ready for
    upload! I'm currently going through all of the packages that I
    (co-)maintain in preparation for the upcoming freeze, and you've saved
    me a ton of work here! I've pushed a few very minor changes to the
    packaging, but otherwise I think this is ready for upload; if Jeroen
    isn't planning on uploading kivy in the next day or so, I'd be happy
    to do so myself. I also invite you to add yourself as an Uploader in
    d/control if you anticipate maintaining kivy in the future.

    One thing I wanted to bring up before actually uploading kivy is that
    you've added a new (emacs-specific) binary package, and adding a new
    binary package will force kivy to take a round-trip through the NEW
    queue. While that's not usually a problem, since we're so close to the
    freeze, there's a risk that ftpmasters may not be able to review it in
    time before the freeze takes effect. Would you consider either merging
    the contents of elpa-kivy-mode into python3-kivy, or defer adding the
    new package for a subsequent upload? Thanks!

    Regards,
    Vincent

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Jeroen Ploemen@21:1/5 to Vincent Cheng on Thu Jan 5 18:30:02 2023
    On Thu, 5 Jan 2023 01:17:40 -0800
    Vincent Cheng <[email protected]> wrote:

    to the packaging, but otherwise I think this is ready for upload;
    if Jeroen isn't planning on uploading kivy in the next day or so,

    My system has been resurrected, and I'm fine with the current state of
    the kivy packaging as well. I do share Vincent's concerns about adding
    a new binary pkg this close to the upcoming freeze though.

    -----BEGIN PGP SIGNATURE-----

    iQIzBAEBCgAdFiEEd8lhnEnWos3N8v+qQoMEoXSNzHoFAmO3Bu8ACgkQQoMEoXSN zHqWABAAlB9JqUx7Hz6bvWOTQBTRo0NaUaPqk340Dcmb+VaIIWj+Q7nb6gAWdGLx /REVkg5r9AJLoKjSoLVwY2viJOeq+sBuZt4/Wb115k6JRyVTg46ryL86z64N7eRz yfNoAiv3hA7gr3MkJFBP33LrSZfxCJXRM0AFnS7lxXrdw+Ivo73nuWuAWJ6hLsMG znnnrUImpy/i6H91zN8u5oAZ113Vh32FO+0XbEYnZTT635Yo9eU6cjh3TZZMqILx Qq3ufIajhDOZlz6kGP4+e10b4KovW6EYjiEyVSkGnFyN72h0W+fObHFTarusMmiy lyyn9aotOJdWAOiaMKZ6z7iVScS1xWJ+mFlNcLRHtDExePN7Fty3QHQuwntV4zBz xiBzwJ5+mAZHF8bRYf4RRYWSXL6gbKlrJfVaMhB1iRT88lnS92WADQO5RYGVeVa0 mavpE4scYHwnB7GrAqdxFfEk7Y7lLMSsd8NChO7tRMqk3Ha/QB2JIogxaVnM2SvL utLgsb8HlUXc9Q6vLHwR6KUg7X3+MXegupjZJyyMu2m/SD0rKw63B6aEL7Q2kqbh 8b1poYpgQimjo6v2bcjU90t3RHcjvSb4gUFTARBMuN511w2jrPss5ezzdTTBjVer hZNuiBkX33nOoz7V6Ds3ZH4iSBR5TNEqEmefHKj288FGjTdNeY4=
    =uC9+
    -----END PGP SIGNATURE-----

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)