1. Forum
  2. Usenet
  3. COMP.LANG.TCL

  • Improvement proposal regarding the clam theme

    From nemethi@21:1/5 to All on Wed Feb 15 13:30:12 2023
    To all interested in scalability of the widgets in Tk 8.7: I have just
    filed a ticket regarding the ttk::checkbutton and ttk::radiobutton
    indicators of the clam theme. See

    https://core.tcl-lang.org/tk/tktview/fecc86e5e0

    I would welcome any comments in this newsgroup or on the ticket page.

    --
    Csaba Nemethi https://www.nemethi.de mailto:[email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From nemethi@21:1/5 to All on Thu Feb 16 10:57:17 2023
    Am 15.02.23 um 13:30 schrieb nemethi:
    To all interested in scalability of the widgets in Tk 8.7:  I have just filed a ticket regarding the ttk::checkbutton and ttk::radiobutton
    indicators of the clam theme.  See

        https://core.tcl-lang.org/tk/tktview/fecc86e5e0

    I would welcome any comments in this newsgroup or on the ticket page.


    As mentioned in that ticket, the indicators of the ttk::checkbutton and ttk::radiobutton widgets of the clam theme don't look really good,
    especially on a scaled screen, as shown in the screenshot

    https://core.tcl-lang.org/tk/artifact/03910bf53627cc03

    The ticket proposes to replace the C code responsible for drawing these indicators with one using SVG-images, in order to get really professional-looking and properly scaling indicators, as shown in the screenshot

    https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b

    The new implementation is completed and fully tested. The question is:

    *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    I would highly appreciate to hear your opinion regarding this subject.
    Many thanks in advance for your feedback!

    Csaba

    --
    Csaba Nemethi https://www.nemethi.de mailto:[email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Mark Case@21:1/5 to All on Thu Feb 16 06:17:14 2023
    I've used the Clam theme for years, but have always avoided using its radiobuttons and checkbuttons, because of the reasons stated in Csaba's comments. This is a huge improvement to the theme and I'm hopeful that it will get implemented asap!

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Christian Gollwitzer@21:1/5 to All on Thu Feb 16 15:38:39 2023
    Hi Csaba,

    Am 16.02.23 um 10:57 schrieb nemethi:
    The ticket proposes to replace the C code responsible for drawing these indicators with one using SVG-images, in order to get really professional-looking and properly scaling indicators, as shown in the screenshot

        https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b

    The new implementation is completed and fully tested.  The question is:

    *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    since this is not a change in functionality, but "only" the looks, and
    it is a massive improvement especially for high resolution screens, I
    would rather consider it as a bugfix, and therefore can and should be integrated any time soon.

    Regards,

    Christian

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Ralf Fassel@21:1/5 to All on Fri Feb 17 11:23:28 2023
    * nemethi <[email protected]>
    | The ticket proposes to replace the C code responsible for drawing
    | these indicators with one using SVG-images, in order to get really
    | professional-looking and properly scaling indicators, as shown in the
    | screenshot

    | https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b

    | The new implementation is completed and fully tested. The question is:

    | *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    Definitely YES.

    R'

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Rolf Ade@21:1/5 to Christian Gollwitzer on Fri Feb 17 13:55:32 2023
    Christian Gollwitzer <[email protected]> writes:

    Hi Csaba,

    Am 16.02.23 um 10:57 schrieb nemethi:
    The ticket proposes to replace the C code responsible for drawing
    these indicators with one using SVG-images, in order to get really
    professional-looking and properly scaling indicators, as shown in
    the screenshot
        https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b
    The new implementation is completed and fully tested.  The question
    is:
    *Should it be incorporated in Tk 8.7b1, which will be released soon?
    *

    since this is not a change in functionality, but "only" the looks, and
    it is a massive improvement especially for high resolution screens, I
    would rather consider it as a bugfix, and therefore can and should be integrated any time soon.

    +1


    Regards,

    Christian

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From saitology9@21:1/5 to nemethi on Fri Feb 17 11:58:40 2023
    On 2/16/2023 4:57 AM, nemethi wrote:

    The new implementation is completed and fully tested.  The question is:

    *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    I would highly appreciate to hear your opinion regarding this subject.
    Many thanks in advance for your feedback!


    Yes, definitely!

    How about regular checkbutton and radiobutton widgets? Are they covered
    as well?

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From nemethi@21:1/5 to All on Fri Feb 17 18:58:40 2023
    Am 17.02.23 um 17:58 schrieb saitology9:
    On 2/16/2023 4:57 AM, nemethi wrote:

    The new implementation is completed and fully tested.  The question is:

    *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    I would highly appreciate to hear your opinion regarding this subject.
    Many thanks in advance for your feedback!


    Yes, definitely!

    How about regular checkbutton and radiobutton widgets?  Are they covered
    as well?




    Yes, in Tk built from trunk the Tk core checkbutton and radiobutton
    widgets on both X11 and Windows are scaling-aware too, meaning that they
    will be scaled automatically, according to the display's DPI scaling
    level. The C code for X11 was joint work by Brian Griffin and myself.

    --
    Csaba Nemethi https://www.nemethi.de mailto:[email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From saitology9@21:1/5 to nemethi on Fri Feb 17 13:47:00 2023
    On 2/17/2023 12:58 PM, nemethi wrote:


    Yes, in Tk built from trunk the Tk core checkbutton and radiobutton
    widgets on both X11 and Windows are scaling-aware too, meaning that they
    will be scaled automatically, according to the display's DPI scaling
    level.  The C code for X11 was joint work by Brian Griffin and myself.


    Great! Thank you for all that you do.

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From Harald Oehlmann@21:1/5 to All on Mon Feb 20 11:44:15 2023
    Am 17.02.2023 um 13:55 schrieb Rolf Ade:
    Christian Gollwitzer <[email protected]> writes:

    Hi Csaba,

    Am 16.02.23 um 10:57 schrieb nemethi:
    The ticket proposes to replace the C code responsible for drawing
    these indicators with one using SVG-images, in order to get really
    professional-looking and properly scaling indicators, as shown in
    the screenshot
        https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b
    The new implementation is completed and fully tested.  The question
    is:
    *Should it be incorporated in Tk 8.7b1, which will be released soon?
    *

    since this is not a change in functionality, but "only" the looks, and
    it is a massive improvement especially for high resolution screens, I
    would rather consider it as a bugfix, and therefore can and should be
    integrated any time soon.

    +1

    +1

    Great work !

    Harald

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)
  • From nemethi@21:1/5 to All on Mon Feb 20 17:20:13 2023
    Am 16.02.23 um 10:57 schrieb nemethi:
    Am 15.02.23 um 13:30 schrieb nemethi:
    To all interested in scalability of the widgets in Tk 8.7:  I have
    just filed a ticket regarding the ttk::checkbutton and
    ttk::radiobutton indicators of the clam theme.  See

         https://core.tcl-lang.org/tk/tktview/fecc86e5e0

    I would welcome any comments in this newsgroup or on the ticket page.


    As mentioned in that ticket, the indicators of the ttk::checkbutton and ttk::radiobutton widgets of the clam theme don't look really good,
    especially on a scaled screen, as shown in the screenshot

        https://core.tcl-lang.org/tk/artifact/03910bf53627cc03

    The ticket proposes to replace the C code responsible for drawing these indicators with one using SVG-images, in order to get really professional-looking and properly scaling indicators, as shown in the screenshot

        https://core.tcl-lang.org/tk/artifact/b3e191fe1c300b7b

    The new implementation is completed and fully tested.  The question is:

    *Should it be incorporated in Tk 8.7b1, which will be released soon? *

    I would highly appreciate to hear your opinion regarding this subject.
    Many thanks in advance for your feedback!

    Csaba


    Many thanks to all who have posted their comments! Motivated by the
    positive feedback, I have merged the code into trunk and have closed the
    ticket with the resolution "Fixed". Let's hope to see the Tk 8.7b1
    release within the next few weeks!

    Csaba

    --
    Csaba Nemethi https://www.nemethi.de mailto:[email protected]

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)