1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/smblib/smbtxt.c

    From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Mar 13 18:54:21 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3503816fa5247306ec9ef37b
    Modified Files:
    src/smblib/smbtxt.c
    Log Message:
    Replace sprintf() calls with safe_snprintf()
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Mar 13 18:54:21 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/6895c8daf038e7d39a2330eb
    Modified Files:
    src/smblib/smbtxt.c
    Log Message:
    Fix heap corruption of qp_decode()qp_decode (quoted-printable in-place decode of a string) could write 2 characters *beyond* the allocated buffer by appending "\r\n" to a string that was not quoted-printable in the first place. i.e. the contents of buf were not actually changed in the decode loop. This could result in a corrupted heap and crash of sbbs or smbutil when reading such a message.This change may result in a lack of CRLF appended to decoded plain text output, so we'll have to keep an eye out for that and resolve it some other way. One possibility could be to only append the CRLF if the destination pointer is sufficiently behind the source pointer.This solves the crash that Kirkman reported with a specific message in his "mail" base. The header for the message said it was quoted-printable encoded, but the body text was not actually encoded at all:OtherHeader Content-Type: text/plain; charset="iso-8859-1"OtherHeader MIME-Version: 1.0OtherHeader Content-Transfer-Encoding: quoted-printable
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows)@1:103/705 to Git commit to main/sbbs/master on Mon Apr 3 11:43:07 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/1ca7f708fe87ea825cb0e5af
    Modified Files:
    src/smblib/smbtxt.c
    Log Message:
    Fix decoding of tab-indented 'charset' of multi-part MIME text partsApple Mail apparently uses tabs to indent the charset of nested MIME parts:e.g.--Apple-Mail-143B9F0C-6BB4-4C8E-869B-6DE05D6B58CEContent-Type: text/plain;<tab>charset=utf-8Content-Transfer-Encoding: quoted-printableThis fixes issue #483 reported by Nelgin
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on ChromeOS)@1:103/705 to Git commit to main/sbbs/master on Thu Feb 19 23:08:52 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/685cbb887a04725dc4935e19
    Modified Files:
    src/smblib/smbtxt.c
    Log Message:
    Confirm SDT FILE* is non-null

    Bug occurred where this function was called with a zeroed-out smb_t and it was not handled gracefully (got an exception in stdio functions because of the
    NULL std_ftp) - so handle it as gracefully as we can here.

    Most bugs have 2 causes...
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)