• src/sbbs3/netmail.cpp

    From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Sun Mar 13 00:28:10 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/7e1c3c3d3944249c05686250
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix CID 319119: Unchecked return value from libraryActually probably doesn't fix it, but what'evs
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to Git commit to main/sbbs/master on Fri Jun 10 22:54:03 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/121ce679be01b8f4fa5131c2
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Safe string formatting of fido netmail time header fieldSuppresses GCC warning. I suppose some of these fields could be more digitsthan expected.
    --- SBBSecho 3.15-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Fri Dec 29 17:10:28 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/8f54b5ce31565dd8031982b0
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix error path memory leak (unlikely, but not impossible)

    CID 462234
    --- SBBSecho 3.20-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Jan 22 15:08:08 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/4aa2274c97e8e79e46d3d757
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Refuse to send netmail to our own addresses

    as Keyop pointed out, at least for FTN netmail, this would just create an orphaned .msg file in the netmail directory: SBBSecho won't import it (by default) because it was created locally and won't export it to a packet because you don't have a link to yourself. Internet email would just loop back
    (if everything's configured and working) and sending to your own QWK-ID would've already been rejected. Hopefully nobody is depending on the Internet e-mail loopback functionality.

    There were sysop exemptions for when the "Allow Sending of ..." settings in SCFG->Networks->Internet E-mail and FidoNet were set to "No", but now those
    are defeated (if they're set to, even the sysop won't be able to send e-mail/ NetMail). If we really want to control *who* can send netmail, we should
    be using ARS for that rather than a toggle that just (confusingly) doesn't apply to the sysop(s).
    --- SBBSecho 3.35-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Wed Feb 11 22:20:06 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/f0545836096d44c51b14bdb1
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Redirect netmail sent to local user's netmail address to personal inbox

    If a user attempts to send netmail to a netmail address that is invalid (because it's local) yet there's a user with that address configured as their netmail address (in the userbase), send the message as an email to that user. Rather than just failing with error "Invalid NetMail address: <name@address>" --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Windows 11)@1:103/705 to Git commit to main/sbbs/master on Thu Feb 19 22:53:59 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/002aa81ea984222fb9e48845
    Modified Files:
    src/sbbs3/netmail.cpp
    Log Message:
    Fix bug: wrong smb_t* passed in here

    Would cause a NULL fp to try to be used to quote the message text

    Introduced in commit f0545836096d44
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)