1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • Convert Simple Shell from Baja to JS

    From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 15:03:47 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9343

    This line is bugging me #fall through exec_bin "str_cmds %s" end_cmd I am guessing if no commands it goes here! I am not sure how to call this in JS in this shell. Other's use ; and command correct?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From nelgin@1:103/705 to Thomas McCaffery on Sat Jun 13 19:26:24 2026
    On Sat, 13 Jun 2026 15:03:47 -0700
    "Thomas McCaffery" (VERT) <VERT![email protected]>
    wrote:
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9343

    This line is bugging me #fall through exec_bin "str_cmds %s" end_cmd
    I am guessing if no commands it goes here! I am not sure how to call
    this in JS in this shell. Other's use ; and command correct?

    ---
    � Synchronet � Vertrauen � Home of Synchronet �
    [vert/cvs/bbs].synchro.net
    Maybe some more context would be useful but in JS you would use // for
    a single line comment or /* whatever */ for a comment block.
    --
    End Of The Line BBS - Plano, TX
    telnet endofthelinebbs.com 23
    ---
    � Synchronet � End Of The Line BBS - endofthelinebbs.com
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:19:15 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9350

    Other shell's use the ; prefix for string commands, yes, but not the simple shell.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:21:59 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9351

    Why is this a while() loop?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:23:04 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9351

    Looks like a potentially infinite loop (when console.getkey() returns some unexpected value).
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:24:29 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9352

    white-space/indent issue
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:24:42 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9353

    white-space/indent issue
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sat Jun 13 18:25:33 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9354

    Why is this function being reimplemented here?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Sun Jun 14 18:40:12 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9372

    I see why I was doing this to Flush Keyboard Buffer and prevent leftover keystrokes from auto-submitting commands. However, I see your point.

    ###
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Sun Jun 14 18:41:57 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9372

    The `inkey()` loop was originally intended to flush the keyboard buffer before calling `getstr()`, to prevent leftover keystrokes from auto‑submitting commands. I agree the implementation wasn’t ideal. I will replace it with a safer version using a timeout, CPU yield, and proper termination checks.

    ###
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sun Jun 14 19:42:16 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9380

    Crazy indentation here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sun Jun 14 19:42:54 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9381

    Crazy identation.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Sun Jun 14 19:43:15 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/698#note_9382

    Did you miss my previous comment about loops?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)