• Add OBV/2 shell port from Baja to JS

    From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 13:40:55 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9087

    I don't see any reason you need that library - the functions are not reused anywhere. Just move the functions you need out of that file and you can delete it and remove this line.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 13:41:40 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9088

    I suspect rather than having this function, the shell should instead just execute filescancfg.js (as other shells do) - that'll allow *configuring* the file listing (new scan pointer, listing type, etc.). At least, that's how I suspect this menu key is supposed to work.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 13:41:51 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9086

    See `user_settings.js` for the proper way to print the user's configured default download protocol. Or use one of the (3) @-codes for the protocol name. There are more than 3 possibilities.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 14:11:20 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9091

    Ok will do. I just read this now after redoing some.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 14:18:09 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9092

    Remove the $ (donation function), X (Sysop wants function)? Replace K with filescancfg.js.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 14:27:51 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9092

    The plan remove the $ (donation function) to X (Expert Mode) don't see any reason to keep this X (Sysop wants function) moved to obv-2 shell. Replace K with filescancfg.js. Remove the obv2_lib file.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 14:47:06 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9096

    The following was done:

    Command K (in file menu) now uses filesscancfg.js

    Command $ (in main menu) was removed in main.msg file and replaced with X (Expert Mode Toggle)

    Command X (In file menu) is now coded in shell

    removed the unnecessary obv_2_lib
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 16:56:58 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9098

    This is still wrong. See my previous comment about this.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 16:58:21 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9099

    I am sure removed that file completely. I have to check on my end.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:19:00 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9100

    Ah, indeed you did.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:20:16 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9102

    that obv_2_lib.js file is completely gone. I moved all the functions to obv-2.js. The K command in file menu uses now filescancfg.js. Is it still showing on your end as not a deleted file?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:20:22 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9103

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:20:28 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9104

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:20:34 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9105

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:20:47 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9106

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:21:24 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9107

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:23:35 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9108

    Why? This means any users that runs this shell will forever have "cold keys" enabled (and no way to disable them). That doesn't seem like something the sysop or user would want to happen.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:24:11 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9109

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:24:34 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9110

    White space (indent) issue here.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:26:01 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9111

    The whitespace differences shown in the diff are caused by GitLab misrendering Synchronet ANSI attribute codes. The actual file indentation is correct — see the raw file view. I could be wrong though. However, I checked on my end and all the spaces correct. I even looked at raw file.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:27:01 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9112

    You shouldn't have raw Ctrl-A in the JS source file, use "\x01" to embed a Ctrl-A sequence in a JS string.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:27:57 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9113

    I do see a couple wrong perhaps.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:28:01 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9114

    But the problem looks like a tabs versus spaces issue. I think if you looked at the raw file with different tools, you'd see the alignment issue.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 17:28:20 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9115

    I see now thanks
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:08:33 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9123

    I used wrong editor and not realizing saved it as encoding Ansi, lol. I should have used Sublime in first place.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:32:00 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9125

    Also, "cold key" support is on the chopping block: https://wiki.synchro.net/dev:chopping_block

    Is this something you really want? Your shell's menus could require the user to press enter (e.g. by using getstr instead of getkey) but I'm not sure if that behavior of the old Forum boards we want to replicate or not (maybe? But the Baja version of this same shell did not, and nobody ever complained about that fact).
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:49:00 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9127

    I thought OBV/2 relied on Cold Keys. I was going to do something like this:

    ```
    //
    // OBV/2-style input WITHOUT Cold Keys
    // This overrides shell_lib's getkey/getcmd behavior
    //
    function getcmd() {
    console.line_counter = 0;

    while (bbs.online && !js.terminated) {
    let ch = console.inkey(K_NONE, 5);
    if (!ch)
    continue;

    // Arrow keys
    if (ch === '\x1b') {
    let next = console.inkey(K_NONE, 50);
    if (next === '[') {
    let arrow = console.inkey(K_NONE, 50);
    switch (arrow) {
    case 'A': return "UP";
    case 'B': return "DOWN";
    case 'C': return "RIGHT";
    case 'D': return "LEFT";
    }
    }
    }

    // Slash commands
    if (ch === '/') {
    let second = console.getkey(K_UPPER);
    return "/" + second;
    }

    // Normal hotkeys
    if (/[A-Za-z0-9]/.test(ch))
    return ch.toUpperCase();

    if (ch === '\r')
    return "ENTER";

    return ch;
    }

    return null;
    }
    ```
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:49:56 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9128

    I will just remove that forced line.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:53:40 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9133

    Indent/white space issue.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:53:47 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9134

    Indent/white space issue.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:53:53 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9135

    Indent/white space issue.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 18:54:03 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9136

    Indent/white space issue.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 19:59:55 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9138

    I have no idea what is going on. I am going to close this and reopen it.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Mon Jun 1 20:00:19 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9139

    I am going to figure out why I keep getting ident spaces
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Jun 2 01:23:18 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/683#note_9149

    Do you have you editor configure to enter spaces or tabs when you indent the code (e.g. with the tab or auto-indented)?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Tue Jun 2 01:33:09 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9150

    The tab (ASCII 9) character displays differently depending on the program (terminal, editor, etc.) that is displaying the text file - often it's 8 chars, but sometimes its 4 or 3 or 2 or 1. The problem is that you're mixing tabs and spaces in your source file. The Synchronet general rule for source code is: use tabs for indentation and spaces for alignment (as specified in exec/.editorconfig). If you can't do that, just use tabs everywhere. If you can't do that, use spaces everywhere. But what we can't have is a mix of spaces and tabs (what you've got here). :-)

    Most editors have options to display tabs as special characters so that they're obvious to you. Try that or run the code through a beautifier.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Tue Jun 2 08:28:02 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9153

    I just updated the editor and used .editconfig. Also, I moved sysop wants into a function to make it look cleaner. How does it look now? Thanks.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Wed Jun 3 11:11:26 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9171

    I checked with VS code and it's fine on my end. Is that why it keeps failing pipeline or is it something else?
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 20:36:06 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9198

    This needs to be rebased.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 21:09:23 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9215

    ok, just rebased.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 21:27:05 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9219

    Looks like you added 5 files from src/sbbs3 as part of your commit. Those need to be removed from the commit/MR.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 21:41:38 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9224

    Pipeline failed because, similar to the other shell, you remove the .src file without updating the exec/Makefile (and GNUmakefile):
    ```
    make[1]: *** No rule to make target 'obv-2.bin', needed by 'all'. Stop.
    ```
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 22:31:56 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9232

    You still have 5 changed src/*.c* files included in this commit, accidentally, I assume.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 23:00:39 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9244

    The pipeline failure this time was just bad luck:
    ```
    error MSB6006: "CL.exe" exited with code -1073741819.
    ```
    Try again.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Thomas McCaffery@1:103/705 to GitLab note in main/sbbs on Thu Jun 4 23:20:43 2026
    https://gitlab.synchro.net/main/sbbs/-/merge_requests/684#note_9253

    Yes, it was a mistake. Thanks for your patience.
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)