1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/smblib/smblib.c

    From rswindell@VERT to CVS commit on Sat Apr 4 15:11:36 2020
    src/smblib smblib.c 1.205 1.206
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/home/rswindell/sbbs/src/smblib

    Modified Files:
    smblib.c
    Log Message:
    Include more details in "illegal header length increase" error msg.



    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 01:22:54 2020
    src/smblib smblib.c 1.206 1.207
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv6132

    Modified Files:
    smblib.c
    Log Message:
    On Windows, smb_addmsg() was slow because smb_updatethread() was slow:

    So on Windows, calling unlock() on a file region that you don't have locked, incurs a delay. Likewise, calling lock() on a file region that already have locked incurs a delay. These delays were seriously throttling message imports on Windows (e.g. importing echomail or QWK packets). What should take a few seconds, was taking minutes with noticeable delays. This code has been performing redundant locks/unlocks for over 15 years, so I can only conclude that the performance penalty is a new behavior introduced in recent version(s) of Windows.


    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Tue Apr 14 01:50:32 2020
    src/smblib smblib.c 1.207 1.208
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv11249

    Modified Files:
    smblib.c
    Log Message:
    Some very old, yet inconsistent, behavior of smb_hfield_add() could pretty easily result in a message body being added to a message base with no accompanying message header: if the header data was 0-length, the hfield_dat was not actually allocated and the applicable smbmsg_t convenience pointer was not set accordingly. This had the side effect that if a message were to be imported with a blank recipient ("To" field), the header was not created at
    all (to support mutliple header, single body msgs, i.e. bulkmail).
    The other functions that set the convenience pointers do not treat 0-length header field data special, so this was inconsistent behavior.
    Most message types (e.g. networks) don't want 0-length "to" fields, but that shoudl be enforced somewhere else, not here.


    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Thu May 7 12:30:23 2020
    src/smblib smblib.c 1.208 1.209
    Update of /cvsroot/sbbs/src/smblib
    In directory cvs:/tmp/cvs-serv3248

    Modified Files:
    smblib.c
    Log Message:
    smb_hfield_add_netaddr():
    Don't strip the "user@" portion of a *NETADDR header field if the specified net-type is NET_NONE.


    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Dec 9 00:42:43 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/05104f134188b139a6f3e5ba
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    When a message has been forwarded, invalidate the "to" ext/net ptrs

    The convenience pointers to_ext and to_net need to be invalidated (nullified) if we are going to allow forwarding from local email boxes to network mail and keep all the original message header fields in tact.

    The "Forwarded" field must now be added *before* any new recipient information (local user extension or network address of the forwarding destination).

    This is part of the solution to request #83, #108, and #141.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon May 8 18:07:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/2ee37e4ee9e91ddb2d790f72
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix the relocation of enlarged message headers in smb_putmsghdr()

    The first commit of this feature would leave the base corrupted for a couple
    of reasons (.sha file wasn't opened, using modified header when re-writing the old header to set the DELETED attribute). Both fixed.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon May 8 18:09:07 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b5c5630c1ccd675a559dd98d
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    More detail in error strings in smb_getmsghdr()

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon May 8 18:16:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4985797d2b07ca169326ab6f
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Streamlined code: we need only one check for hyper-alloc'd msg base here

    No functional change.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Sep 13 20:08:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/1ab4ef2bfe0d0b1c7598cc53
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    smb_getmsgidx() now reads entire index records from file bases too

    chksmb needed this to perform filename checks (index against headers).

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Sep 13 20:30:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ffa2c51ba23c59641e1a6e47
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    MSVC requires a 0 in the struct initializer

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Nov 10 16:14:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6224ce6476a079f5e1e7a880
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    Fix printf formatting issue in error message

    GCC and Coverity (x 2) both flagged this one.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Jan 16 20:45:33 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/5bd46a2ed2ff6bbc4aa2fb8a
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    smb_lock(): Confirm the lock file exists after closing it and a short delay

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon May 11 23:57:27 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/931d45a1c1bd411af6c1c16c
    Modified Files:
    src/smblib/smblib.c
    Log Message:
    smb_new_msghdr: auto-repair small .sid/.shd status mismatches; check smb_putstatus return value

    Problem: if the .sid index file length didn't exactly match total_msgs * idxreclen, smb_new_msghdr returned SMB_ERR_FILE_LEN (-206) hard, blocking
    all further message adds until the msgbase was manually repaired. On 2026-05-09 this caused the mail SMB to reject every incoming message for
    ~14 hours (647 logged errors), resulting in SMTP "452 Insufficient system storage" responses.

    Root cause of the corruption: smb_putstatus() was called but its return
    value was silently discarded. If the status write failed after the index record was already appended to .sid, the two files diverged: .sid had one
    more record than total_msgs reflected (or vice-versa).

    Fix 1 — propagate smb_putstatus() failures: the return value is now
    assigned back to i and returned to the caller, so a failed status write is
    no longer silent.

    Fix 2 — auto-repair small discrepancies in smb_new_msghdr (rather than hard-failing) when the mismatch is 1-2 records and the .sid length is an
    exact multiple of idxreclen:
    - LONG by 1 (.sid has one orphan record): truncate the extra record with
    chsize() and continue. This was the May 9 failure mode.
    - SHORT by 1-2 (.sid is missing 1-2 records): reduce total_msgs to match
    the actual index length, persist the correction with smb_putstatus(),
    and continue. The orphaned header/data space is harmless and can be
    reclaimed by smbpack.
    - Mismatch of 3+ records, or non-aligned length: still returns
    SMB_ERR_FILE_LEN as before.

    Test cases (smblib/smbidxtest.c, using CuTest framework):
    Test_NoCorruption - baseline: normal add still works
    Test_ShortIndexByOne - .sid truncated by 1 record: auto-repairs
    Test_ShortIndexByTwo - .sid truncated by 2 records: auto-repairs
    Test_LongIndexByOne - .sid extended by 1 record: truncates and proceeds
    Test_LargeCorruptionFails - .sid truncated by 3 records: still returns -206

    All 5 tests pass with the fix; 3 of 5 fail against the original code.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net