1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/ftpsrvr.c

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Mar 20 20:31:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0ca7156dc5215b928bf5a689
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Reduce log severity of QWK-packet removal error log message to WARNING

    This allows each call to ftp_remote() to specify the log level for any remove failure. All others file-removal failures will continue to log at ERROR level.

    I get this particular (harmless) error a lot, so just reducing to warning:
    ftp ... !ERROR 13 (Permission denied) (line 860) removing file: path/to/*.qwk

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Mar 21 21:56:39 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/05420809878c8fd7f272fa87
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    ftp_remove() returns a bool (not an int) now, so do the right thing

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Fri Apr 17 11:44:32 2020
    src/sbbs3 ftpsrvr.c 1.497 1.498
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv1115

    Modified Files:
    ftpsrvr.c
    Log Message:
    Increase the size of the buffer used to format the download notification short messages (telegrams) from 128 to 256 bytes to resolve observed truncation of download notification messages like this:
    "Guns N Roses - Hotel Brawl Jam (Live).mp3 was FTP-downloaded by Guest [89.245.6.
    199]
    You were awarded 2,057,356 cred"


    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed May 27 01:23:39 2020
    src/sbbs3 ftpsrvr.c 1.498 1.499
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv30088

    Modified Files:
    ftpsrvr.c
    Log Message:
    Log the user name or IP address in more places.


    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat Aug 15 12:15:39 2020
    src/sbbs3 ftpsrvr.c 1.500 1.501
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv23645

    Modified Files:
    ftpsrvr.c
    Log Message:
    More file existence/length checks, with only a WARNING log level (not error) since some QWKnet nodes apparently like to start concurrent QWK packet downloads and inevitably one finishes first, deleting the file, and the second transfer logs and error. Examples:
    8/14 08:10:06p 2296 <EPHRAM> downloading QWK packet (1320 bytes) in passive mode
    8/14 08:10:06p 3792 <EPHRAM> downloading QWK packet (1320 bytes) in passive mode
    8/14 08:10:06p 2296 <EPHRAM> DATA Transfer successful: 1320 bytes sent in 0 seconds (2640 cps)
    8/14 08:10:06p 3792 <EPHRAM> !DATA ERROR 2 (No such file or directory) line 1376 opening s:\sbbs\data\file/0888.qwk
    8/14 11:28:55p 2576 <POTOGOLD> downloading QWK packet (27129 bytes) in passive mode
    8/14 11:28:55p 2576 <POTOGOLD> DATA Transfer successful: 27129 bytes sent in 0 seconds (54258 cps)
    8/14 11:28:55p 1924 <POTOGOLD> downloading QWK packet (4294967295 bytes) in passive mode
    8/14 11:28:56p 1924 <POTOGOLD> !DATA ERROR 2 (No such file or directory) line 1376 opening s:\sbbs\data\file/0168.qwk

    Also some more 64-bit file length support (flength returns an off_t now, not a ulong).
    And ftell() returns a long (not a ulong).



    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Oct 24 22:06:02 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/10477fe29378aebb82b8efd2
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Create the pack*.now with fmutex() to prevent simultaneous QWK packs

    Probably only a problem on Vertrauen, but some QWKnet nodes, for some unknown reason, like to FTP-connect multiple times concurrently and request to download a QWK packet. This creates a race condition where the QWK packet gets created/downloaded/deleted before the second FTP connection can successfully download the same file, thus logging an error "opening file " on the server (VERT). So if the pack*.now file already exists, reject the download request. "What are doing?" is what I really want to ask these nodes, but better just throw them an error response and quietly move on.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Oct 22 14:15:38 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/51ce7e6f71c2009c1804679f
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Attempt to fix issue #799

    receive_thread() needs to use the control session correctly for
    TLS connections.

    ---
    ￭ Synchronet ￭ Vertrauen ￭ Home of Synchronet ￭ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Oct 22 17:20:46 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/17912ca377006ca652483b1e
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    IP addresses are logged (most) everywhere else in square brackets

    There are still places where it could be logged in <> (if username is not yet known).

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Nov 16 19:16:05 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/ffba326dad6263eedc29ed94
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Fix the "ERROR x getting data user y" log message (usernum was 0).

    Add the errno value to help root-cause.

    We really should be using safe_strerror() everywhere.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 16 20:08:50 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/569efded81398f71ad35f70b
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Use safe_strerror() in place of strerror() - everything multithreaded should

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Nov 17 03:11:30 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6fc2a6b6ff98fab8f98bf955
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    A little beautification of errno logging

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Nov 18 01:50:47 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/8b4d02103bb4a63ffcc360f3
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Correct initialization of fmutex_t so the file descriptor is -1

    For some reason, MSVC was initializing the time_t (second element of the struct) to -1, not the int fd (the first element), which was initialized to
    0. Weird.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to Rob Swindell (on Windows 11) on Mon Nov 18 12:01:14 2024
    Re: src/sbbs3/ftpsrvr.c
    By: Rob Swindell (on Windows 11) to Git commit to main/sbbs/master on Mon Nov 18 2024 01:50 am

    For some reason, MSVC was initializing the time_t (second element of the struct) to -1, not the int fd (the first element), which was initialized to 0. Weird.

    Actually, this assessment was wrong. fmutex_open() was memsetting the fmutex_t to zero.
    --
    digital man (rob)

    Synchronet/BBS Terminology Definition #88:
    UART = Universal Asynchronous Receiver/Transmitter
    Norco, CA WX: 61.5�F, 38.0% humidity, 2 mph W wind, 0.00 inches rain/24hrs
    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Jan 15 20:09:08 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/44147ffd5adc1105b4e8600e
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Change terminate_server to correct type expected by xpms_add* functions

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Feb 4 19:16:47 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/1c365418fbab2a23d603d0d1
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Addrss some new MSVC warnings

    Check sscanf() result
    Don't use deprecated function: inet_addr()

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Feb 14 21:58:39 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b4a4a524160fb705bd740506
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Ignore MKD/XMKD commands from users (pretend successful)

    For non-Guest users (without the 'U' restriction), if the FTP client
    sends the MKD or XMKD command, just return the proper succcess result
    and do nothing (don't log as a hack attempt or return a syntax error
    result).

    Some FTP clients (e.g. Reolink Doorbell camera) just always try to
    blindly create a directory before uploading files, but if that command
    fails (as we would), the upload is aborted. So pretend to create the
    diretory whether it already exists or not, just so the client will
    proceed with the upload.

    For G or U restricted users, treat (log) as hack-attempt, as before.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Mar 1 15:05:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/fe48a444e23d7594abfeef1b
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Lower severity of repeated log messages about low disk space

    "!Insufficient free disk space (%s bytes) to allow upload"

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jul 19 14:32:39 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/162b3c708802379e759f9593
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Eliminate unnecessary dir_op() wrapper for user_is_dirop()

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Jul 19 14:32:39 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/d38690513b9294dc948a5310
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Allow uploaders to remove files (via FTP) files that they uploaded

    ... by comparing the uploader name to their user alias (how it's done in the terminal server).

    Fixes issue #952

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Jan 21 16:20:42 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/f4c7be1f00ecda4786a504f0
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Make pointers to state variables shared among threads volatile

    I observed an FTP client abuser getting a lot of logged warnings
    "!DATA TRANSFER already in progress"

    and these thread-shared pointers seemed suspicious. They probably should be converted to atomic bools.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Wed Jan 21 18:16:36 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/457c8e5353470879012ec405
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Better details/stats and readable byte (estimates) on files being downloaded

    And log the reason code (text.dat string number) why access to a download
    was denied.

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 27 22:11:11 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/378136353a6d5d07d00f5394
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Fix typo in error message

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Jan 28 18:29:28 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/1ae43cab351379bfe7f2e181
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Check/update the transfer "inprogress" flag even when terminating the server

    Fix issue #1059

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jan 29 14:56:09 2026
    https://gitlab.synchro.net/main/sbbs/-/commit/f0719cb3041314f6eb52d076
    Modified Files:
    src/sbbs3/ftpsrvr.c
    Log Message:
    Resolve Coverity issue and GCC warning about printf argument type mismatch

    ---
    � Synchronet � Vertrauen � Home of Synchronet � [vert/cvs/bbs].synchro.net